Commit graph

81 commits

Author SHA1 Message Date
Aaron Schulz
42c0f35133 Avoid thumb.php fatal for bad titles on private wikis.
Change-Id: Id2c19d888989fdbaad6412aa9eb62bb22a75f241
2012-10-10 11:16:28 -07:00
Aaron
56266b2ac4 Merge "Worked around hash path inconsistency to unbreak stash file thumbs." 2012-09-20 16:59:09 +00:00
Aaron Schulz
94158d6387 Don't send empty Vary headers.
Change-Id: I0b6bd7ab24323782302c28cf1438dce62f5b8c5a
2012-09-19 21:18:19 -07:00
Aaron
3bbb73468a Worked around hash path inconsistency to unbreak stash file thumbs.
Change-Id: I567467b75a600841440b36352d5675866d3fca2b
2012-09-19 17:45:39 -07:00
Aaron Schulz
e456ef4a0e (bug 39975) Fixed thumb_handler.php handling of /temp thumb urls.
This basically makes the 'rel404' param for temp thumbanils not
start with "/temp" anymore so that they don't count as bogus.

Change-Id: I88c2c50b5372c7b95108d26ba16ddcd91fdb1154
2012-09-18 11:47:27 -07:00
Tim Starling
f1d13a6653 Add Vary: X-Forwarded-Proto to the thumb.php redirect
Also added missing return. Untested.

Change-Id: I975b82d18ba98d1d9b1f2124150af9e5c41f418e
2012-09-12 21:17:37 +00:00
Aaron
97832b6b1d thumb.php now handles short and long thumbnail name formats when possible.
Change-Id: I33932ac0e0294dc13332dce9d4ab00a75d9cdcba
2012-09-12 21:17:09 +00:00
Aaron Schulz
5fbef994cf Revert "thumb.php now handles short and long thumbnail name formats when possible."
Doesn't quite work, since $img->transform() still saved the thumb under the normal name.

This reverts commit 5b33e66b74
2012-09-06 17:52:33 +00:00
Aaron
5b33e66b74 thumb.php now handles short and long thumbnail name formats when possible.
Change-Id: I8e53ce711e23127854185661c5ce8bddbb226623
2012-09-04 14:59:26 -07:00
Aaron Schulz
d22c890890 Fixed and normalized content-disposition for thumbs.
* Previously, thumbnails could have a hex tmp file name as the disposition.

Change-Id: I495860dc54c02d2b3e053e998a41674cd6d07f2f
2012-08-31 22:32:47 -07:00
Tim Starling
ad03f2f753 Revert Uri class due to bug 39710
Revert 94f623363b. Apparently all
ReverseChronologicalPager subclasses were broken by the unexplained
interface change in wfArrayToCgi(): changing the interpretation of
null array values from "omit this key" to "include this key with no
value". The function has always been called with the former
interpretation, that's why the special case was in there.

Also reverted dependent changes 4b517fa and part of 3d97704.

Change-Id: I41dadbde5d0e0e4c54cc76bfc13c263c15c73828
2012-08-28 10:53:09 +10:00
jeroendedauw
38c7f444e1 Use __DIR__ instead of dirname( __FILE__ )
We can now do this since we finally switched to PHP 5.3 for MW 1.20 and get rid of the silly dirname(__FILE__) stuff :)

Change-Id: Id9b2c9cd2e678197aa81c78adced5d1d31ff57b1
2012-08-27 21:45:00 +02:00
Siebrand Mazeland
3d97704f91 Replace some deprecated method calls.
Change-Id: Id4beca7b6821139fcc319c5694917e68668835ee
2012-08-19 23:27:43 +02:00
Alex Monk
2fabea7eea Use wfMessage instead of deprecated wfMsg*
Or $this->msg in special pages.

Change-Id: I774a89d646615053c8424050e42ad95601f92543
2012-08-18 14:11:05 +02:00
Aaron
25fe23a403 Various thumb.php fixes.
* Made wfThumbHandle404() handle full REQUEST_URI urls.
* Made wfExtractThumbParams() handle protocal relative zone urls.
* Added FileRepo::getZoneHandlerUrl() and site zone configuration to simplify wmf rewrite rules.
* Renamed some variables to be less misleading.

Change-Id: Ic3e23c2a623c1241ee22a9811aee073fb07aa68c
2012-07-26 13:59:07 -07:00
Alexandre Emsenhuber
f27ff698fb Added missing GPLv2 headers in some places.
Also made file documentation more consistent.

Change-Id: I30e124514396f110a572467b94ca06cefd5f7b46
2012-05-23 13:41:30 +02:00
Aaron Schulz
8667a6354d [FileRepo] Added support for temp file repos (to preserve our thumb.php hack).
* Added FileRepo::getTempRepo() to get a temporary repo similiar to the one used in wmf1.19 thumb.php.
* Merged and cleaned up wmf1.19 code into thumb.php to handle temp files and thumbnails.

Change 1: prevent FileRepo::getTempRepo() from being called on the result of FileRepo::getTempRepo().

Change 2: made FileRepo::getTempRepo() account for cases when the 'directory' param is not the empty string.

Change 3:
* Tweaked TempFileRepo to override getTempRepo() to enforce restriction.
* Added FileRepo::getTempHashPath() and used in thumb.php to get the correct path.

Change-Id: I2937b5ffb3ec9a7e2741b42bc28dc76833053fcd
2012-04-06 15:55:44 -07:00
Platonides
9951f9f9ae trunk/phase3 is now mediawiki/core
Change-Id: Ief2721ee6573a5e54a276c91de636d9e1a678b8b
2012-03-23 17:19:22 +01:00
Sam Reed
356799f95a Drag in a change noticed in wmf branches 2012-02-11 15:14:15 +00:00
Aaron Schulz
224dfaeb33 * Removed thumb.php comment about ProofreadPage, page numbers are more general.
* Added ExtractThumbParameters hook handlers for ogg and tiff handler extensions.
2012-02-10 20:52:57 +00:00
Aaron Schulz
30ed85146a r111076: url decode the 'rel404' path...*ahem*. Archived files and files with special chars are otherwise broken. 2012-02-10 01:35:13 +00:00
Aaron Schulz
5e91795785 (bug 34231) - 'Make thumb.php error or redirect for urls with bogus paths but valid file & thumb names.' 2012-02-09 19:45:12 +00:00
Aaron Schulz
8f0814e64c Similar to r108937: fixed breakage where the zone urls were defined as relative paths. 2012-01-20 20:52:09 +00:00
Aaron Schulz
cae80e3738 r105512: Handle REDIRECT_URL discrepancies and always work with URI paths for thumb 404 handling 2012-01-14 19:17:17 +00:00
Aaron Schulz
5a6559d8b1 Reverted r108743 per CR comment. This should at least be discussed first. 2012-01-12 19:41:18 +00:00
Sam Reed
a5c200a25b Kill "* @return void" 2012-01-12 19:12:24 +00:00
Aaron Schulz
c8a0908bdf FU r105512: urldecode() the file and thumb name in wfExtractThumbParams() for 404 handling as needed. 2011-12-22 00:43:11 +00:00
Aaron Schulz
5275f9b097 Merged FileBackend branch. Manually avoiding merging the many prop-only changes SVN likes to sprinkle in (easy to spot from the change list). Did not add SwiftFileBackend.php as it still is in development. 2011-12-20 03:52:06 +00:00
Robin Pepermans
be2de16942 update all core usage of deprecated Title::userCanRead() 2011-12-13 11:05:30 +00:00
Aaron Schulz
056651c3f0 FU r105512: just always use thumb.php style errors 2011-12-08 04:58:26 +00:00
Aaron Schulz
dcbe8e7dd3 FU r101117: removed cURL thumb handler code and made thumb_handler.php a thin wrapper around thumb.php
* Moved original URL fetching code and parameter extraction code to thumb.php
* Made use of local repo URL and hash settings to avoid extra config code
* This makes it easy to add hooks for extensions/config to alter behavoir (ExtractThumbParameters hook added)
* Added FileRepo::getHashLevels()
2011-12-08 03:43:07 +00:00
Aaron Schulz
3a6b5d6005 FU r100535:
* Thumb handler can now also work without cURL
* Combined related config vars into array config vars
* Folded $thgThumb404File into $thgThumbCallbacks
* Avoided some global pollution
2011-10-28 05:12:12 +00:00
Aaron Schulz
12b7bfe233 More whitespace tweaks...and fixed doc typo 2011-10-20 19:05:48 +00:00
Aaron Schulz
ed74ccc6da Minor code style cleanups and tweaks 2011-10-19 00:14:13 +00:00
Sam Reed
d90b987ade Fix whitespace, braces
Fix return items
2011-10-15 22:58:42 +00:00
Chad Horohoe
1a1e917c86 Move wfStreamFile() into a class, update all callers in core (only 3 extensions use it afaict), leave wfStreamFile() as a b/c alias for now.
Yay less global functions, autoloading and less manual require()s.
2011-08-13 19:03:51 +00:00
Tim Starling
ff1dc8a175 HipHop improvements:
* Added the ability to compile extensions. The build process is bootstrapped by running MediaWiki in interpreted mode. Extension setup file inclusions are slightly modified in a way that makes them register themselves for compilation. Then the same LocalSettings.php uses the compiled extension setup file when the compiled binary runs.
* Tested with Cite and ParserFunctions. The code which lets you have an extensions directory in a place other than $IP/../extensions is untested.
* Simplified WebStart.php slightly by using a custom $_SERVER variable to mark compiled mode. It will break if you don't use the supplied server.conf, but that will break a lot of things so don't do that.
* Fixed the core web entry points to include WebStart.php in compiled mode instead of interpreted.
* Made the build directory configurable. This is mostly so that I can grep the source tree without seeing loads of generated C++.
* In server.conf, added a rewrite rule allowing a /wiki/$1 article path.
* Removed server.conf log file location "/dev/stdout", breaks when you switch user
* Disable static content cache, breaks horribly when you set SourceRoot to a directory containing 7GB of files.
* Rewrote the run-server script in PHP, mostly to support the configurable build directory feature.
* Added an option to the run-server script to allow running in interpreted (hphpi) mode.
2011-05-30 13:49:09 +00:00
Russ Nelson
e259adbb50 Fix and add some comments. 2011-05-02 18:48:35 +00:00
Platonides
49074e8a56 Yet more additions of wfProfileOut() 2011-02-10 16:39:53 +00:00
Alexandre Emsenhuber
6af90c193f Removed error suppression operators (per bug 24159) 2010-07-18 13:16:18 +00:00
Tim Starling
2e3023a464 Fix data leakage from thumb.php for wikis where access to images is restricted (e.g. using img_auth.php). For backport to 1.15. 2010-03-08 22:39:14 +00:00
Brion Vibber
6c7b3f0ab6 Provisional revert of r56916 "(bug 20802) Fixed thumb.php redirect handling. Changed wfLocalFile call into RepoGroup::singleton()->getLocalRepo()->findFile"
This appears to make thumb.php more permissive than it's indended and could lead to littering false-positive thumbnails around the server when used to implement 404 handlers as designed.
2009-09-30 19:00:48 +00:00
Bryan Tong Minh
c184ebec19 (bug 20802) Fixed thumb.php redirect handling. Changed wfLocalFile call into RepoGroup::singleton()->getLocalRepo()->findFile 2009-09-25 14:23:09 +00:00
Ilmari Karonen
34fb6297cd Step 2 in NS_IMAGE -> NS_FILE transition (bug 44) (WARNING: huge commit).
This is a global search and replace of NS_IMAGE and NS_IMAGE_TALK with NS_FILE and NS_FILE_TALK respectively in all core files, excluding those already updated in step 1 (r44004).
2008-12-01 17:14:30 +00:00
Aaron Schulz
9f8228e659 revert bogus change 2008-08-13 02:09:10 +00:00
Aaron Schulz
c64c3961cd use $sourcePath here too 2008-08-13 02:05:24 +00:00
Aaron Schulz
e983e01e2c use getArchivePath() 2008-08-13 02:02:36 +00:00
Aaron Schulz
2ba5650095 use makeTitleSafe() 2008-08-13 01:24:03 +00:00
Aaron Schulz
c7b992acd3 we need a $title here 2008-08-13 01:11:45 +00:00
Aaron Schulz
a52e560d2c check 'archived' param 2008-08-13 01:01:58 +00:00