Commit graph

15 commits

Author SHA1 Message Date
jenkins-bot
7110e89e54 Merge "Hard deprecate MWNamespace::canTalk()" 2019-03-06 15:11:07 +00:00
Aaron Schulz
a26eee40e0 Avoid use of deprecated ObjectCache::getMainWANInstance method
Change-Id: I429e68c8642a00afa812f5ae900c1fb4f8308528
2019-03-01 02:38:55 +00:00
Max Semenik
ab4feff3ca Hard deprecate MWNamespace::canTalk()
Deprecated in 1.30, it had 1 usage outside of tests, removing it in
this patch.

Change-Id: Ia88b004ac3a5d6f47ece1132f80f713d54a04654
2019-02-26 21:28:55 -08:00
Aaron Schulz
c8d82c02c3 Use WANObjectCache::makeKey() in ChangesFeed
Change-Id: Ia029873e5d0883d177007555ad494cae9e00c407
2017-11-27 12:03:47 -08:00
Umherirrender
a9007e8baf Add missing & to @param documentation to match functon call
Change-Id: I81e68310abcbc59964b22e0e74842d509f6b1fb9
2017-08-11 18:47:46 +02:00
Thiemo Mättig
91a920fd85 Remove auto-generated "Constructor" documentation on constructors
Having such comments is worse than not having them. They add zero
information. But you must read the text to understand there is
nothing you don't already know from the class and the method name.

This is similar to I994d11e. Even more trivial, because this here is
about comments that don't say anything but "constructor".

Change-Id: I474dcdb5997bea3aafd11c0760ee072dfaff124c
2017-07-21 12:19:30 +02:00
Aaron Schulz
e01fd44388 Move ResultWrapper subclasses to Rdbms
Change-Id: I6f3f0e85e268b24c57c537aa6ad8016e0b4cdddb
2017-03-03 00:44:41 +00:00
James D. Forrester
9635dda73a includes: Replace implicit Bugzilla bug numbers with Phab ones
It's unreasonable to expect newbies to know that "bug 12345" means "Task T14345"
except where it doesn't, so let's just standardise on the real numbers.

Change-Id: I6f59febaf8fc96e80f8cfc11f4356283f461142a
2017-02-21 18:13:24 +00:00
Aaron Schulz
5bbac35ed1 Replace DatabaseBase:: with Database:: and update type hints
Change-Id: I3919b04eb2de4fa0bf8a02239fb5bbf17d347511
2016-09-27 04:20:03 +00:00
Kunal Mehta
6e9b4f0e9c Convert all array() syntax to []
Per wikitech-l consensus:
 https://lists.wikimedia.org/pipermail/wikitech-l/2016-February/084821.html

Notes:
* Disabled CallTimePassByReference due to false positives (T127163)

Change-Id: I2c8ce713ce6600a0bb7bf67537c87044c7a45c4b
2016-02-17 01:33:00 -08:00
Aaron Schulz
3517be1cf0 Migrate feeds from $messageMemc to the WAN cache
This makes the delete() calls work properly for all DCs.
Also, using the message cache was fairly bizzare.

Change-Id: Idec7fa47811e982ba89bb8fbbd9565a26585e77f
2015-11-10 11:11:05 -08:00
aude
9b11ff7a42 Omit 'external' changes from ChangesFeed
The current formatting does not display these
external changes very well (e.g. doesn't distinguish
between local and foreign wiki user or whatnot).

Unless there is better handling or integration of these,
also with the option of hiding or showing, it is best
to simply exclude these from the feed.

This brings the ChangesFeed inline with default
behavior of Special:RecentChanges and Watchlist.

Bug: T88254
Change-Id: I956a3c392e9f163478b9f6994bde4c0be8932163
2015-02-02 20:32:07 +00:00
Chad Horohoe
aa21e125a3 Remove obvious function-level profiling
Xhprof generates this data now. Custom profiling of various
sub-function units are kept.

Calls to profiler represented about 3% of page execution
time on Special:BlankPage (1.5% in/out); after this change
it's down to about 0.98% of page execution time.

Change-Id: Id9a1dc9d8f80bbd52e42226b724a1e1213d07af7
2015-01-07 11:14:24 -08:00
umherirrender
7c6a25856c Add missing @return to function docs
Change-Id: I45b9d02f94ecc58372268ec5e6a0b572a0b7e2a9
2014-08-23 23:14:57 +02:00
withoutaname
2be66e38e2 Move ChangesFeed to includes/changes/ folder
Change-Id: I4ec541e8fe4234970972904592af2e11375e974d
2014-07-15 17:30:46 -07:00
Renamed from includes/ChangesFeed.php (Browse further)