Sam Reed
85af1b0901
Revert r71250 r71251 r71252 r71253
...
Know what the problem is, roughly, can't fix atm, so not leaving phase3 broken
2010-08-18 14:15:32 +00:00
Sam Reed
9ea1f1d388
Kill some crappy "failFunction" stuff, marked as old in r14625
2010-08-18 13:38:42 +00:00
Sam Reed
4ea2cfe811
Followup r71241
...
Another $bitField to $field
2010-08-18 10:09:03 +00:00
Chad Horohoe
4c74490bb8
Big commit: kill almost every freeResult() call as useless
2010-08-08 12:27:48 +00:00
Alexandre Emsenhuber
c13687bdb6
Standardisation of file headers
2010-08-01 21:13:44 +00:00
Sam Reed
5fd23ed8b5
More unused globals
2010-07-25 17:47:41 +00:00
Sam Reed
04f68827d0
Removal of unused globals
...
Removal of one setting of a variable to '', then not using further
2010-07-24 19:11:52 +00:00
Tim Starling
42017a2f47
Use $wgContLang not $wgLang for checkTitleEncoding() and getSpecialPageAliases(), it doesn't make sense to use the user language, WebRequest and SpecialPage certainly don't. The DatabaseOracle use of checkTitleEncoding() is weird and probably broken, but at least it uses the right object now.
2010-07-22 04:00:39 +00:00
Max Semenik
775adbf329
Got rid of remaining usages of immediateBegin()/immediateCommit(), marked these functions with wfDeprecated()
2010-07-05 19:47:46 +00:00
Alexandre Emsenhuber
a643b87295
Fixed some doxygen warnings
2010-07-04 14:41:26 +00:00
Max Semenik
75d41fe3b6
Refactored Database*::getLag(): moved the default implementation to MySQL, replaced it with a proper dummy, deleted stub implementations from other classes. This adds fake lag support to all databases.
2010-07-02 13:17:28 +00:00
Max Semenik
67ebe72ade
* Replaced the mess of every database class implementing filedExists() is its own way with one simple function in base class. Verified to work on MySQL, Postgres and SQLite.
...
* Fixed fieldInfo() on Postgres not using tableName() and thus failing for table user, for example.
* Made fieldInfo() on MySQL return false instead of throwing a query error if table does not exist. This is consistent with other databases' behaviour.
2010-07-02 10:01:09 +00:00
Chad Horohoe
44229b50e6
Fixed a bunch of silly instances of [^!=]==\s*(true|false)
2010-06-09 11:44:05 +00:00
Jure Kajzer
9b653aa0d5
* Fixed parserTests compatibility for Oracle
...
* Fixed DBPrefix not being set in the old installer
2010-06-08 18:14:28 +00:00
Jure Kajzer
2c803d58be
* reportQueryError must break execution on parse and execute
2010-05-03 14:16:46 +00:00
Platonides
62a615c6c0
Actually check sourceFile for failure, showing the error message in the install.
...
See report on http://permalink.gmane.org/gmane.org.wikimedia.mediawiki/33902
Fixed several tag nesting problems from setup_database().
Make sourceFile() always use text errors in the installer. It can't handle
exceptions properly (introduced in r36211). But they are appropiate for update.php
thus the ugly branches.
The installer now always handles sourceFile() errors.
2010-04-29 21:49:58 +00:00
Jure Kajzer
d43a5844dd
oracle: missing table prefix
2010-03-02 16:58:21 +00:00
Jure Kajzer
29544758f1
tableName calls moved inside fieldInfoMulti and removed call that existed only for this call
2010-02-23 10:38:06 +00:00
Alexandre Emsenhuber
a3d4855413
Fix for r62744: use tabs for indentation, not spaces
2010-02-20 19:22:27 +00:00
Jure Kajzer
ec7782fe97
tableName has to be encoded before field type checking
2010-02-20 18:27:00 +00:00
Jure Kajzer
8fcb7e42a1
Fixed as per Tim's comments on r61179:
...
* made insertOneRow and getSequenceData private
* renamed fieldInfo to fieldInfoMulti and made it private (for internal use on Oracle only)
* wrapped fieldInfoMulti in fieldInfo with error if $table parameter is an array
* reverted tableName function to only support a non-array parameter
* wrapped all tableName calls with array parameter with array_map with callback
* wrapped fieldInfo into textFieldSize function to avoid reimplementation of functionality
* fixed unnessesary multiple calls to tableName with same parameter inside a single procedure
2010-01-28 14:58:45 +00:00
Jure Kajzer
3707fcc2f8
Fixed as per Tim's comments on r60665:
...
* fieldExists reduced to bool-cast output of fieldInfo
* added negative cache (handled acordingly on fieldInfo usage)
* uppercased parameters on entry. DB data is uppercased by default
2010-01-20 16:19:08 +00:00
Jure Kajzer
0e361f492b
Fixed error suppressing suggested in r58559 by Tim. Also fixed some warnings and bugs in Oracle abstraction.
2010-01-17 20:42:54 +00:00
Tim Starling
9a420fa847
Remove code commented out by r58597
2010-01-11 00:55:21 +00:00
Aryeh Gregor
70f749ba75
Use string interpolation, not .
...
Prompted by r60731, although that didn't actually add the concatenation
(which should have had more spaces, too).
2010-01-10 23:24:47 +00:00
Jure Kajzer
f488d7de97
Prevented delete call in replace function if conditions empty. Removed some old commented code.
2010-01-08 07:23:43 +00:00
Tim Starling
fd3794c5bc
For r60757: implement Database::getType() explicitly in each subclass, to make Roan happy.
2010-01-08 00:31:24 +00:00
Sam Reed
b6e0df246f
Attempt at normalistion of comparison styles - empty string on left and right hand side normalised to it being on the rhs
...
Before this change, there were (? being regex 0 or 1)
"" ===? 1
'' ===? 24
"" !==? 8
'' !==? 32
== "" 14
== '' 344
!= "" 9
!== "" 4
!= '' 151
!== '' 85
Rhs was the much more common, and the preferred style by many developers.. (Was a similar discussion in #mediawiki recently.. After that lolbugreport i think)
Where there is a string (non empty) on the lhs, and variable/method call on the rhs still need normalising
2010-01-06 19:59:42 +00:00
Jure Kajzer
7fc32afd48
Fixed variable name typo from r60665. (problems while sending file in previous attempt r60730)
2010-01-06 14:00:17 +00:00
Jure Kajzer
12e9352062
Fixed variable name typo from r60665.
2010-01-06 13:52:58 +00:00
Jure Kajzer
98aedd07b3
fixme for r58356
2010-01-05 13:35:19 +00:00
Jack Phoenix
7a1448b4f0
more coding style cleanup to DatabaseOracle.php
2009-12-11 18:23:24 +00:00
Jure Kajzer
1600e22d14
Fixed missing table in ora/tables.sql. Replaced instantiation of DBUndexpecedError with DBQueryError in reportQueryError function
2009-12-11 16:47:06 +00:00
Aryeh Gregor
d5c5375ec4
stylize.php on DatabaseOracle.php
...
Please follow <http://www.mediawiki.org/wiki/Manual:Coding_conventions >
so that code is easier to read. (For anyone whose blames are getting
messed up by whitespace changes, use svn blame -x -w, or git blame -w,
to ignore them.)
2009-12-10 23:22:34 +00:00
Jure Kajzer
f46754821a
Fixed wrong field definition for filearchive. Fixed delete function to handle encoding checking of array values in condition.
2009-11-27 13:44:57 +00:00
Jure Kajzer
287ec29135
replaced charset definition to php var instead of forced env var
2009-11-17 09:41:26 +00:00
Jure Kajzer
17821ff2f1
Fixed parserTests to work with Oracle (added Anonymous user 0 to fix FK violations). Fixed a few bugs identified by parserTests fails.
2009-11-09 14:34:03 +00:00
Jure Kajzer
fd63c9c9d8
Started working on parserTests Oracle compatibility, still getting FK violations
2009-11-06 17:12:18 +00:00
Jure Kajzer
fa2fc4823a
added encoding handlin on delete() and selectRow(), switched manual delete in replace() with a function call
2009-11-05 20:04:47 +00:00
Jure Kajzer
e773c0d23e
removed x-codeBlob functions and modified blob handling acordingly
2009-11-05 18:49:12 +00:00
Jure Kajzer
bf16a1ccff
Fixed replace function behaviour when required ID not specified
2009-11-04 19:27:22 +00:00
Jure Kajzer
782a3d4d37
Fixed some Oracle-specific installer and Strict Standards issues
2009-11-04 19:09:11 +00:00
Jure Kajzer
0f664ab6c7
DatabaseOracle removed makeList overload and added delete overload for CLOB handling in delete parameters.
2009-11-03 14:32:34 +00:00
Jure Kajzer
ebb1391939
overloaded makeList in DatabaseOracle to handle CLOBs in WHERE clauses
2009-10-30 09:44:37 +00:00
Jure Kajzer
446fd503d0
* Replaced LIMIT with limitResult call in rebuildrecentchanges.php
...
* Added a wrapper-function for sequence number generation and modified insertSelect in DatabaseOracle to fill missing ID-field references
2009-10-28 19:15:19 +00:00
Jure Kajzer
785ad24aa7
Changed sequence names to a standard <table>_<field>_seq form.
...
Updated all nextSequenceValue calls with new sequence names.
OverlordQ stated he'll handle changes to Postgres scripts.
Need someone to change DB2 scripts.
2009-10-28 16:17:16 +00:00
Alex Z
374b9e4af1
Mostly revert r53358 and r53365 per comments on code review. Change message to just say "Database" and remove the getDBtypeForMsg function (since I can't think of any other use for it)
2009-08-22 20:17:28 +00:00
Chad Horohoe
df296de32e
* Move generic return true; various for lock functions to parent, no need to implement this everywhere
...
* Make LOW PRIORITY optional
* Use sourceFile instead of dbsource
2009-07-29 23:41:16 +00:00
Alex Z
bc1b8182e9
Followup to r53358 - Tweak the function name to be a little clearer as to what it does
...
Also make it abstract in DatabaseBase so all subclasses have to implement some human readable name
(also make getSoftwareLink abstract for the same reason) Every current Database class already implements both.
2009-07-16 16:49:09 +00:00
Alex Z
3742d1058d
(bug 19590) Database error messages are no longer hardcoded to use "MySQL".
...
Added a new function DatabaseBase::getDBtype() to get the DB type for messages, updated all subclasses.
Message change needs propagating.
2009-07-16 15:18:57 +00:00
