Commit graph

6 commits

Author SHA1 Message Date
Kunal Mehta
6e9b4f0e9c Convert all array() syntax to []
Per wikitech-l consensus:
 https://lists.wikimedia.org/pipermail/wikitech-l/2016-February/084821.html

Notes:
* Disabled CallTimePassByReference due to false positives (T127163)

Change-Id: I2c8ce713ce6600a0bb7bf67537c87044c7a45c4b
2016-02-17 01:33:00 -08:00
Florianschmidtwelzow
1c0e593bc2 UserLogin: Allow extensions to add valid error messages
Add hook LoginFormValidErrorMessages to allow extensions, to add own valid
error messages to redirect to the login form.

Bug: 71769
Change-Id: I9e996a88e3972f09946726060916a21124de049c
2014-11-03 21:28:18 +01:00
Tyler Romeo
d0439af89f Make UserNotLoggedIn redirect to login page
For pages like Special:Watchlist that throw
a UserNotLoggedIn exception when the user is
anonymous, this patch makes the page redirect
to the login page automatically.

This is instead
of the current behavior of showing a link to
the login page that the user must click.

(Also, Special:Userlogin has existing functionality
that will redirect the user back once they are
logged in.)

Bug: 15484
Change-Id: Idd9325374cb5dc13c4c057f45f88a33bdff523a9
2014-08-07 13:38:16 -04:00
Bartosz Dziewoński
57fd33ff74 Revert "Make UserNotLoggedIn redirect to login page"
Lots of small issues that could be very annoying:

* Usability regression: the user is not informed *why* they were
  redirected to the login screen. Not even a generic "You must log in
  to complete this action".
* When testing this on my watchlist, after logging in I am now redirected
  to http://localhost/wiki/index.php?title=Watchlist&title=Special%3AWatchlist
  (the title is repeated twice and one of them is incorrect). This
  worked correctly before.
* SpecialPage::requireLogin() needs documentation and code updates.
* A whole ton of messages used in these prompts is now unused.
* Probably needs release notes.

I don't have the time to fix up myself right now, and a WMF
branch cut is looming. Let's just try this again later.

This reverts commit e0af129cbd.

Bug: 15484
Change-Id: I728e477cf6e10b90846ee0b2d9e5087bc3a0af3e
2014-07-15 23:13:17 +00:00
Tyler Romeo
e0af129cbd
Make UserNotLoggedIn redirect to login page
For pages like Special:Watchlist that throw
a UserNotLoggedIn exception when the user is
anonymous, this patch makes the page redirect
to the login page automatically.

This is instead
of the current behavior of showing a link to
the login page that the user must click.

(Also, Special:Userlogin has existing functionality
that will redirect the user back once they are
logged in.)

Bug: 15484
Change-Id: Ic7e1d5a8984e1b42c8f2ebceff094106a3ed1efa
2014-07-15 14:48:09 -04:00
addshore
557af13086 Split Exception.php
Change-Id: I8273b342f8814887b65227457d0a461d7cd31e75
2014-02-24 21:17:59 +01:00