I searched for /\$(\S+) = (.+?\(.*?\);)\n.*?\$\1\[/, ignored
everything involving isset(), unset() or array assigments, then
skimmed through the remaining results and changed things where they
made sense. These changes were not automated, so please review them.
Change-Id: Ib37b4c66fc57648470f151ad412210b3629c2538
This can happen in sub-second cases with skew. It makes
graphana tend to see -1 as the min for some time values.
Change-Id: I4e39d8ac29f515fd76548f1a7b64d71a03064407
* Use the regular limit-X style response instead of throwing an
exception. This avoids loss of statd data and the like.
Change-Id: Ia08384a0d13c268f6e7a673b2265ab77772e5539
* Since JobQueue metrics are qualified with 'jobqueue.', don't add a 'job-'
prefix to each metric.
* Separate the key from the job type with a dot rather than a dash.
* To avoid having a Graphite node that is both a "directory" and a metric, use
'.all' as a suffix for aggregates.
Change-Id: I2ac604d3c042dbfb0b3a27759800f435ec22041e
* Made the pickup stats name be similar to other queue stats
* Renamed $jobsRun => $jobPopped
* Simplified some code and comments
Change-Id: I8ab1a68f04fc3ab4c0ba7f6f0b428a5a811a97fb
If you don't commit the slave connections then they keep their old snapshots.
This clears the snapshots so they don't get out of date views of the world.
Bug: T100838
Change-Id: I1f6f910d88324beb589b2ad9466d8786376eda55
Mark debug log events describing the start of processing a job as debug
level information rather than informative.
Bug: T87521
Change-Id: I1ce3dabf4a344369fe396c5bb056ed5ed6308c87
* Moved all these hacks to JobQueueDB, which is the only queue that
should need this (for stock installs). Newer queues should always
have the queue store manage stuff like this, not MediaWiki.
* This also avoids expensive object construction that does nothing
when non-DB queues are used.
Change-Id: Id718cda25750be73044a049b39958cca55aa3172
Move the MWLogger PSR-3 logging related classes into the
MediaWiki\Logger namespace. Create shim classes to ease migration of
existing MWLoggerFactory usage to the namespaced classes.
Bug: T93406
Change-Id: I359cc81fbd2dcf8937742311dcc7d3dee08747b0
Xhprof generates this data now. Custom profiling of various
sub-function units are kept.
Calls to profiler represented about 3% of page execution
time on Special:BlankPage (1.5% in/out); after this change
it's down to about 0.98% of page execution time.
Change-Id: Id9a1dc9d8f80bbd52e42226b724a1e1213d07af7
* This method now benefits from more cache sharing and de-duplicated
lag time querying to reduce connection stampedes.
Change-Id: I2f3b9a22e4adabea703fbae1f96e65fb65125e2b
* Do not block forever, but wait up to 10 seconds. Likewise,
check the lag times in memcached on startup. This at least
lets runners avoid lagged wikis but still work on others.
* Made a few small related documentation and code cleanups.
Change-Id: Ic1339bab54cba6b6cbea7d97a80ff87c7c5c87af
