9 commits

Author	SHA1	Message	Date
Max Semenik	48a323f702	tests: Add explicit return type void to setUp() and tearDown() ... Bug: T192167 Depends-On: I581e54278ac5da3f4e399e33f2c7ad468bae6b43 Change-Id: I3a21fb55db76bac51afdd399cf40ed0760e4f343	2019-10-30 14:31:22 -07:00
Daimona Eaytoy	ef5ab69629	Replace setExpectedException with two args ... Find: ^(\t*)(\$this->)setExpectedException\(\s+(\\?[a-z\\]+::class),\s+('(?:[^'\\]|\\')+'|"(?:[^"\\]|\\")+")\s+\); Replace: $1$2expectException( $3 );\n$1\$this->expectExceptionMessage( $4 ); +broke long lines manually. Bug: T192167 Change-Id: I5557b4372625def55a53ac637c2f980f51f12933	2019-10-05 16:14:05 +00:00
Thiemo Kreuz	32a429e8c4	tests: Prefer assertSame() when comparing the integer 0 ... assertSame() is guaranteed to not do any type conversion. This can be critical when acciden tially comparing, for example, 0 to 0.0. Change-Id: Iffcc9bda69573623ba14af655dcd697d0fcce525	2019-09-19 15:35:23 +00:00
Derick Alangi	ff320d9e49	objectcache: Hard deprecate ObjectCache::getMainWANInstance() ... This method was soft-deprecated in 1.28 and this patch cleans up usage (via object cache) in core and uses services. So, this is now fit for hard deprecation. Usage ===== https://codesearch.wmflabs.org/search/?q=getMainWANInstance&i=nope&files=&repos= Change-Id: I081a979ed6ed7acf37168a6d81ca4048aae5dd9c	2019-07-09 09:29:57 +00:00
Aryeh Gregor	ed40e8ec53	Get rid of ApiTestCase::doLogin ... The function is entirely unnecessary. Change-Id: I805520e5355119e872e602d0bfc93be26f227128	2018-04-11 20:17:52 +03:00
Brad Jorsch	4e6810e4a2	API: i18n for warnings and errors ... API warnings and error messages are currently hard-coded English strings. This patch changes that. With a few exceptions, this patch should be compatible with non-updated extensions: * The change to ApiBase::$messageMap will blow up anything trying to mess with it. * The changes to the 'ApiCheckCanExecute' hook will cause a wrong (probably unparsed) error message to be emitted for extensions not already using an ApiMessage. Unless they're currently broken like Wikibase. Bug: T37074 Bug: T47843 Depends-On: Ia2b66b57cd4eaddc30b3ffdd7b97d6ca3e02d898 Depends-On: I2e1bb975bb0045476c03ebe6cdec00259bae22ec Depends-On: I53987bf87c48f6c00deec17a8e957d24fcc3eaa6 Depends-On: Ibf93a459eb62d30f7c70d20e91ec9faeb80d10ed Depends-On: I3cf889811f44a15935e454dd42f081164d4a098c Depends-On: Ieae527de86735ddcba34724730e8730fb277b99b Depends-On: I535344c29d51521147c2a26c341dae38cec3e931 Change-Id: Iae0e2ce3bd42dd4776a9779664086119ac188412	2016-12-06 10:20:48 -05:00
Aaron Schulz	b8bc83c91d	Fix "Incorrect watchlist token provided" unit test errors ... Change-Id: Ib133ffe9b9ef438ff5716ad25a897e2c5a4f7d58	2016-09-27 21:18:34 -07:00
Leszek Manicki	c1b4b19de3	Refactor database-related code in ApiQueryWatchlistRaw ... Database queries used to get user's watchlist items in API are quite complex due to number of options oferred by the API. Generating the query is moved to WatchedItemQueryService. ApiQueryWatchlistRaw no longer contains database-related code. Simple user watchlist item lookups should use WatchedItemStore. ApiQueryWatchlistRaw tests have been introduced in I9c07aa237607143985f0efe20ed0065d2bde27e4 Bug: T132566 Change-Id: I875a92074b52c00ac11db1fa05615abbf5262ab1	2016-07-06 12:57:39 +00:00
Leszek Manicki	90f378c2bc	Add tests for ApiQueryWatchlistRaw ... This includes tests that originally were part of I875a92074b52c00ac11db1fa05615abbf5262ab1 Change-Id: I9c07aa237607143985f0efe20ed0065d2bde27e4	2016-06-20 15:26:05 +00:00