Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
129329 commits 1 branch 0 tags 744 MiB
Commit graph

5 commits

Author SHA1 Message Date
Dreamy Jazz
e7393b3cc7 Exclude boilerplate maintenance code from code coverage reports 
Why:
* Maintenance scripts in core have bolierplate code that is
  added before and after the class to allow directly running
  the maintenance script.
* Running the maintenance script directly has been deprecated
  since 1.40, so this boilerplate code is only to support a now
  deprecated method of running maintenance scripts.
* This code cannot also be marked as covered, due to PHPUnit
  not recognising code coverage for files.
* Therefore, it is best to ignore this boilerplate code in code
  coverage reports as it cannot be marked as covered and also
  is for deprecated code.

What:
* Wrap the boilerplate code (requiring Maintenance.php and then
  later defining the maintenance script class and running if the
  maintenance script was called directly) with @codeCoverageIgnore
  comments.
* Some files use a different boilerplate code, however, these
  should also be marked as ignored for coverage for the same
  reason that coverage is not properly reported for files.

Bug: T371167
Change-Id: I32f5c6362dfb354149a48ce9c28da9a7fc494f7c
 2024-08-27 13:22:29 +01:00
Alexander Vorwerk
0831905a45 Migrate some usages of Database::update() to UpdateQueryBuilder 
Bug: T353219
Change-Id: I98bf4c2e2c3023fba226ac10826e52a1108b8aea
 2024-01-17 15:24:45 +00:00
Bartosz Dziewoński
978d739bc6 Replace single-value $db->buildComparison() with $db->expr() 
Find:
->buildComparison\( ('..?'), \[(\s*)([^\],]+) => ([^\],]+)(\s*)\] \)

Replace with:
->expr($2$3, $1, $4$5)

Change-Id: I2cfc3070c2a08fc3888ad48a995f7d79198cc336
 2023-10-22 01:05:47 +02:00
Alexander Vorwerk
638b37a5d8 migrateRevisionCommentTemp: Improve select query 
The current select is actually quite bad and it gets slower over
time since it basically querys the whole table until it found
200 rows.

This already made this script getting somewhat slow on beta
cluster where the biggest wiki has 3 million rows in revision.

Bug: T299954
Change-Id: I7add43d8005ab54a566813d36cf4544911bda6a6
 2023-01-21 13:28:46 +00:00
Alexander Vorwerk
9c05e6da86 Add migrateRevisionCommentTemp maintenance script 
Introduce migrateRevisionCommentTemp which copies data from
revision_comment_temp to rev_comment_id. The code is similar to
migrateRevisionActorTemp.php.

Bug: T299954
Change-Id: I3140d7efb18d4dfda783831ecb1549262e4bdc32
 2023-01-18 20:05:05 +00:00