Commit graph

8223 commits

Author SHA1 Message Date
James D. Forrester
9cf6be92d8 Update OOUI to v0.40.3
Release notes:
 https://gerrit.wikimedia.org/g/oojs/ui/+/v0.40.3/History.md

Bug: T245824
Bug: T249167
Bug: T258337
Bug: T258428
Bug: T259551
Bug: T259906
Bug: T259912
Bug: T260519
Bug: T261314
Change-Id: I16b1b650eb87699a5a88bdbd9b7568a8654e1e3c
Depends-On: I8e133892dbb239b2aeb152a762c8bf301c8fe7b9
2020-09-09 11:54:55 +00:00
jenkins-bot
ecc070119a Merge "build: Update eslint-config-wikimedia to 0.17.0" 2020-09-06 11:05:49 +00:00
MusikAnimal
9af265eeea mediawiki.notification: Don't close notif when clicking <select> element
We include both select and .oo-ui-dropdownInputWidget, since there may
be situations where the latter receives the click event and not the
<select> element.

Bug: T261901
Bug: T261476
Change-Id: Iefcedcf52da21c47081d39bdec8bb6f60acaf590
2020-09-03 14:58:25 -04:00
jenkins-bot
2a026644d8 Merge "Watchlist: Fix updateWatchLink removing css class when action=watch" 2020-09-02 19:42:54 +00:00
jenkins-bot
e843e08b3f Merge "Remove unused 'mediawiki.page.startup' alias" 2020-09-01 10:51:14 +00:00
Thiemo Kreuz
933c6a55bc Add missing "api" configuration to UserInputWidget
The same config exists in all widgets that are based on the
TitleWidget:
* TitleInputWidget
* TitleSearchWidget
* TitlesMultiselectWidget

The UserInputWidget should behave the same, as it does something
very similar.

This is done for (but doesn't block) I15c3521.

Change-Id: Ifb1dd9d7bef79ff367cd2befddbbc216ca721d02
2020-09-01 09:28:21 +02:00
Timo Tijhof
0d6236608c Remove unused 'mediawiki.page.startup' alias
Follows-up Ic418c23a7400abba22fd0.

Bug: T260210
Depends-On: I250b38a836f28bfb440f19282a9677977f30c615
Change-Id: I2a9199ba2bd58085424f333dc0b34d0f808ff384
2020-08-31 23:56:25 +00:00
jenkins-bot
037ee978cb Merge "Remove unused mw.title.getDotExtension() method" 2020-08-30 20:10:53 +00:00
Thiemo Kreuz
ab2d9b5017 Remove unused mw.title.getDotExtension() method
Our amazing
https://codesearch.wmflabs.org/search/?q=getDotExtension&i=1
could only find a single user of this method, and that was even a
mistake, see I68426bf.

What code typically needs is:
* The full title.
* A file name without the extension.
* The extension only.

If code needs the extension with a dot, it's easier if that code either
calls getMain() or getMainText(), or prepends the dot itself.

This change helps reducing the complexity of the mw.Title module, which
is basically always loaded.

Depends-On: I68426bff662ceea8a3dd6dcae116f47f81195b4c
Change-Id: I9330eff5a73e2bccad74a78fa5b6a8897b12f666
2020-08-27 18:05:17 +01:00
Dayllan Maza
a2a5511ae9 Watchlist: Fix updateWatchLink removing css class when action=watch
updateWatchLink was removing mw-watchlist-temp class when watching
a page during the loading animation transforming what should be a half
star spining into an empty star

This patch also consolidates the logic of adding and removing
mw-watchlist-temp css class into WatchlistExpiryWidget

Bug: T259053
Bug: T260434
Change-Id: I1e11f0e129c53b405a2ffa8cd1e0793aec8eb126
2020-08-26 16:57:31 -04:00
jenkins-bot
2e232e2d67 Merge "eslint: Move mediawiki/valid-package-file-require disables inline" 2020-08-26 19:41:00 +00:00
jenkins-bot
0a8e93993c Merge "Properly combine input type directionality selectors" 2020-08-26 19:33:00 +00:00
James D. Forrester
64ba8d6ea5 eslint: Move mediawiki/valid-package-file-require disables inline
Change-Id: I5af1fcb5b77106671fbb684158027870211b8186
2020-08-26 19:54:52 +01:00
Huji
81b8bd5daa Properly combine input type directionality selectors
This fixes an issue with 773a497a33

Credit goes to Demian who came up with this solution in
https://phabricator.wikimedia.org/T260993#6403122

Bug: T260993
Change-Id: I7a6f3cfc0859e34d9f9e9b41df4f74efb06d42d9
2020-08-26 18:45:50 +00:00
Ed Sanders
64bc98a56c Input length limit: Remove uses of wgCommentByteLimit
This config value is deprecated and hard-coded to null.

Use wgCommentCodePointLimit instead.

Change-Id: I876b02f45fcc62a79a72813397507b9ef519b501
2020-08-26 18:02:31 +01:00
Ed Sanders
4fc3f3af24 build: Update eslint-config-wikimedia to 0.17.0
Fix remaining instances of variable shadowing.

Change-Id: I2a3840446f1fe138410249cc35be5ddf262d8e46
2020-08-20 12:45:09 +01:00
jenkins-bot
b3be08f101 Merge "mediawiki.visibleTimeout: Update the nextVisibleTimeoutId value" 2020-08-20 08:54:51 +00:00
hmonroy
180a3806e6 mediawiki.visibleTimeout: Update the nextVisibleTimeoutId value
Set the nextVisibleTimeoutId value to 1 when it is initialized.
The nextVisibleTimeoutId is assigned to visibleTimeoutId in the set()
method and it should always be a positive integer.

Bug: T258662
Change-Id: Icd83ec2fb6f08c7b68524295cd8b8b47c3bc6d92
2020-08-19 13:55:36 -07:00
Sam Wilson
574fc1ae11 Hide watchlist expiry label in edit form
Add the possibility for fields in the 'checkboxes' area of the
edit form to set the OOUI invisibleLabel property. Also set
this property for the Watchlist Expiry field.

Update the vertical alignment of fields within the 'checkboxes'
area to ensure they all line up in the middle.

Bug: T260759
Change-Id: I60a9851c780ade275af746714ceb1ce702137037
2020-08-19 15:45:05 +08:00
jenkins-bot
40d6377d45 Merge "Remove mentions of mw.htmlform.Checker" 2020-08-18 07:01:48 +00:00
DannyS712
78b8a56114 Remove mentions of mw.htmlform.Checker
mw.htmlform.Checker was removed in 743edb1
and no longer exists

Change-Id: Id269f63fd3ca64a719745868d6df907548c15fad
2020-08-18 06:26:07 +00:00
jenkins-bot
5966599aa2 Merge "Guard against 'Widget not found' error" 2020-08-17 21:31:31 +00:00
jenkins-bot
08601c9cde Merge "mediawiki.page.ready: Simpler tablesorter/makeCollapsible call" 2020-08-17 20:58:27 +00:00
jenkins-bot
cbdefbef48 Merge "Update language in watchlist expiry" 2020-08-17 20:56:24 +00:00
jenkins-bot
26a1bcd01f Merge "mediawiki.page.startup: Merge with mediawiki.page.ready module" 2020-08-17 20:54:50 +00:00
hmonroy
0c2cc49bdc Update language in watchlist expiry
Update watchlist expiry language indicators (dropdowns, tooltips, watch
via star, watch via edit):
 * Change "Permanently" to "Permanent"
 * Change "XX days left" and "Expires in X days" to "XX days left in
   watchlist"
 * Update the "Click.." sentence by star to "Click to remove it."
 * Change watch period for a page that is less than "1 day left" to "A
   few hours left"

Bug: T253135
Bug: T255632
Change-Id: I114c6f77e86ad81b1810fedcd49f52c88700ca16
2020-08-14 11:47:03 -07:00
Timo Tijhof
274c4232b9 mediawiki.page.startup: Merge with mediawiki.page.ready module
The distinction between the two was lost several years years ago
when the "position top" queue ceased to be a thing. Since then,
the two have been loaded and executed together in the same batch,
and are doing similar things.

mediawiki.page.ready is publicly used in several places
as dependendency, but mediawiki.page.startup is entirely internal
to core, which makes it the easier one of the two to dissolve.

Keep an alias for two weeks for cache compat to avoid console
warnings about unknown modules. Although even some cache still
refers to it, this is harmless since the errors are recoverable
and the correct module was also loaded by the cached pages
already.

Bug: T260210
Change-Id: Ic418c23a7400abba22fd07b17f173d3c5f1d1d10
2020-08-14 01:35:15 +00:00
Timo Tijhof
7a1d641060 mediawiki.page.ready: Simpler tablesorter/makeCollapsible call
Follows-up a7952a8128 (I50aeafd57771).

If they need to run in a certain order, can we just do that?

Bug: T64878
Bug: T260210
Change-Id: I3c3f3b9fe87d97c7c156b8810f155a17242ce40d
2020-08-14 01:31:11 +00:00
jenkins-bot
02c533e837 Merge "Combine mediawiki.action.delete.js and mediawiki.action.delete.file.js" 2020-08-13 07:07:57 +00:00
Ammar Abdulhamid
81bd91cf77 Guard against 'Widget not found' error
Unlike other similar pages such as Special:MovePage, the reason field
and checkboxes are not always present here. Notably they will not exist
when navigating to Special:Undelete/existingpage or when the user has
permission to see/browse deleted revisions but no permission to undelete.

When the widget does not exist because of these server-side checks,
attempting the JS infusion will lead to a 'Widget not found' error.

Bug: T259916
Change-Id: I54be770f229cdacfae81d10fccd3cf2931df3a27
2020-08-12 14:35:42 +00:00
DannyS712
0727987928 resourceloader: update FNV doc url in startup module
https://en.wikipedia.org/wiki/FNV_hash_function was renamed,
update the url.

Change-Id: Ib06b8f939dc1b2456e2263c6649d032d0def0d44
2020-08-11 23:39:51 +00:00
Sam Wilson
8544cf1c2f Add full message names for some tooltip variants
For easier searching, add the matching tooltip-ca-* variants
of the watching messages.

Bug: T253135
Change-Id: I286372a608d79e34404a62a3a4487bdaf2e95017
2020-08-11 10:34:17 +08:00
Volker E
b52ffa511f Update OOUI to v0.40.1
Release notes:
 https://gerrit.wikimedia.org/g/oojs/ui/+/v0.40.1/History.md

Bug: T258420
Bug: T258488
Bug: T259193
Bug: T259354
Depends-On: I0396514739d8b41931ded30cc303c4b56a78f269
Change-Id: I7cea19584091a629084d79b1ee877c4f16e58eac
2020-08-07 06:37:48 -07:00
jenkins-bot
4afba34ab7 Merge "mediawiki.ui/icons: Remove unused .mixin-mw-ui-icon-bgimage() mixin" 2020-08-05 12:00:59 +00:00
Volker E
75ed374a0e mediawiki.ui/icons: Remove unused .mixin-mw-ui-icon-bgimage() mixin
There's no caller in icons.less itself nor in any extension/skin
we are aware of any more.

Change-Id: I2c2732a66b436e0dc6dcc33568760e331f3295d0
2020-08-04 17:13:48 -07:00
Volker E
c910b97f31 Replace deprecated .background-image-svg() mixin calls follow-up
Replacing with standard `background-image` properties, following-up
Ic5cf5575fdb3.

Bug: T248062
Change-Id: I984d787a229f372f502867c819461ccbdafdf59e
2020-08-04 17:09:34 -07:00
Jan Drewniak
a0a5f155ac Followup to 34c1661: mediawiki.page.ready: Allow skins to disable search lazy load
Re-adds a conditional checking for document.activeElement.

Bug: T250851
Change-Id: I8e16188ca721ba5f1cc1c8436d4b6fb55c91cbd9
2020-08-04 14:23:30 +02:00
jenkins-bot
f10ecca369 Merge "Account for non-existence namespaces in makeTitle" 2020-08-03 19:36:20 +00:00
jenkins-bot
b4360b8978 Merge "Add UI support in Special:EditWatchlist for watchlist expiry" 2020-08-03 05:59:41 +00:00
jenkins-bot
f4f853f63d Merge "Add watchlist clock icon to RecentChanges" 2020-08-01 20:23:50 +00:00
jenkins-bot
3db96d7a54 Merge "Translate expiry period in pop-up message for watchlist expiry" 2020-08-01 19:28:59 +00:00
jenkins-bot
b15dfec653 Merge "Edit page expiry dropdown should keep state after disabling/enabling" 2020-08-01 10:51:08 +00:00
hmonroy
e74c676836 Translate expiry period in pop-up message for watchlist expiry
Translate the selected watchlist expiry period in the watchlist pop-up success
message.

Bug: T259009
Change-Id: I4d2fb01cf7a15558100077d6cc8aac2fddd01246
2020-07-31 17:47:15 -07:00
Kunal Mehta
e9f4e775c8 resources: Add license information for promise-polyfill
Change-Id: I1730d44ffb88280a4297c2745a75b0e5ffcdaa41
2020-07-31 17:09:12 -07:00
jdlrobson
f3aa7a4cf1 Account for non-existence namespaces in makeTitle
Bug: T253047
Change-Id: Ie4a6dded3d254677801b64a6d6e278fcf0809687
2020-07-31 08:18:45 -07:00
Dayllan Maza
266e5ff4c3 Edit page expiry dropdown should keep state after disabling/enabling
* Expiry dropdown will not reset when `Watch this page` checkbox
  is changed.
* Dropdown stays in sync with selected values if user starts
  watching via the star.

Bug: T259060
Change-Id: I96da6bfd7856e8c4c6326377279eec4d32624df8
2020-07-31 10:39:16 -04:00
hmonroy
166a58e2be Add UI support in Special:EditWatchlist for watchlist expiry
Add text to indicate remaining days for temporarily watched items in
the Special:EditWatchlist page. Add ascending sorting by expiration
date. Display the items that will expire soonest at the top.

Bug: T250214
Change-Id: I9aba8cccc2ef75c59b78008723d0ae76d853c5f2
2020-07-30 17:44:13 -07:00
jenkins-bot
00911cf8da Merge "Update time period for watchlist expiry pop-up" 2020-07-30 23:43:38 +00:00
jenkins-bot
ce570f5237 Merge "Combine input type directionality selectors" 2020-07-30 22:22:52 +00:00
Volker E
773a497a33 Combine input type directionality selectors
Combining equal-value selectors for better readability.

Bug: T247033
Change-Id: I460047290abccad243af7debacf9b92959f8b7f9
2020-07-30 14:56:34 -07:00