Commit graph

13 commits

Author SHA1 Message Date
Platonides
f524482f2d Change the duplicateTableStructure() to use the original names.
It is now duplicateTableStructure() duty to addIdentifierQuotes() them.
Fixed bug for mysql < 4.1 where the new name would be quoted twice.

Always quote identifier in Oracle, doing otherwise seems a bug (can someone confirm?)
2011-04-12 18:54:51 +00:00
Antoine Musso
0d2baed222 correct wfDebug() calls added in r79272 & r79368 2011-03-20 11:39:44 +00:00
X!
1b7bfdee49 I made MySQL work, and broke SQLite in the process. I fix SQLite, and made MySQL break. Fixing MySQL again, hoping that SQLite works too. :) 2010-12-31 21:01:17 +00:00
X!
dd68f3947a More work on getting SQLite to work with unit tests. DB Prefix changing is now static to allow for external classes to change it. 2010-12-31 20:42:39 +00:00
Platonides
666ee2902a Follow up r79314.
The table to drop is the NEW one, the one that is going to be recreated.
Sure, the prefix was changed, which means that we need just the table base.

The r79314 behavior was to perform the following:
 DROP /* CloneDatabase::cloneTableStructure  */ TABLE IF EXISTS `archive`
 CREATE /* DatabaseMysql::duplicateTableStructure  */ TEMPORARY  TABLE `unittest_archive` (LIKE `archive`)

Luckily, it failed there as it didn't find the table it had just dropped.
2010-12-31 14:08:10 +00:00
X!
f70c2b987c Use $oldTableName in CloneDatabase. The dropTable() appends the prefix, so $oldTableName becomes $newTableName 2010-12-31 02:18:25 +00:00
X!
1993c83277 -Destroy the DB automatically when initting the DB
-Add $force option to wfSetVar
-More work on getting SQLite to work
2010-12-30 17:30:35 +00:00
Sam Reed
490367210b Add function return type hint to wfGetLBFactory
More parameter documentation to CloneDatabase
2010-12-30 02:44:26 +00:00
Sam Reed
43ca0f0974 Array to array
Add some function documentation
2010-12-30 02:41:20 +00:00
OverlordQ
91307ea896 Followup to r79094, PG handles temporary tables correctly so you dont need to do cleanup 2010-12-28 22:26:45 +00:00
Chad Horohoe
f636dd473a Fix hardcoded debugging from r79093 2010-12-28 22:20:01 +00:00
Chad Horohoe
3a9a451e8c Followup r79093: Move DROP TABLE code to Database classes and properly rename back to original table prefix in destroyDatabase() 2010-12-28 01:19:16 +00:00
Chad Horohoe
4a5e562591 Refactor table cloning code into its own class so it can maybe be used by things other than the parser tests 2010-12-28 00:44:16 +00:00