Commit graph

27 commits

Author SHA1 Message Date
Derk-Jan Hartman
4a82a518a6 Followup r80772
I'm not bored enough to actually port these IE styles into the main Chick stylesheet. So better to re-enable them until someone else is bored enough to try.
2011-03-26 13:20:41 +00:00
Derk-Jan Hartman
fee2a5a3ea Port Chick to Resourceloader. Bug 26649 2011-01-22 21:29:39 +00:00
Aryeh Gregor
28c36f9e01 Restore IE5/5.5 support to MonoBook and Chick
This reverts r61083 and r61085, per my Code Review comments at r61083.
IE5 and 5.5 work okay right now in MonoBook, and there's not really any
benefit to removing support where it already exists.

I'll backport this to 1.16 and revert r61128 there too shortly.
2010-02-23 17:46:18 +00:00
Aryeh Gregor
86ddf7cb8a Revert accidental commit 2010-02-21 01:45:53 +00:00
Aryeh Gregor
55e8dfc70e Revert "Kill off IE50Fixes. Adds extra clutter to the head, and market share is down below 0.03% (http://is.gd/6jyWo)."
This reverts commit d7b597d6720762330b11538b4b19554bfb6d11a1.
2010-02-21 01:43:42 +00:00
Chad Horohoe
d76187944d And IE 5.5 too, while we're at it. 2010-01-15 14:37:19 +00:00
Chad Horohoe
3d1137ebdf Kill off IE50Fixes. Adds extra clutter to the head, and market share is down below 0.03% (http://is.gd/6jyWo). 2010-01-15 14:26:52 +00:00
Alexandre Emsenhuber
0b5389d98d * (bug 20631) Preview of personal JavaScript and CSS pages now works again
* introduced SkinTemplate::$useHeadElement as switch for backward compatibility for extension skins using the old way of generating the <head> element:
** false (default): no change from previous version
** true: <head> specific items set in SkinTemplate::outputPage() are no longer generated (avoid double execution of some functions) and the result of OutputPage::headElement() is stored in the 'headelement' item
* updated all core skin to use this new method, some extensions using MonoBookTemplate but not extending SkinMonoBook (or for other core skins) will need to set $useHeadElement to true to work properly though
* Made Skin::userCanPreview() public since it's needed in OutputPage::getHeadScripts()
* Pass the Skin object from OutputPage::headElement() to OutputPage::getHeadScripts() rather than getting it from $wgUser
2009-09-22 16:52:40 +00:00
Andrew Garrett
e8aa289e48 Fix prefsectiontip styles (class renamed to htmlform-tip) 2009-04-24 08:47:56 +00:00
Chad Horohoe
a8566e483c Use parent instead of SkinTemplate explicitly 2009-04-07 18:12:48 +00:00
Jack Phoenix
593c5c427e further cleanup to skins. instead of referring the user to docs/skin.txt, why not to include the skin descriptions on the actual files? :) 2009-03-29 15:29:34 +00:00
Alexandre Emsenhuber
177b1e264a Tweaks for skins:
* Moved SkinTemplate::addStyle() and related stuff to OutputPage so that it can be used non-SkinTemplate skins and avoid duplication with the actual OutputPage::addStyle() (the two functions have the same format).
* Non-SkinTemplate skins now also load their CSS with <link> tags instead of @import.
* Moved SkinTemplate::setupUserCss() to Skin.
* Merged action=raw&gen=(js|css) for SkinTemplate and non-SkinTemplate skins, renamed functions to Skin::generateUserJs() and Skin::generateUserStyleSheet() and dropped a lot of cascading call which is a bit incomprehensible.
2008-08-21 14:09:57 +00:00
Brion Vibber
dc821ec18d Start on some cleanup of how CSS stylesheets are loaded. Initially addressing only the SkinTemplate-based skins; would like to rip out some near-dupe code in the other skin types, with a little more refactoring...
* A skin can make calls to $this->addScript to much more cleanly list which style sheets it wants to load, for which media variants and which IE conditional versions. This replaces the 'cssfiles' array hack and giant pile of ugly conditionals in MonoBook's template.

* 'printable=yes' and 'handheld=yes' URL options are handled transparently -- 'screen' stylesheets are hidden, while those with no media specifier are left.

MediaWiki:Common.css is now listed without media -- so infoboxes are still formatted -- while the skin-specific eg MediaWiki:Monobook.css are listed for screen, as they're specific to the on-screen skin.

Note it should be a matter of one line of code to add a MediaWiki:Print.css and have it correctly handled now.

* All sheets are now loaded via <link rel="stylesheet"> instead of a mix of those and @import decls.

IIRC we had used @import originally to hide styles from Netscape 4, which tends to utterly break on MonoBook, but these days that's pretty much a non-issue.
@import also breaks some browsers' ability to save stylesheets with a file to disk, which sucks.

Confirmed that Firefox 3 can now save pages with their styles.

* 'screen, projection' media specifier has been changed to just 'screen' -- projection is something totally different.

* Added experimental options for specifying handheld stylesheets:

/**
 * Optionally, we can specify a stylesheet to use for media="handheld".
 * This is recognized by some, but not all, handheld/mobile/PDA browsers.
 * If left empty, compliant handheld browsers won't pick up the skin
 * stylesheet, which is specified for 'screen' media.
 *
 * Can be a complete URL, base-relative path, or $wgStylePath-relative path.
 * Try 'chick/main.css' to apply the Chick styles to the MonoBook HTML.
 *
 * Will also be switched in when 'handheld=yes' is added to the URL, like
 * the 'printable=yes' mode for print media.
 */
$wgHandheldStyle = false;

/**
 * If set, 'screen' and 'handheld' media specifiers for stylesheets are
 * transformed such that they apply to the iPhone/iPod Touch Mobile Safari,
 * which doesn't recognize 'handheld' but does support media queries on its
 * screen size.
 *
 * Consider only using this if you have a *really good* handheld stylesheet,
 * as iPhone users won't have any way to disable it and use the "grown-up"
 * styles instead.
 */
$wgHandheldForIPhone = false;
2008-07-28 05:09:08 +00:00
Aryeh Gregor
0c462b0f6c (bug 14520) Don't load nonexistent CSS fix files for Chick, Myskin, Simple 2008-06-13 00:51:52 +00:00
Alexandre Emsenhuber
087a9f70c5 WARNING: HUGE COMMIT
Doxygen documentation update:
* Changed alls @addtogroup to @ingroup. @addtogroup adds the comment to the group description, but doesn't add the file, class, function, ... to the group like @ingroup does. See for example http://svn.wikimedia.org/doc/group__SpecialPage.html where it's impossible to see related files, classes, ... that should belong to that group.
* Added @file to file description, it seems that it should be explicitely decalred for file descriptions, otherwise doxygen will think that the comment document the first class, variabled, function, ... that is in that file.
* Removed some empty comments
* Removed some ?>

Added following groups:
* ExternalStorage
* JobQueue
* MaintenanceLanguage

One more thing: there are still a lot of warnings when generating the doc.
2008-05-20 17:13:28 +00:00
Alexandre Emsenhuber
675a2245dd Doc cleanup:
* Remove deprecated "@package MediaWiki" from comments
* Kill ending ?> tag in AdminSettings.sample
* remove uneeded comment in SpecialPage.php
* update some links to docs/skin.txt instead of skin.txt
2008-03-18 16:56:52 +00:00
Aryeh Gregor
a15c419b3d Remove ?>'s from files. They're pointless, and just asking for people to mess with the files and add trailing whitespace. (Yes, I looked over every one and reverted those that were bogus. Slash-enter a million times in less worked well enough, although it was a bit mind-numbing.) 2007-06-29 01:19:14 +00:00
Nick Jenkins
baaee13afc Prevent some unnecessary lstat system calls, generated by include or require directives.
This can be done either by:
* Using explicit full paths, using the $IP global for the installation directory full path, and then working down the tree from there.
* Using explicit full paths, using the "dirname(__FILE__)" directive to get a full directory path for the includer file. 
* Occasionally removing the line altogether, and then for some files the inclusion is handled by the autoloader.

For example, if the "extensions/wikihiero/wh_main.php" file does an include or require on "wh_list.php", then PHP does the following:
* tries to open "wiki/wh_list.php", and fails.
* tries to open "wiki/includes/wh_list.php", and fails.
* tries to open "wiki/languages/wh_list.php", and fails.
* tries to open "wiki/extensions/wikihiero/wh_list.php", and succeeds.

So in this example, the first 3 calls can be prevented if PHP is told where the file is.

Testing Method: On a Linux box, run these commands to attach strace to all the apache2 processes, and log their system calls to a temporary file, then generate some activity, and then stop the strace:
-----------------------------------
rm /tmp/strace-log.txt
strace -tt -o /tmp/strace-log.txt -p `pidof apache2 | sed 's/ / -p /g'` &
php maintenance/fuzz-tester.php --keep-passed-tests --include-binary --max-runtime=3 > /tmp/strace-tests.txt
killall -9 strace
grep "No such file or directory"  /tmp/strace-log.txt | sort -u
-----------------------------------

Any failed file stats will be marked with: "-1 ENOENT (No such file or directory)".

Also:
* Strict Standards: Undefined offset:  230 in includes/normal/UtfNormal.php on line 637
* Strict Standards: iconv() [<a href='function.iconv'>function.iconv</a>]: Detected an illegal character in input string in languages/Language.php on line 776
  [Note: Partial only - despite adding "//IGNORE", it still seems to be possible with some
         messed- up binary input to cause PHP 5.1.2's iconv() function to squeal like a stuck pig].
* Update one $fname variable (method belongs to HistoryBlobStub class).
2007-02-09 05:36:56 +00:00
Antoine Musso
c771fc9c96 Use Doxygen @addtogroup instead of phpdoc @package && @subpackage 2007-01-20 15:09:52 +00:00
Brion Vibber
266d41f165 * Added wfDie() wrapper, and some manual die(-1), to force the return code
to the shell to return nonzero when we crap out with an error.
2006-01-14 02:49:43 +00:00
Antoine Musso
b2fffb7476 Bring back "chick" skin that missed the 1.4 skin system file (Chick.php) 2005-07-19 09:54:09 +00:00
Tim Starling
c2aa665160 Moved non-working skins to "disabled" subdirectory 2004-11-18 11:43:07 +00:00
Antoine Musso
b89965cded Skins classes under their own phpdocumentor subpackage: "Skins" 2004-09-03 21:02:18 +00:00
Antoine Musso
c80e819301 Security fix: do not use $IP on include (thanks brion) 2004-09-02 03:48:26 +00:00
Antoine Musso
7dbd56950b New system to generate $wgValidSkinNames by listing available dirs. Skins using PHPTal will not load and the software fallback to the standard skin. Added 2 samples for skin designers and updated doc 2004-09-02 03:24:01 +00:00
Antoine Musso
55d0916192 moving templates from /templates/ to /skins/ . xhtml_slim.pt is now MonoBook.pt, xhtml_minimal.pt is now Chick.pt, xhtml_slim_wikimediawiki.pt is now WikimediaWiki.pt 2004-09-02 02:15:54 +00:00
Antoine Musso
fd758aaa3c Big change to the skin system. Php files are now in ./skins/ . Templates and stylesheets will be migrated there as well later. The main idea is to let users add new skins easily without hacking mediawiki 2004-09-02 01:29:18 +00:00