Commit graph

10 commits

Author SHA1 Message Date
Bartosz Dziewoński
667522795b Fix trivial PHPCS violations in */skins/* directories
Due to T127238, files in various */skins/* directories are not checked
by PHPCS. Temporarily removed the exclude rule from phpcs.xml and ran:

  composer fix includes/skins/* tests/phpunit/includes/skins/* tests/phpunit/skins/*

Change-Id: I9240c1cee825920b6634903282be6252cce55686
2016-03-02 21:02:15 +01:00
umherirrender
d8821f2b0b Fixed spacing
- Removed space after casts
- Removed spaces in array index
- Added spaces around string concat
- Added space after words: switch, foreach
- else if -> elseif
- Removed parentheses around require_once, because it is not a function
- Added newline at end of file
- Removed double spaces
- Added spaces around operations
- Removed repeated newlines

Bug: T102609
Change-Id: Ib860222b24f8ad8e9062cd4dc42ec88dc63fb49e
2015-06-17 20:22:32 +00:00
jenkins-bot
b3efe0ca7d Merge "PLURAL support for list lengths in default-skin-not-found" 2015-04-09 00:44:21 +00:00
Kunal Mehta
6e378cf93f SkinFallback: Recommend using wfLoadSkin() if possible
Change-Id: I4f3841029578305ab692d853c45678f487adbc78
2015-04-03 09:07:30 +01:00
purodha
acec6c8d8b PLURAL support for list lengths in default-skin-not-found
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Default-skin-not-found/en_(2)

Change-Id: I7cfde0743f9a97927b3db134b1f0ae51950f8a3f
2015-04-02 02:09:22 +00:00
Amir E. Aharoni
18dbb814ff Remove dir=auto from firstHeading
dir="auto" was added in r105854 and r105870.
It happens to be useful for completely left-to-right titles
in right-to-left wikis, but time and again the users complain
about titles that are generally right-to-left, but begin with
a left-to-right character, such as
https://fa.wikipedia.org/wiki/3GP_%D9%88_3G2

This seems to cause more problems than it resolves.
Some day we may have proper direction for titles.
Until then we should probably go back to just displaytitle.

Bug: T51093
Change-Id: Ibf408bc6c5d2f8c05667107a547b0b02e06de270
2015-01-24 14:05:03 +00:00
Kunal Mehta
16246fd0e4 SkinFallbackTemplate: Remove outdated @todo
It was already implemented

Change-Id: I74d326b60c19bbee67e83980fa47ecbb26250359
2014-11-26 20:56:44 -08:00
Fomafix
8ce0329e07 Remove space from the begin and the end of the heading
Whitespaces between the opening tag <h1> and the content and
between the content and the closing tag </h1> gets converted to a space
when selecting the heading by a triple click and copying it to clipboard

See Ic9887a079734b28155f46ffaeedec02ff8ad81ca for skin Vector.

Change-Id: If90928b5f66dc10e3e8024e31d96be25462e446c
2014-10-10 15:20:10 +00:00
Kunal Mehta
28459b83a5 SkinFallbackTemplate: Use SkinFactory instead of $wgValidSkinNames
Change-Id: I463d263fc24a3e0c589ddc7176b77dffde17d105
2014-08-13 20:20:19 +00:00
Kunal Mehta
eb37e9d1ff Introduce SkinFactory
Modeled similar to ConfigFactory, this lets skins
register themselves via a callback, allowing for
proper dependency injection.

Loading via $wgValidSkinNames is still supported,
but considered "legacy", not deprecated though.

Skin::newFromKey is now deprecated (and had only
one caller in an extension, which I'll update
afterwards).

Change-Id: I1960483f87c2ef55c994545239b728fa376f17f4
2014-08-09 21:40:54 +01:00
Renamed from includes/SkinFallbackTemplate.php (Browse further)