Commit graph

9 commits

Author SHA1 Message Date
Timo Tijhof
8fbd1cd1e1 phpunit: Fix OutputPage::__construct warning in SkinTemplateTest
https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/2562/console
> Deprecated: Use of OutputPage::__construct was deprecated in MediaWiki 1.18.
> .. SkinTemplateTest->getMockOutputPage() ..

Change-Id: I7f44ffecc40b9d972839554361660e5b38ce3aef
2017-02-08 18:19:43 +00:00
addshore
3968dc9379 Add tests for SkinTemplate::setupSkinUserCss
Change-Id: I2033a98c3934a6e246b91338fd13472c4def0ddb
2017-01-20 14:10:52 +00:00
Chad Horohoe
b664350b0b SkinTemplateTest typofix
There's no "t" in "make"

Change-Id: I41dc25162262bddec94f3af35db86a246ccd7499
2016-08-11 13:54:05 -07:00
Bartosz Dziewoński
667522795b Fix trivial PHPCS violations in */skins/* directories
Due to T127238, files in various */skins/* directories are not checked
by PHPCS. Temporarily removed the exclude rule from phpcs.xml and ran:

  composer fix includes/skins/* tests/phpunit/includes/skins/* tests/phpunit/skins/*

Change-Id: I9240c1cee825920b6634903282be6252cce55686
2016-03-02 21:02:15 +01:00
Timo Tijhof
b4bac102b6 tests: Clean up file headers
* Remove redundant @licence/@license from test suite files.
  They already have full licence headers. And @licence raises a
  warning in Doxygen.

* Fix weird messes of comments inside comments and other things.

Change-Id: I38da8ca76330f72b8dc22b0ecf1ea69d5ea55ede
2015-04-01 00:17:12 +01:00
umherirrender
63dc5abc9a Fixed spacing
- Added space after reserved words: function, foreach, if
- Combined 'else if' into elseif
- Added braces to one-line statements
- Added spaces after comma, before parentheses

Change-Id: Ie5bbf680d6fbe0f0872dab2700c16b1394906a72
2014-08-27 18:31:50 +02:00
Kunal Mehta
d9d0289b6c Add more tests for SkinFactory
Change-Id: I0a8f93abe597d6b2393f1c813e7bf76093f3ec89
2014-08-20 00:26:50 -07:00
umherirrender
ab20f80116 Fixed spacing
- Added newline at end of files
- Added/Removed spaces around comma, parentheses and negation
- Added space after function word

Change-Id: I2dd338153aeb5f07702ba015945e95c7d0ae673b
2014-08-13 20:14:56 +00:00
Kunal Mehta
eb37e9d1ff Introduce SkinFactory
Modeled similar to ConfigFactory, this lets skins
register themselves via a callback, allowing for
proper dependency injection.

Loading via $wgValidSkinNames is still supported,
but considered "legacy", not deprecated though.

Skin::newFromKey is now deprecated (and had only
one caller in an extension, which I'll update
afterwards).

Change-Id: I1960483f87c2ef55c994545239b728fa376f17f4
2014-08-09 21:40:54 +01:00