Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
117924 commits 1 branch 0 tags 744 MiB
Commit graph

9 commits

Author SHA1 Message Date
Umherirrender
1086958611 Replace array_keys in foreach to use $_ as value instead 
When the value of the associated array is not used, there is no need to
use array_keys and create internal a copy of the array, just omit the
value with $_ to tell static analyzer that the var is unused.

Change-Id: I5c6d667e98c0167c0573c683f0d617bc1d4ca619
 2023-07-10 02:53:52 +00:00
Daimona Eaytoy
1c6e872bd4 Replace usages of deprecated MWException 
Use SPL exceptions instead when the exception is unchecked.

Bug: T328220
Change-Id: Ia1e5edc2ef3269a44b670262b78b305d07559829
 2023-06-06 17:05:32 +02:00
Tim Starling
317b460500 Fix even more PHPStorm inspections (#3) 
* Inappropriate @inheritDoc usage. Arguably all @inheritDoc is
  inappropriate but these are the ones PHPStorm flags as misleading
  due to the method not being inherited.
* Doc comment type does not match actual argument/return type.
* I replaced "@return void|never" with "@return void" since never means
  never, it doesn't make sense for it to be conditional. If a method
  can return (even if that is unlikely) then @return contains the type
  that it returns. "@return never" means that there is no such type
  because the method never returns.
* Incomplete/partial/broken doc tags

Change-Id: Ide86bd6d2b44387f37d234c2b059d6fbc42ec962
 2023-03-25 00:30:15 +00:00
James D. Forrester
ad06527fb4 Reorg: Namespace the Title class 
This is moderately messy.

Process was principally:

* xargs rg --files-with-matches '^use Title;' | grep 'php$' | \
  xargs -P 1 -n 1 sed -i -z 's/use Title;/use MediaWiki\\Title\\Title;/1'
* rg --files-without-match 'MediaWiki\\Title\\Title;' . | grep 'php$' | \
  xargs rg --files-with-matches 'Title\b' | \
  xargs -P 1 -n 1 sed -i -z 's/\nuse /\nuse MediaWiki\\Title\\Title;\nuse /1'
* composer fix

Then manual fix-ups for a few files that don't have any use statements.

Bug: T166010
Follows-Up: Ia5d8cb759dc3bc9e9bbe217d0fb109e2f8c4101a
Change-Id: If8fc9d0d95fc1a114021e282a706fc3e7da3524b
 2023-03-02 08:46:53 -05:00
Daimona Eaytoy
947ff7c0f5 build: Update mediawiki/mediawiki-phan-config to 0.12.0 
This patch only adds and removes suppressions, which must be done in the
same patch as the version bump.

Bug: T298571
Change-Id: I4044d4d9ce82b3dae7ba0af85bf04f22cb1dd347
 2022-10-08 15:45:42 +02:00
Umherirrender
39a4ddf689 Improve docs from parser objects PPNode/PPFrame 
Change-Id: Ie1bd0fb52a16277482ce461a50b16550332b6768
 2021-02-01 19:37:33 +00:00
Umherirrender
e9e784a09e build: Enable phan-taint-check-plugin and suppress issues 
Taint check checks for possible security issues by tracking html
escaping and more by using phan.
This slows done the phan-job a bit and requires more ram

Keep the DoubleEscaped issues out to make reviewer easier

Adds suppression for false positives
Adds taint-annotation to help taint-check
Removes suppression for code phan now understand better by the tracking
of keys in taint-check
Fix some small issues by adding int cast or htmlspecialchars calls

Bug: T216348
Bug: T268920
Change-Id: I849ac4f120fd15b483e8939d4db45c98dc351259
 2020-12-30 19:02:22 +01:00
Daimona Eaytoy
15e4968ee9 parser: Declare some dynamic properties 
Mostly via the @property annotation. This is to make phan a little
happier.

Change-Id: I3fde33955240dab20870821e9db93caba163845b
 2019-09-08 19:03:03 +00:00
Zoranzoki21
4226fada45 Split parser related files to have one class in one file 
Change-Id: I36b26609ccb3f135a22961b32a46cdc06603b3e4
 2019-04-27 00:41:47 +00:00