Commit graph

66 commits

Author SHA1 Message Date
Siebrand Mazeland
e8a65f9e25 Update break notation to self enclosed and properly spaced 2009-11-14 20:59:15 +00:00
Aaron Schulz
e07adc0e3c A few cleanups for r58351 2009-10-30 02:23:58 +00:00
Aaron Schulz
90dcb3c1f2 * bug 21267 change "show/hide" to "show", if user cannot submit Special:Revisiondelete
* Added revDeleteLinkDisabled() function
2009-10-30 02:14:22 +00:00
Chad Horohoe
dcac5f193e (bug 19859) Remove HTMLDiff. Could possibly be salvaged as an extension one day, but not today. DifferenceEngine and friends will need some refactoring to allow spinning this off. In the meantime, removing the mostly-broken experimental feature. Its always in the logs if anyone wants to reuse the code somewhere else one day 2009-10-28 18:18:05 +00:00
Aaron Schulz
cdace26ad3 bug 21282 &unhide=1 on next/prev diff links if already viewing the diff 2009-10-28 06:37:51 +00:00
Aaron Schulz
4a851b7dd4 Tweak r58117: removed diff-multi class 2009-10-25 15:30:31 +00:00
Aaron Schulz
8c74d4b938 Added deleted diff notice for unhide=1 urls to be clear and consistent 2009-10-25 15:27:49 +00:00
Alexandre Emsenhuber
e14987e85d * (bug 21053) Fixed diff header layout for multi diffs with no changes 2009-10-22 15:11:52 +00:00
Brion Vibber
2a113f6a3a fix eol style 2009-10-01 19:32:28 +00:00
Aaron Schulz
4f9f6cbf73 added 'rev-suppressed-unhide-diff' 2009-09-30 23:12:05 +00:00
Aaron Schulz
c2f7ea4d7b * Renamed deletedcontent to deletedtext
* Removed deletedrevision and used deletedhistory/deletedtext instead
2009-09-30 19:50:35 +00:00
Aaron Schulz
ea63b48375 Follow-up r57109: missing file 2009-09-30 15:45:38 +00:00
Aaron Schulz
1c4e82f84d Moved UI diff stuff into its own DifferenceInterface file 2009-09-30 15:36:55 +00:00
Aaron Schulz
942a84716a * Split off deletedrevision (view only) right and give it to sysops
* Allow show/hide link on top revision just like history
2009-09-28 03:09:48 +00:00
Tim Starling
51e9917aa8 Fix for bug 20601: disable debug output. It can be re-enabled by patching. 2009-09-16 03:48:29 +00:00
Niklas Laxström
22f142a99c Recommit r53710 without the hack for preventing style sheets being added multiple times (is not possible with OutputPage::addStyle in the first place) 2009-08-24 05:37:40 +00:00
Brion Vibber
82b80fc483 Revert r53710 "* Allow suppressing "line 1" from the diffs, which can get quite annoying with many diffs"
Use of static variable here means that running multiple diffs during one request may mess things up. It should rather check if it's been added in $wgOut already.
2009-08-21 22:01:16 +00:00
Aryeh Gregor
3f3b9d28a2 Show change flag tooltips everywhere, not just RC
Follow-up to r54242.  Pointed out by Umherirrender on CodeReview.
2009-08-04 00:28:20 +00:00
Chad Horohoe
a2462d8fcd * (bug 16311) Make recent change flags acronyms instead of spans. Also move this crap to common, we don't need identical declarations in 5 different skins. 2009-07-29 22:15:52 +00:00
Niklas Laxström
bc43f524f7 * Don't add 200 extra css/js requests when showing 100 diffs
* Allow suppressing "line 1" from the diffs, which can get quite annoying with many diffs
2009-07-24 11:06:27 +00:00
Aaron Schulz
2a763847ca Enable show/hide link on diff to cur (consistency) 2009-07-18 02:51:41 +00:00
Siebrand Mazeland
8bc003e538 * follow-up to r51301: also add separated date and time as parameters for 'currentrev-asof' for consistency
* replace use of deprecated makeKnownLinkObj() by link()
* use array type parameter instead of string to escapeLocalUrl(), getFullURL() and getFullUrl() for readability
* change return type of htmlDiffArgument(). CHECKME: Should this method be private? (not used anywhere in SVN at the moment)
* break a few long lines with parameters
2009-06-06 15:09:19 +00:00
Tim Starling
9a1bfc924b Fix for r49412, possible fatal errors. 2009-06-03 16:33:08 +00:00
Purodha B Blissenbach
00a913cecd Message 'revisionasof' - date and time separated as of request by user "Der Umherirrende" at
http://translatewiki.net/w/i.php?title=Support&oldid=1243738#split_date_and_time
2009-06-01 20:45:46 +00:00
Tim Starling
bc35951c93 In Special:RevisionDelete:
* Refactored to remove massive duplication
* Removed page parameter and associated contextPage member variable, doesn't seem to do anything.
* Put ID lists into a single ids parameter and member variable instead of having one for each type.
* Fixed inappropriate call of Title::newFromUrl(), always wrong
* Don't pretend to use the return value from functions that don't return anything, this reduces readability.
* Use the table names for deleteKey/typeName values, they look more like English
* Use protected not private
* Remove requirement for log type to be specified in the target
* Use POST for RevisionDelete entry forms, to avoid URL size limits and issues with non-PATH_INFO URLs
* Don't purge all pages that use the given file
* LocalFile::purgeCache() already calls purgeHistory,() no need to do it again. But do call purgeDescription(). 
* Removed token from unhide=1 links, unnecessary
* Tokens are necessary on file streaming links, added them
* Fixed private data leakage due to incorrect use of LocalRepo::newFromArchiveName(). Non-existent placeholder file was returned which meant that $oimage->userCan(File::DELETED_FILE) was always true. Pass the archive name to tryShowFile() instead of the storage key.
* Using ls_field='oi_timestamp' is not correct, oi_timestamp refers to the timestamp of the revision in question, whereas the key that is stored is the timestamp of the previous revision (i.e. the timestamp in oi_archive_name). oi_archive_name would be more correct, although only half the field is used.

Elsewhere:
* Added missing message filehist-missing
* Fixed double asterisk in Status::getWikiText()
* Fixed escaping of the target parameter to Special:RevisionDelete from ImagePage
* Deleted FileStore.php. Deprecated in filerepo refactor except for get()/export() but somehow resurrected by RevisionDelete. Hopefully this will be the end of it. New interfaces will be added for wfStreamFile() in a later commit.
* Added convenience function File::getStorageKey(), factored out of Special:Undelete
* Added convenience function Revision::newFromArchiveRow(), factored out of Special:Undelete and Special:RevisionDelete
* Fixed notice in Special:Upload, uninitialised $pageText

FIXME: current revision can be suppressed on undeletion causing an unauthenticated unsuppress. Comments indicate this is a known issue. I fixed the parser cache pollution in this case but not the rest.
2009-06-01 11:37:06 +00:00
Niklas Laxström
d3b61fea7c Escaping fixes 2009-05-22 09:35:48 +00:00
Chad Horohoe
02e9f413eb Cleanup to r50310 & 50313: Don't use @ on chmod() and dl(), use wfSuppressWarnings()/wfRestoreWarnings() 2009-05-19 16:34:49 +00:00
Alexandre Emsenhuber
2a82a66505 fix E_PARSE from r50310 2009-05-07 16:51:45 +00:00
Chad Horohoe
389f46dfbe (bug 16925) Diffs no longer silently fail when $wgExternalDiffEngine is set to 'wikidiff' or 'wikidiff2' but extension is not installed. Should now gracefully fall back to the PHP diff. 2009-05-07 16:00:29 +00:00
Aaron Schulz
318783dc36 * Workaround ugly Safari/Chrome handling of <col> tags for hidden diffs (bug 18538)
* A few code style tweaks
2009-04-21 06:21:27 +00:00
Chad Horohoe
78b1818dbe No more $wgTitle in the diff engine. 2009-04-11 18:23:06 +00:00
Aaron Schulz
4b9187e598 Add convenience links for bug 18068 2009-03-22 13:26:27 +00:00
Roan Kattouw
2b9be47063 (bug 17863) Fix regression from r47890 that broke Show changes on the edit form; do this by skipping over revision loading as well as text loading when custom texts are set using setText() 2009-03-09 11:00:12 +00:00
Roan Kattouw
5349ea2dd8 * API: (bug 13209) Add rvdiffto parameter to prop=revisions
* Add $wgAPIMaxUncachedDiffs (default 1) which controls how many non-cached diffs will be served per request
* Tweak DifferenceEngine.php a bit to make cache status accessible, and remove a useless 'parseinline' which broke diff generation in the API
2009-02-28 13:25:21 +00:00
Aaron Schulz
b99b877508 Bug 17241 The diffonly URI parameter should cascade to "Next edit" and "Previous edit" diff links 2009-02-24 23:17:08 +00:00
Raimond Spekking
aa0f3bbaeb Move <div>...</div> from message text to program code for consinstency with all other messages. 2009-02-22 11:32:33 +00:00
Aaron Schulz
2437a0a1a0 (bug 5776) Add extra patrol link on bottom for diffs 2009-02-12 14:45:10 +00:00
Aaron Schulz
0821fa7da9 Added missing Revision::FOR_THIS_USER flag 2009-02-09 22:41:02 +00:00
Aaron Schulz
ad708b10eb Tweaks for bug 17060
* Don't show links to deleted revs in history for anyone (consistency)
* Always hide deleted content from all users; it can be viewed via (show/hide) links
2009-02-09 22:27:25 +00:00
Aaron Schulz
6bfaecba3b * Tweaks for bug 17052:
** Made radio button default selection fallback to the next one for deleted revs
** Use deleted diff message rather than showing an ambiguous "empty diff"
* Code style tweaks
2009-02-09 07:42:54 +00:00
Niklas Laxström
71604e3978 * kill E_NOTICE 2009-02-01 15:44:01 +00:00
Aaron Schulz
ebddcaca6a (bug 17104) Remove [Mark as patrolled] link for already patrolled revisions 2009-01-24 22:50:28 +00:00
Alex Z
b5d624f1c0 (bug 17055) Use a CSS class ('mw-revdelundel-link') for RevisionDelete "(show/hide)" links rather than hardcoded <tt><small>, reduce some code duplication by creating Linker::revDeleteLink() to make the links. 2009-01-18 21:07:09 +00:00
Aaron Schulz
8075446c1c Use getRawUserText function, since this is just there to trigger index usage for patrol link query 2009-01-15 17:33:13 +00:00
Aaron Schulz
e9fefecaed Fix for r45723 2009-01-14 00:39:43 +00:00
Aaron Schulz
92b51089ac Cleaned up single rev page diffs (bug 11527) 2009-01-14 00:26:21 +00:00
Aaron Schulz
220c59be9a (bug 16923) New parameter value diff=review for the URL 2009-01-07 21:09:18 +00:00
Aaron Schulz
82c0328abf Tweak r45314: just return out 2009-01-02 15:56:33 +00:00
Aaron Schulz
19024619f6 (bug 9243) Avoid exit to make MW handle page exceptions properly 2009-01-02 11:36:52 +00:00
Alexandre Emsenhuber
8c14e2df88 * Like r44911 but for MediaWiki:Difference message: switching from raw HTML to wiki text
* Whitespaces tweaks
2008-12-23 17:14:33 +00:00