Commit graph

891 commits

Author SHA1 Message Date
Aaron Schulz
1627c222df Remove some individual transactions 2008-09-19 10:13:32 +00:00
Aaron Schulz
22c8d2d293 * Clean up patrol code to not possibly log twice (depended on slave lag)
* Make notifyEdit() return the whole RC object
* Spacing tweaks
* Wrap patrolling in a transaction
2008-09-19 00:11:41 +00:00
Aaron Schulz
2ce6d6e7b6 Wrap $log->addEntry() in transaction 2008-09-18 23:43:41 +00:00
Aaron Schulz
fe14adefe8 Avoid undefined var errors if data fetch fails 2008-09-16 18:39:13 +00:00
Alex Z
409860c8ac *Re-implement r40723 in Article::view()
*Slight fix to EditPage following r40899
2008-09-16 18:31:55 +00:00
Aaron Schulz
12d279ff91 * Make sure we have the right article ID, not slave lagged. (bug 8072)
* Make FileDeleteForm use hook properly
2008-09-16 17:08:08 +00:00
Aaron Schulz
0b9428f87a * Deal with new page move scenario (bug 3481)
* Move cat count stuff down in transaction for bug 13921
2008-09-16 13:29:01 +00:00
Aaron Schulz
d09a670dcf whitespace tweaks 2008-09-16 10:39:30 +00:00
Tim Starling
60fa3e5b79 Revert r40723, and associated i18n. Unexpected side effects in Article::getContent(). Should be implemented in Article::view() if it's implemented at all. 2008-09-16 09:42:31 +00:00
Tim Starling
7273a8b53c Fix $user parameter to Article::doEdit(), which was broken for page creation (worked only for page updates). 2008-09-15 05:34:32 +00:00
Aaron Schulz
ed3a7d5784 * Fix edit comment spacing
* Code spacing
2008-09-13 15:04:41 +00:00
Alex Z
807c3afaa7 (bug 12650) Make it possible to enter separate expiry times for each restriction type. 2008-09-13 05:33:24 +00:00
Aaron Schulz
d04ddbaf9f Tweak transaction for bug 13039 2008-09-12 15:03:46 +00:00
Alexandre Emsenhuber
8efff20140 Use content language as this will be hardcoded in the database 2008-09-11 10:57:56 +00:00
Alex Z
31b60f050a (bug 15551) Show deletion log excerpts when a user follows a redlink, even if they can't edit the page. 2008-09-11 03:50:53 +00:00
Aaron Schulz
a35b7d2a5e We still want details in page history 2008-09-10 21:03:57 +00:00
Aaron Schulz
be13f1d353 Move protection log parameters to log_params. Solves bug 12234 and is better for i18n. 2008-09-10 19:44:56 +00:00
Alexandre Emsenhuber
c7a1f89262 (bug 15292) New message notification for unregistred users now works again 2008-09-04 23:25:53 +00:00
Roan Kattouw
bd3bf5d2a7 * Split patrol code
** Backend code moved to RecentChange::reallyMarkPatrolled() and doMarkPatrolled()
** Adapted Article::markpatrolled()
* (bug 15466) Added action=patrol to the API. Modified patch by Soxred93
* Added rctoken=patrol to list=recentchanges
* Detect duplicate warnings in ApiBase::setWarning()
2008-09-04 15:17:51 +00:00
Aaron Schulz
e0df25940f Add ampersand to hook 2008-09-02 21:38:42 +00:00
Roan Kattouw
e404d0e6e1 (bug 15358) Article::doEdit() ignores $user when inserting a new revision 2008-08-28 20:20:52 +00:00
Brion Vibber
2b5f7032ec Revert r40042 "* In Article::replaceSection(), actually return null when $section is bogus. Used this in my half-complete and now kind of abandoned attempt at rewriting EditPage.php"
This causes regression bug 15340 -- null-edits to a section destroy the rest of the page.
2008-08-27 21:12:44 +00:00
Roan Kattouw
323c3a6e71 * In Article::replaceSection(), actually return null when $section is bogus. Used this in my half-complete and now kind of abandoned attempt at rewriting EditPage.php
* In UserMailer::send(), allow the caller to override the Content-type header so people can send multipart messages if they really want to. Using this in an extension I'm developing
2008-08-26 20:07:53 +00:00
Aaron Schulz
9350615e17 mark getOldIDFromRequest as public 2008-08-26 00:32:55 +00:00
Guy Van den Broeck
9e1fad1826 History page with HTML diff enabled now also works when JavaScript is disabled. 2008-08-22 16:53:56 +00:00
Guy Van den Broeck
683618fd33 Added button for Visual Comparison to history page, previous and next diff buttons follow that choice consistently and diff pages have a link to switch from/to source/visual comparison 2008-08-21 00:45:13 +00:00
Aaron Schulz
c0b011b5b8 function is not static 2008-08-20 19:13:13 +00:00
Chad Horohoe
08021b0b30 Move the call to view() for Action::purge() up from doPurge() to purge(). Kinda like last time, only less broken. Calling Article::doPurge() now lets the backend do a purge without output (and doesn't turn Article::purge() into a UI and backend entry, which is good) 2008-08-19 19:10:07 +00:00
Brion Vibber
5667e45446 Reverting r39619 "(bug 13689) Page output can be suppressed on Article::purge() by passing bool false to it. Default (ie: nearly 100+% of the time) is true."
Article::purge() is a UI action entry point, not a backend method. Backend-only parameters aren't appropriate here; instead a method suitable for backend usage should be created (and/or in an ideal world, we should finish splitting Article backend stuff from UI frontend as separate classes)
2008-08-19 18:58:50 +00:00
Chad Horohoe
faaca125b1 (bug 13689) Page output can be suppressed on Article::purge() by passing bool false to it. Default (ie: nearly 100+% of the time) is true. 2008-08-18 22:21:13 +00:00
Alexandre Emsenhuber
c985f72800 Tweaks for Credits and Metadata:
* Put all functions into classed so that they can be autoloaded
* Marked all private methods as protected
* Article::getContributors() now returns UserArrayFromResult object
2008-08-18 19:21:55 +00:00
Andrew Garrett
419a2342c0 Core changes for DeleteQueue:
* Make Article::doEdit() accept a user who's making the edit, not rely on .
* Add Article::newFromID(), so you don't have to create a title (loading a page row), in order to get an Article (loading the same page row again).
2008-08-16 13:34:43 +00:00
Aaron Schulz
da4a31d15e Filecache should check &useskin. This should be backported. 2008-08-10 07:10:05 +00:00
Tim Starling
6f90d73d85 Fix fix r38823 2008-08-08 09:47:36 +00:00
Siebrand Mazeland
76b6b51054 Fix on r38763 for "PHP Fatal error: Call to a member function isLoggedIn() on a non-object in /var/www/w/includes/Article.php on line 2773" when editing a subpage of a user talk page.
Fix by demon
2008-08-08 00:01:53 +00:00
Tim Starling
73554ed829 Changes for NewUserMessage:
* Add UserGetReservedNames hook to allow extensions to define reserved names without loading messages at setup
* Don't try to notify nonexistent, non-IP users by inserting a username into the user_newtalk.user_ip field. It doesn't work.
2008-08-07 10:39:19 +00:00
Aryeh Gregor
2d115ac53b (bug 15007) New 'pagetitle-view-mainpage' message allows the HTML <title> of the main page to be customized. 2008-08-06 19:20:38 +00:00
Chad Horohoe
5459ad3f81 Remove unused global. 2008-08-02 08:10:45 +00:00
Chad Horohoe
07d9e2d766 Take Article::viewRedirect() public and have it return a string so it can be used other places, like EditPage for proper rendering of redirects on preview (bug 2333). +Docs here and there. 2008-08-02 02:39:09 +00:00
Chad Horohoe
c868ce1386 I honestly have no clue how this got committed; wasn't even using subversion. I really need some sleep it seems. 2008-07-31 02:44:56 +00:00
Chad Horohoe
0a257c43f7 2008-07-31 02:28:49 +00:00
Aaron Schulz
c527eaf8f4 set baseRevId (bug 14947) 2008-07-27 19:24:35 +00:00
Aryeh Gregor
7452677213 * Add count() method to TitleArray and UserArray.
* Change PageHistory::fetchRevisions() to return a result object instead of an array of rows.
* Stylistic issues: use foreach( $res as $row ) instead of while( $row = $dbr->fetchObject( $res ) ), change a couple of variable names, use __METHOD__.

There should be no functional changes.
2008-07-27 18:59:46 +00:00
Aryeh Gregor
783010c62f Move more initialization to member variable defaults. (The Title constructor now actually does nothing, but I left it for the comment.) 2008-07-25 20:16:24 +00:00
Aryeh Gregor
53e781f973 Change a few hardcoded select() parameters (one of which was actually incorrect) to __METHOD__. 2008-07-25 19:36:13 +00:00
Aryeh Gregor
650be91fb8 Refactor a bit preparatory to fixing bug 8068: rewrite the robot policy stuff in OutputPage to allow index and follow policy to be set separately. Also now validates input to setRobotPolicy(). And renamed setRobotpolicy to setRobotPolicy, too. If anyone was accessing $mRobotpolicy directly they're out of luck, though. 2008-07-23 19:05:43 +00:00
Raimond Spekking
51cc020b3a Move the hook 'NewRevisionFromEditComplete'
It should not run if a belated edit conflict occurs.
Issue reported by the German community after some weired revision histories were found.
2008-07-09 11:30:34 +00:00
Chad Horohoe
cc3e4bab11 Remove unused (and seemingly useless) param from confirmDelete(). 2008-07-07 16:56:32 +00:00
Chad Horohoe
a4e25cc202 Implement OFFSET in getContributors(). Nothing currently passes this param, so it shouldn't change any current behavior. 2008-07-07 01:11:50 +00:00
Aaron Schulz
58f01b0645 Re-commit fixed r37006 2008-07-04 09:38:12 +00:00