Commit graph

13 commits

Author SHA1 Message Date
Kunal Mehta
6e9b4f0e9c Convert all array() syntax to []
Per wikitech-l consensus:
 https://lists.wikimedia.org/pipermail/wikitech-l/2016-February/084821.html

Notes:
* Disabled CallTimePassByReference due to false positives (T127163)

Change-Id: I2c8ce713ce6600a0bb7bf67537c87044c7a45c4b
2016-02-17 01:33:00 -08:00
Aaron Schulz
2f2641dbda No-op the notify*/purge methods in JobQueueAggregatorRedis
This should be managed by the background service now

Change-Id: I5d905760b509f66e10019ff8a4146db8a6c4c9d7
2015-12-17 16:43:43 -08:00
jenkins-bot
7d3fc7346d Merge "Revert "Avoid doNotifyQueueEmpty() race conditions for Redis"" 2015-11-17 01:32:21 +00:00
Aaron Schulz
08ec4d97fb Make JobQueueAggregator::doNotifyQueueNonEmpty() avoid queries
Avoid 2 of the 3 queries in doNotifyQueueNonEmpty(), the ones
that register the queue, once such a command has been done in
the request already.

Change-Id: I58553f0c56660f05a3e3000065270baebb8cbb62
2015-11-15 20:16:31 +00:00
Aaron Schulz
d8666c0e22 Revert "Avoid doNotifyQueueEmpty() race conditions for Redis"
This might hitting a phpredis bug causing "read error" messages.

This reverts commit ab2e1dae28.

Bug: T118430
Change-Id: I45b009e8768b79368898762bfedbca4dc0a79943
2015-11-12 00:40:33 +00:00
Aaron Schulz
ab2e1dae28 Avoid doNotifyQueueEmpty() race conditions for Redis
Previously, races could cause queues to be seen as empty
and ignored when they actually have jobs in them.

Change-Id: I6cdf5c1fbd33c9ed7982e5d2d494974b1d7e09fd
2015-11-10 14:34:24 -08:00
Aaron Schulz
ff83473c81 Made JobQueueAggregatorRedis make sure the wiki set key is up-to-date
Change-Id: I84ccfd990fada80ee3005b746d33ed4473abb6d8
2015-05-02 13:07:55 -07:00
Aaron Schulz
37042262e3 Moved some JobQueueAggregator logic out of JobQueueGroup
Change-Id: I28ba1a25db225d4cf5f503a6c0f4405f13118151
2015-03-03 21:56:15 -08:00
umherirrender
44d14fc684 Doc: Reformat @params declaration
I have not found documentation about the @params command, so this seems
not valid.
I have moved the text to the corresponding @param

Change-Id: I443866d602b60570278289e6e24a77d37314cede
2014-07-24 13:12:18 +02:00
Aaron Schulz
821fadb67d Fixed JobQueueAggregatorRedis to handle empty collections
* Previously it would keep polling if the hash was empty since
  empty and non-existing collections are the same in Redis.
* Also turned off the pointless PHP serialization.
* Bumped the cache version key; this change should be deployed
  in all wikis at once, along with updating the runners.

Change-Id: I33dc55bc579bf678f14a5383e9e2c3c35231d599
2014-07-22 15:12:02 +00:00
Aaron Schulz
911d50b022 Also set the queue types map when rebuilding the ready queue map
Change-Id: I0686859541661a22131c387d8fac6dc7b074c18c
2014-06-05 09:24:59 -07:00
Aaron Schulz
a759746409 Track the types of queues in the redis queue aggregator
* This tracks all queue types in one simple location that
  can be inspected without using MediaWiki.

Change-Id: I197664b9aa620b29f1400e5a60c55a301348120d
2014-06-04 22:29:51 +00:00
Aaron Schulz
9ffd4f085d Renamed /job to /jobqueue
Change-Id: I4c8a2b42140630838867c77a70d45ba14b5d95e2
2014-03-14 13:42:04 -07:00
Renamed from includes/job/aggregator/JobQueueAggregatorRedis.php (Browse further)