Commit graph

311 commits

Author SHA1 Message Date
Aaron Schulz
6950c890bf (bug 5071) Image appears above text when viewing diff of an image page
* Hide image/toc on diff view. Previously, img cluttered the top of the diff and you had to scroll down. Also, we have thumbnails for the history (and current) anyway.
2009-01-02 19:11:34 +00:00
Brion Vibber
4164ab50d8 Revert r45191 "* (bug 14117) Image redirects from the shared repo now show "redirected from""
Seems to be bizarrely adding a "redirected from" subtitle to *every* shared image page view, instead of to redirects. WTF?
2008-12-31 22:06:22 +00:00
Victor Vasiliev
6285e1c92f * (bug 14117) Image redirects from the shared repo now show "redirected from" 2008-12-30 17:17:16 +00:00
Aryeh Gregor
69d11310ff Improve ugly interface for Sanitizer::escapeId()
Calling it with no extra arguments will now assume that you're escaping
a whole id, not an id fragment, which is safer.  Also, instead of ugly
bitfield-based options, I've changed the options to use an array of
strings.  I fixed all callers in trunk.  Out-of-tree callers that were
using Sanitizer::NONE will get correct behavior, while those that were
calling it with no arguments will get slightly changed behavior (an x
will be prepended).  I think this is harmless enough that we can skip
back-compat cruft here.

This should cause no visible changes.  No parser test regressions.
2008-12-30 00:22:14 +00:00
Brion Vibber
2a815b10bb Cleanup for r44700 -- work on a clone of $wgTitle instead of modifying the fragment on the global object, which interferes with some other generated links outside the pager. 2008-12-23 17:58:22 +00:00
Aaron Schulz
2e3272b80c Add fragment to nav links to set location 2008-12-17 01:35:40 +00:00
Aaron Schulz
753cc671ca Fix bug where new image uploads would be reviewed but had "changes needing review" tag 2008-12-15 23:51:28 +00:00
Chad Horohoe
be374a912a War on wfElement() and friends. Call the Xml members directly, rather than using old wrappers. 2008-12-14 19:14:21 +00:00
Aaron Schulz
6ac97292d2 Remove comment 2008-12-14 07:12:03 +00:00
Aaron Schulz
0ca92d0bf5 (bug 12645) File histories should be paged 2008-12-14 07:10:42 +00:00
Ilmari Karonen
34fb6297cd Step 2 in NS_IMAGE -> NS_FILE transition (bug 44) (WARNING: huge commit).
This is a global search and replace of NS_IMAGE and NS_IMAGE_TALK with NS_FILE and NS_FILE_TALK respectively in all core files, excluding those already updated in step 1 (r44004).
2008-12-01 17:14:30 +00:00
Alexandre Emsenhuber
9a6452960e Mark ImagePage::checkSharedConflictCallback() as public since it's passed to RepoGroup as callback function 2008-11-29 17:48:37 +00:00
Aaron Schulz
fbdb05fab3 *Remove getContent() side-effects
*Fix/set visibility
*Refactor deletion log stuff to helper function
*Add wfDeprecated( __METHOD__ ) to some places
*Various minor cleanup/spacing
2008-11-28 14:29:25 +00:00
Chad Horohoe
0848fa8b22 (bug 2077) Info on how to use external editor is vague. Minor tweak to the UI should make it a little more clear. 2008-11-18 19:57:03 +00:00
Siebrand Mazeland
0a9af4a884 Consistent casing for addHTML() 2008-11-06 22:20:29 +00:00
Rotem Liss
7b61b00333 Fixing HTML escaping. 2008-08-29 13:40:47 +00:00
Rotem Liss
2204974ba7 Show thumbnails in the file history list. The dimensions are the same as in the default image gallery. Patch by User:Agbad, rewritten by me. 2008-08-29 11:54:34 +00:00
Niklas Laxström
4618bb3e69 * Format numbers passed to messages
* Some whitespace changes
2008-08-08 21:31:38 +00:00
Brion Vibber
a8c59207ec Cleanup to cleanup -- keep the div name consistent! There's no reason to invent a new div id just because there's a different number of items. 2008-08-08 20:56:46 +00:00
Brion Vibber
6004c56463 Cleanup to r38799 ("Add a more descriptive message to the links-to-image section for the case that more than 100 pages link to a file.")
Lift out a little duplicated code for good style
2008-08-08 20:55:25 +00:00
Raimond Spekking
923f85f328 Add a more descriptive message to the links-to-image section for the case that more than 100 pages link to a file.
Ths existing link to Whatlinkshere at the end of the list is easily be overseen if not scrolled to the bottom.
Fixes the (cosmetic) bug that the list shows 101 entries instead of 100.
Question: Should we make the hardcoded limit of 100 configurable via DefaultSettings?
2008-08-07 18:46:18 +00:00
Chad Horohoe
07d9e2d766 Take Article::viewRedirect() public and have it return a string so it can be used other places, like EditPage for proper rendering of redirects on preview (bug 2333). +Docs here and there. 2008-08-02 02:39:09 +00:00
Raimond Spekking
c023318c02 Remove unused var $dims 2008-07-30 13:20:38 +00:00
Aryeh Gregor
650be91fb8 Refactor a bit preparatory to fixing bug 8068: rewrite the robot policy stuff in OutputPage to allow index and follow policy to be set separately. Also now validates input to setRobotPolicy(). And renamed setRobotpolicy to setRobotPolicy, too. If anyone was accessing $mRobotpolicy directly they're out of luck, though. 2008-07-23 19:05:43 +00:00
Aaron Schulz
69b77c726f Append subtitle to keep existing stuff for redirects (bug 14696) 2008-07-02 10:33:42 +00:00
Chad Horohoe
f47aa05e78 Use redirect=no on redirects listed in file links. 2008-06-17 14:36:36 +00:00
Brion Vibber
7aa0eb40ca cleanup for r36190 -- remove extra parameters left over from wfMsgExt() call 2008-06-11 17:45:16 +00:00
Raimond Spekking
1509ad4d13 Tweak for r36189: Back to addWikiMsg but now with the appropriate parameter. Thanks to Nikerabbit who points me to the correct usage. 2008-06-11 12:53:33 +00:00
Raimond Spekking
3c8690d8c4 Reapply support of plural for 'linkstoimage', 'redirectstofile' and 'duplicatesoffile'
Now w/o breaking customized messages.
2008-06-11 12:07:58 +00:00
Brion Vibber
1266ee5ab6 Reverting r36139 -- broke wikitext in linkstoimage AGAIN. 2008-06-11 01:51:12 +00:00
Raimond Spekking
d3f564d27f Support plural for 'linkstoimage', 'redirectstofile' and 'duplicatesoffile' 2008-06-10 11:19:34 +00:00
Raimond Spekking
61fe8acfc5 * (bug 14146) Wrap usage section on imagepages into <div>s.
Follow up to r35516. Wrap this section to.
2008-05-29 03:44:45 +00:00
Raimond Spekking
2c7d284a59 * (bug 14146) Wrap usage section on imagepages into <div>s. 2008-05-28 19:51:18 +00:00
Aaron Schulz
c3232e2dc0 Remove unused var 2008-05-23 21:12:47 +00:00
Tim Starling
079a37ef22 In FlaggedRevs:
* Moved the FlaggedRevs class to its own file
* Removed $wgFlaggedArticle, store an instance inside the Article object instead. Also store a reference in the Title object, since some hooks only have a Title available. 
* Modified all hooks which were previously calling $wgFlaggedArticle directly to go via an instance loader function.
* Merged hook functions for ArticleViewHeader and DiffViewHeader
* Changed the way FlaggedRevs sets the right image version in ImagePage, to avoid a function call on startup
* Some coding style changes, such as consistent variable case, consistent indenting style, meaningful variable names, etc.
* Fixed typo in updateAutoPromote.php
* Removed the $wgFlaggedRevsVisible feature, this doesn't seem to be in keeping with our mission so I couldn't see the point in spending a lot of time fixing its bugs. Revert if necessary.
* Use Xml::encodeJsVar() to transfer data from PHP to JS, don't DIY
* Use OutputPage::addHeadItem() instead of an infinite-lifetime variable to ensure that only one copy of the header item is added. OutputPage objects may come and go.
2008-05-23 09:03:49 +00:00
Brion Vibber
554ff3f6a6 Don't assume the file repository will always return an object when checking for dupes 2008-05-21 22:36:53 +00:00
Aaron Schulz
d4c4ed8bfe Minor comment tweak 2008-05-21 22:28:21 +00:00
Aaron Schulz
bc9a62d33e Logic errors 2008-05-21 22:20:07 +00:00
Aaron Schulz
2f01b8eee6 *Respect displayImg
*Add getDisplayedFile()
2008-05-21 21:33:58 +00:00
Aaron Schulz
40589a98d7 Cleanup for displaying old versions 2008-05-21 21:23:04 +00:00
Aaron Schulz
0a1bebd190 Backwards 2008-05-21 06:23:18 +00:00
Brion Vibber
03bfe91ec4 * (bug 14199) Fix deletion form for image redirect pages
Image deletion was popping up the special image deletion form for the target image, which isn't friendly for redirects. :)
Now checking for redirect state as well as non-localness and non-existence, and pop up the regular page delete form for this.
2008-05-20 22:09:30 +00:00
Alexandre Emsenhuber
087a9f70c5 WARNING: HUGE COMMIT
Doxygen documentation update:
* Changed alls @addtogroup to @ingroup. @addtogroup adds the comment to the group description, but doesn't add the file, class, function, ... to the group like @ingroup does. See for example http://svn.wikimedia.org/doc/group__SpecialPage.html where it's impossible to see related files, classes, ... that should belong to that group.
* Added @file to file description, it seems that it should be explicitely decalred for file descriptions, otherwise doxygen will think that the comment document the first class, variabled, function, ... that is in that file.
* Removed some empty comments
* Removed some ?>

Added following groups:
* ExternalStorage
* JobQueue
* MaintenanceLanguage

One more thing: there are still a lot of warnings when generating the doc.
2008-05-20 17:13:28 +00:00
Aaron Schulz
829b50956b * Use lazy initialization with loadFile()
* Add $current/$time to field list
* Fix some ugly coding style
2008-05-20 03:26:59 +00:00
Aaron Schulz
40ef91f329 Tweak $time default 2008-05-20 03:15:07 +00:00
Aaron Schulz
c651692075 Stabilize image description links 2008-05-19 18:55:48 +00:00
Aaron Schulz
a1f9401982 *Remove extra space
*Make revisiondelete links more compact
*Make user links clearer
2008-05-19 15:21:29 +00:00
Aaron Schulz
99c13c58da Make space breakable 2008-05-19 02:34:42 +00:00
Aaron Schulz
4bb299cbce *Add ImagePageFileHistoryLine hook
*Tweak hook doc order
*Mark flagged file versions in hist
*Remove $dbr field
*Tweak file histories to be more compact
2008-05-17 00:08:31 +00:00
Bryan Tong Minh
fe0f192c67 Do some refactoring on ImagePage. Shuffled the links section; Use Title::getRedirectsHere; Move duplicate detection to its own function. 2008-05-15 19:17:21 +00:00