Commit graph

7 commits

Author SHA1 Message Date
Umherirrender
e662614f95 Use explicit nullable type on parameter arguments
Implicitly marking parameter $... as nullable is deprecated in php8.4,
the explicit nullable type must be used instead

Created with autofix from Ide15839e98a6229c22584d1c1c88c690982e1d7a

Break one long line in SpecialPage.php

Bug: T376276
Change-Id: I807257b2ba1ab2744ab74d9572c9c3d3ac2a968e
2024-10-16 20:58:33 +02:00
Derick Alangi
4ed379cf8a
CommentStore: Typehint param in CommentStoreComment constructor
This had caused issues in the past like: T355751 but after doing a
recent check of production for these warnings for the last 6 months,
I don't seem to see anything.

Maybe they've all been addressed so let's try again and see how it
goes.

Change-Id: Iaffe22ae420f043b8e71386178c0a8619bc85349
2024-07-24 23:58:05 +02:00
James D. Forrester
8e940c4f21 Standardise all our class alias deprecation comments for ease of grepping
Change-Id: I7f85d931d3b79da23e87b4e5692b2e14be8fcaa0
2024-03-19 20:11:29 +00:00
James D. Forrester
eeb5a740b3 Namespace Message, move to appropriate directory
Bug: T353458
Change-Id: I088cbc53fbcdb974e5b05b45a62e91709dacc024
2024-02-14 15:10:36 -05:00
daniel
6f1f783c77 CommentStore: Force message to be a string
Apparently, we end with the comment text being null sometimes.
That should not happen, and can lead to failures down the road.
So we need to detect and prevent this case early.

Bug: T355751
Change-Id: Ifc91416d297e9a569bc7a2981732e5dd808429aa
2024-01-25 15:02:05 +00:00
James D. Forrester
84157df23b Follow-up f6bd18d: Add in-code comment on aliases for when they were added
Change-Id: I16cd2aba7b353b52359604d0290f9996e6bc0044
2023-08-25 20:54:34 +00:00
Alexander Vorwerk
f6bd18d6c2 Split a base class out of CommentStore
so that extensions (i.e. CheckUser) can implement their own comment
store without having a lot of code duplication

basically the comment store version of I3a6486532f2ef36

Bug: T233004
Change-Id: Ib40f99e00a514d41776ce521baf113e46d37e9cd
2023-01-01 22:34:36 +00:00
Renamed from includes/CommentStoreComment.php (Browse further)