Commit graph

8 commits

Author SHA1 Message Date
Brad Jorsch
3488f49532 Replace selectFields() methods with getQueryInfo()
Several classes have a "selectFields()" static method to tell callers
which fields to select from the database. With the recent comment table
change and the upcoming actor table change, this pattern has become too
simplistic as a SELECT will need to join several tables to be able to
retrieve all the needed fields.

Thus, we deprecate the selectFields() methods in favor of getQueryInfo()
methods that return tables and join conditions in addition to the
fields.

Change-Id: Idcfd15568489d9f03a7ba4460e96610d33bc4089
2017-10-30 22:57:33 +00:00
addshore
7b166db4a8 Revision tests, make test for constructFromRowArray a unit test
Change-Id: I52aa62a442011b612966bb294015730a05702cd3
2017-10-17 22:21:42 +00:00
addshore
ad055bf9cb RevisionUnitTest::testConstructFromArray @covers tags
Change-Id: I3d4b54531ecdb2c29f4669685d9824b6a5e36e4e
2017-10-17 22:21:33 +00:00
addshore
6569685ae5 RevisionUnitTest for fetchFromConds
Change-Id: Ie151123d703933474a52c73beacb0ac70161c241
2017-10-16 17:55:24 -07:00
addshore
f9814f7709 RevisionUnitTest for various getters and setters
getId
setId
setUserIdAndName
getTextId
getParentId

Change-Id: I1890122c0eae16947a4782bc14baa8c3b9ce1391
2017-10-16 17:55:24 -07:00
addshore
720a3569b8 RevisionUnittest for select*Fields methods
Change-Id: I8ec1d35bb5e4706e5cfe72684bcac73c9f3d63cc
2017-10-16 17:55:24 -07:00
addshore
6b060fde36 RevisionUnitTest for userJoinCond and pageJoinCond
Change-Id: I4deb6192e56c6b6eb9c60d0ae3cd3aa472a84af6
2017-10-16 17:55:24 -07:00
addshore
9fe46fdd32 Split Revision tests into Unit & Integration classes
Change-Id: If10b102a1a0d680b5f067bf34c0fafcb59c09048
2017-10-13 14:46:36 +01:00