Commit graph

2 commits

Author SHA1 Message Date
Antoine Musso
da4f37facd Improve PHPUnit code coverage
XmlJs:
 - simple class == simple test

GlobalFunctions:
 - wfArrayDiff2: simple test, please add more

XmlSelectTest:
 - test for constructor
 - tests for setDefault. Found a potential bug when setting a default after
   options have been added. The default option will not get marked as selected!
   We should change our code to generates HTML for options at rendering time
   or throw an exception that default can not be used if an option is present.

MediaWiki:
 - basic placeholder generated by PHPUnit
 - tests for setVal() / getVal()
2011-02-06 13:59:06 +00:00
Antoine Musso
ddd8f91a5b Tests for XmlSelect::addOption()
PHPUnit seems to only accept one class per test file. This patch move the
XmlSelect class to a new file.

It also add some assertions for XmlSelect::addOption(). Please review them
carefully! Although the assertions are fine:
  OK (5 tests, 5 assertions)

I am not sure they are the expected behaviour.
2011-02-05 23:41:29 +00:00