Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.
Change-Id: I6627ba0e76d3577c40bf2473e0f78a5ad7368634
Removed 'Remember my login' from Preferences, as it was unwanted. It adds
to the complexity of the user preferences
Bug: 52342
Co-Author: Tyler Romeo <tylerromeo@gmail.com>
Change-Id: I7c957e1e1aaecf47f7c47bc063b5d3b364644afc
Variants included 'in <version>', 'as of <version>' and just the
version number.
Some @deprecated annotations do not have the version number at all,
I want to hunt them down separately.
Change-Id: I8208c6097098f4735d4f51bc42254675f1f27f6d
This user preference affects the appearance of the site,
so this feels like a natural fit
Bug: 63582
Change-Id: Ib97b1b39723f1835b7f6086ff1418ab5de13a7a1
Added additional check for missing key "realname" in $formData which can cause
an undefined index: realname
Bug: 62029
Change-Id: I6763c12d9b4d8b1e574eb3162168f4f5380df93a
The vector-simplesearch preference is enabled by default since version 1.22.
The option is removed to decrease the clutter in the preference page
Bug: 52815
Change-Id: I6d8dd997a4c4a6b8fb06b4674dda5f306432c6af
This toggle was introduced in 8d06ad6e, but the most useful feature for
human users there (disabling <h1> conversion on a per-user basis) has
been dropped due to cache fragmentation. The only remaining part is not
quite useful and can be covered by the URL parameter &linkconvert=no.
Change-Id: I12f2cdc9b0d44d6e47487b14fa8ef010de5c94a7
Removed the option 'Justify paragraphs' from MW Preferences
as it is not a necessary option there.
Added RELEASE NOTES.
Bug: 52810
Change-Id: I1fe6a5857070828726077e6ba229b786c017c858
The table of contents box is auto-inserted, can trivially be hidden or
exposed on a per-page basis with __MAGICWORDS__, includes a sticky
[show|hide] link, and can be easily hidden with site-wide CSS as
necessary. It needlessly adds complexity and user interface clutter.
Bug: 52813
Change-Id: If2139317dae4aa980b373c73d7b81dac627b5af8
Unwanted user preference option in MW adding to the clutter.
Users interested in hiding section-edit links can use per-user
(or site-wide) CSS.
Removed 'editsection' from Defaultsettings.php and
ResourceLoaderUserCSSPrefsModule.php
Updated Release Notes
Bug: 52811
Change-Id: I5fc49106621943ca7180ddb37590b624edac67d5
It is a very advanced user preference with little usage and is often misleading.
Updated Release Note.
Bug: 52809
Change-Id: I43f6205df53c7a38717c60a2d7d144307feb58a4
It's rarely used and provide more interface clutter and code complexity than
any benefit it provides.
Bug: 52812
Change-Id: I4b1d243b1b1a9da484147c4a682f44aa08a22803
The Line continuation Coding conventions prefers the closing parenthesis
on the same line than the beginning curly braces. This is done for ifs
and functions.
Also move some boolean operator from the end of a line to the beginning
and changed some indentation to make the condition hopefully better
readable.
Change-Id: Id0437b06bde86eb5a75bc59eefa19e7edb624426
There are certain preferences, such as realname and emailaddress, that
are handled specially in Special:Preferences and are not accessible by
User::getOptions or User::setOptions. But action=options was allowing
a 'dummy' version to be set in User::setOptions.
Change-Id: I4c1b3d8e1eae9520228d7b6da9c41ada80f7c387
It is easier in other languages, but in English some worry
about "I prefer not to detail" not being an answer to the
question used as label of the option; parentheses should
be enough to clarify it is about not answering the question
because you don't care.
Also put such (default) "zero answer" first and move feminine
before male as suggested by Jared to avoid any appearance of
bias in the user interface, though the fallback works that way
in the code anyway for merely grammatical reasons.
Bug: 53311
Bug: 53834
Change-Id: Iea77e903c91063a648fff5e4be41c0be51ac172a
* Follows-up b2e2b2e016.
* Minor clean up of surrounding documentation comments.
* Fixed missing keys for messages in WebInstallerPage
Change-Id: Iaa692064262f3c0e10cfa5e4b1ec8c86e5d02362
* Move the gender option to the internationalisation section,
because it's mostly used for that.
* Change the displayed values: rather then gender identifiers,
it demonstrates the usage of the option.
* Update documentation accordingly.
Change-Id: I81f02f03f5992ad5f0501e0a7552bdee9f2c1d5e
Bug: 31816
Removed the wpStickHTTPS checkbox from the login form, and instead
just use the user's preferences along with whether they came from
HTTPS or not to determine if they should stay in HTTPS.
Bug: 29898
Bug: 52283
Change-Id: I69e9cb23b8d700e821b8a961c672958e4e19e4f8
Now with the introduction of page language, a site can have pages
in all languages, and different languages have different variants.
This patch allows users to set preferred variants for every page
they may see on the site.
Change-Id: Ie7e82bee0b1f8f902b38bb4a464cf0ebc4df4d89
It has served us faithfully for many years, but now, after most of its
contents have been moved to other tabs, it only contained one section
with two options related to diffs in it. Moved these two as well to
"Appearance" tab where they rightfully belong.
Also moved some code potentially adding items to the personal/i18n
section out of the misc part and to the personal part, where it should
have always been in the first place. (This actually appears to be dead
code, as $extraUserToggles doesn't seem to be defined for any language
- marked as FIXME.)
The Preferences::miscPreferences() function doesn't do anything now,
but kept it and its only call just in case for backwards-compatibility.
Bug: 52084
Change-Id: I537abc9884e18acf3ff9a425241de4607dfd7c33
This preference does not appear to have a valid purpose. Jump links are
part of accessibility, sites must never force users to turn this on.
For logged in users there is no value in removing the links. They take up
practically no space in the markup, and that would be a dubious reason.
And these links are not even visible so users should have no reason to be
bothered by them.
Change-Id: Ib506ffad41ac7f65629368bc41774fb689b882db
Those variables are only used when $canViewPrivateInfo is true;
so no need set them when it is not the case
Change-Id: I87a27ea94f3eadc757b6e6048437a7ec58d09d03
Do not allow the user to change it directly; instead create a form
where they can reset it. (The token can still be changed via the API.)
The token is autogenerated whenever it is shown or otherwise used.
This really should have never used the preferences; however, trying to
change that now would be lots of work for very little gain, so this
keeps using that mechanism, adding a little abstraction over it.
It's not unconceivable that similar tokens could be used for other
pieces of data, like Echo's notifications; this enables that with one
new hook.
----
Things done here:
* Add getTokenFromOption() and resetTokenFromOption() methods to User,
abstracting out the get-and-generate-if-empty process of handling
tokens. Respect $wgHiddenPrefs (Watchlist didn't do that
previously).
* Create Special:ResetTokens, inspired by Special:Preferences and
Special:ChangeEmail, presenting the token resetting interface
(HTMLForm-based with CSRF protection).
* Create a new hook, SpecialResetTokensTokens, allowing extensions to
register tokens to be shown in the resetting form. Each token needs
information about the preference it corresponds to and a short
description (used for checkbox label).
* Hide the preference on Special:Preferences (use type=api to achieve
this), display a link to aforementioned special page instead. Move
info blurb to its own section at the bottom.
Bug: 21912
Change-Id: I0bdd2469972c4af81bfb480e9dde58cdd14c67a8
Added a MWTimestamp::format method to format a timestamp object in the
given pattern. This avoids date(), which needs the local time
zone corretly set on the server, which is assumed at the moment in
Setup.php
Added MWTimestamp::getInstance for gmdate() and
MWTimestamp::getLocalInstance for date() to create a MWTimestamp object
and use it as inline statement.
Also MWTimestamp::setTimezone and MWTimestamp::getTimzone was added for
timezone handling.
Change-Id: I812aa013be2f4380e0cf10dc465202756fe8347b
These are needed for OAuth grants.
Note that we don't bother with a 'viewmyoptions' right, since the
majority will be determinable from just observing the interface.
Note that the fact of having a confirmed email address cannot be
reliably hidden, and if the user has 'sendemail' they may be able to
determine the real name and email address by sending an email to another
account that they control.
Change-Id: I3f03dd010020e8d43cc2d3bca7b3ef7196d1c548
Arange the settings in three groups: How to call the editor, how
the editor looks and how the preview works. The only toolbar
preference is at the bottom because the WikiEditor extension adds
its stuff there. All the preferences are untouched. This does not
add or remove a preference.
Goes with Id8b9a47a in the WikiEditor extension.
Change-Id: I429c8125b8db789d2756d61249f6cf1fa7f2f51c
Follow-up to change 65426 (commit a3c7a8b8f)
Also, rewrite the documentation for this function call in Preferences.php
To remove the "(skins is all skin names from Language.php)"
which I couldn't make sense of.
Change-Id: I0b0fdfb5615c22aa876882c3ca344ebb1f10c4bd