Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
118325 commits 1 branch 0 tags 744 MiB
Commit graph

15 commits

Author SHA1 Message Date
James D. Forrester
ad06527fb4 Reorg: Namespace the Title class 
This is moderately messy.

Process was principally:

* xargs rg --files-with-matches '^use Title;' | grep 'php$' | \
  xargs -P 1 -n 1 sed -i -z 's/use Title;/use MediaWiki\\Title\\Title;/1'
* rg --files-without-match 'MediaWiki\\Title\\Title;' . | grep 'php$' | \
  xargs rg --files-with-matches 'Title\b' | \
  xargs -P 1 -n 1 sed -i -z 's/\nuse /\nuse MediaWiki\\Title\\Title;\nuse /1'
* composer fix

Then manual fix-ups for a few files that don't have any use statements.

Bug: T166010
Follows-Up: Ia5d8cb759dc3bc9e9bbe217d0fb109e2f8c4101a
Change-Id: If8fc9d0d95fc1a114021e282a706fc3e7da3524b
 2023-03-02 08:46:53 -05:00
Derick Alangi
8eb423c4dc Use CommentStore service instead of deprecated method 
Also, added a parameters to XmlDumpWriter so that they could be
inject via WikiExporter.

Bug: T325475
Change-Id: I84b82506509e2c09dad0691af2df958a5af5b5b0
 2023-01-04 23:50:51 +00:00
Alexander Vorwerk
f6bd18d6c2 Split a base class out of CommentStore 
so that extensions (i.e. CheckUser) can implement their own comment
store without having a lot of code duplication

basically the comment store version of I3a6486532f2ef36

Bug: T233004
Change-Id: Ib40f99e00a514d41776ce521baf113e46d37e9cd
 2023-01-01 22:34:36 +00:00
Umherirrender
de6582d861 logentry: Make use getUnknownActor visible in getPerformerIdentity 
Move the call to ActorStore::getUnknownActor to the code which calls it.
Avoid that static code analyzer see an possible undeclared actor store

Found by phan (T259172)

Bug: T259172
Change-Id: Ide978380726c60a35250ca67cd0adff603c971b1
 2022-03-30 17:26:49 +00:00
lens0021
cf971e0d46
RCDatabaseLogEntry: Stop returning an unknown actor if rc_user is given 
In all cases that rc_actor is not given the function returns an
unknown actor as ActorStore::newActorFromRowFields() throw
exception in that cases. It is too strict because, for instance,
RecentChange::newLogEntry() does not provide the attribute.
This changes it.

Bug: T286979
Change-Id: I5668053c30c18755536bfcb98524e79eb2827dda
 2021-10-23 15:53:07 +09:00
Umherirrender
44fd53fee3 Using @return never documentation on always-throw-function 
This helps phan to detect unreachable code and also impossible types
after the functions.
It helps phan to avoid false positives for array keys
when the keys are checked before

Bug: T240141
Change-Id: I895f70e82b3053a46cd44135b15437e6f82a07b2
 2021-09-07 17:29:03 +02:00
Petr Pchelko
1782bc7fd4 Remove hard-deprecated LogEntry::getPerformer 
Change-Id: Ia2c4819848f5d23d5ceb74aae9c6c5920b8851ba
 2021-06-28 18:06:36 -07:00
Tim Starling
fd01c53778 Stop using legacy ActorMigration field "rc_user" 
Bug: T278917
Change-Id: I4d6c175c637a2cb26c63e0b2b27d5ea8ce6b1e0d
 2021-04-28 16:29:04 +10:00
Vadim Kovalenko
a89ea93bea Deprecate LogEntry::getPerformer in favor of ::getPerformerIdentity 
Bug: T274329
Depends-On: Ide485fb8f9a0a22d2d7fc7a3bbbe458f603db393
Change-Id: I1921ba8586e2d56a9669803532ade5ee2c4c3b56
 2021-03-01 15:27:42 +02:00
Daimona Eaytoy
27346b8cba logging: Document LSP violations in RCDatabaseLogEntry 
- RCDatabaseLogEntry::newFromId currently doesn't work, because the parent has
  'logging' fields hardcoded. Make the failure explicit with a LogicException to
  avoid sneaky failures and/or DB query errors. There's no need to
  implement the missing part, given the lack of a use case.
- Same for ::getSelectQueryData

Change-Id: I748733da1a34f9af1cd431c933809c23dc37a3d6
 2020-07-14 18:38:45 +00:00
jenkins-bot
52f1a3b0e9 Merge "Add doc to DatabaseLogEntry" 2020-06-15 01:21:00 +00:00
Umherirrender
02d827e234 Add doc to DatabaseLogEntry 
See I13b5fd2989f9e640718ecf5083f83017abefef25 for more information

Change-Id: I455ef14b8ee764ab5377fa72afa9c47e32a85ef7
 2020-05-31 20:54:55 +02:00
Umherirrender
cd522341b2 Revert "RCDatabaseLogEntry: add a method to get the last rev_id" 
This reverts commit b96d2808fd.

This class should only be used in context of the LogFormatter and the method is not needed there.

This was added in 1.35 and the revert should be part of 1.35 to avoid deprecation process.

Change-Id: I13b5fd2989f9e640718ecf5083f83017abefef25
Depends-On: I3af1e42594f8235be815ce38e3411c762ae01092
 2020-05-28 18:10:37 +00:00
Daimona Eaytoy
b96d2808fd RCDatabaseLogEntry: add a method to get the last rev_id 
Change-Id: I72290129610245fe7b8f7be0258c0efe8911c242
 2020-01-22 16:45:43 +00:00
Reedy
f032d27d0c Split logging classes to individual files 
Change-Id: I3eaaf23612fe1aed65e49c06a9e5e565399af9ce
 2019-04-14 02:13:47 +00:00