* This puts the complex logic here after the commit step for
all DBs, making the main multi-DB transaction more likely
to be atomic.
* Also fixed the reuseConnection() call by getting a new
handle in the callback.
Change-Id: I449a521423ff13bfbf49bdaa6e7e6df2145c8751
In order to cleanly revert "Allow reset of global services"
which breaks login.
This reverts commit 99e8d45b50.
Change-Id: Iae7f7b7b7083345dd50c313ee68e2e814f130f1a
I have left the phpdocs in NullStatsdDataFactory
to clearly show the return types of the interface
implemented.
Change-Id: I96cb64b4af16fc087028269a53d539f8c132f81c
Adding batches of watched items per users
makes much more sense.
Only the deprecated static WatchedItem method
needed the old silly way of passing in objects.
Change-Id: I90f9583b66bd3b5afcf07faefedb38a8a0149f6e
This method is also no used in SpecialEditWatchlist
Unit and Integration tests have also been added.
Bug: T129481
Change-Id: Ica136b6fee63be8de4c2fe502288dd2318d99114
Adds a method for getting watchlist's notification timestamps
for a batch of LinkTargets.
Bug: T129482
Change-Id: I1f84212e7879a84b34bb3b53859069fcea282bba
This is for batch counting of visiting watchers, following the change
made in I2868c31fc09121de381d822e8f49194e3022bb42.
Query/logic has been extracted from ApiQueryInfo.
Bug: T129482
Change-Id: Ia9a534f5edb7af3cb7bf86be358dddb5d8c259cf
This method counts the number of individual items
that a user is watching.
A subject and corresponding talk page would mean a
count of 2
Unit and integration tests are also added here
Bug: T129481
Change-Id: I4b55318dc1d1c5abab1c5da16cebf1a43ddf9248
Prior to this change in tests the overridden store
would remain in the instance static and thus could
be used in other places.
This patch introduces the used of ScopedCallbacks
in the override methods in WatchedItemStore.
This means that any instance of WatchedItemStore
should return to a regular state after each test.
This is better than requiring the tests to reset
the value back to the origional as this would likely
be forgotten and result in long hunts for failing
tests.
This was found while writing more tests...
Change-Id: I9aa71425642174ae9ea2c6d4f85dcd07d724af11
This query / logic has been extracted from
ApiQueryUserInfo.
Unit & Integration tests have also been added.
Relating to the task linked this is the last change
needed in this ApiQueryUserInfo!
Bug: T129482
Change-Id: I91aa109416c16cd1f257c9de46669e35d6fd34d7
When the notification timestamp for a LinkTarget is
updated all items relating to that LinkTarget should
be uncached!..
This also switches this class from a BagOStuff to
a HashBagOStuff as this cache index is only maintained
per process..
Change-Id: I5dc58e018a6a4a15903abc1e0b326b4220abc75e
This also removes assumptions that when a page
in one Namespace should be watched / removed
that the page in the talk / subject ns for the
page should have the same action applied
This should maintain all backward compatability
for the WatchedItem class
This also includes tests written by:
- WMDE-leszek
- Addshore
Bug: T127956
Change-Id: Iad9abafe4417bb479151a3bfbee6e1c78a3afe3c