Commit graph

566 commits

Author SHA1 Message Date
Siebrand Mazeland
545ecfa121 Fix typo in comment 2009-05-19 23:27:53 +00:00
Siebrand Mazeland
547858b7fe Use link() instead of deprecated makeLinkObj() where possible. 2009-05-08 23:24:31 +00:00
Robert Leverington
2aa0c02088 * Strict Standards: Cannot assign by reference.
Fix for previous commit.
2009-04-09 18:54:15 +00:00
Robert Leverington
4cf686c22c * Strict Standards: Only variables may be passed by reference.
Reference title object to variable before passing as a parameter.
2009-04-09 18:51:45 +00:00
Alexandre Emsenhuber
894650c3f7 * removed useless $wgUser and $wgOut globalisation
* fix for r49324: work arround E_STRICT: only variables should be passed by reference (OutputPage::getTitle() doesn't return a reference but OutputPage::addWikiTextTitle() want one)
2009-04-09 08:53:15 +00:00
Remember the dot
e4d211703c (bug 12998) Allow <sup>, <sub>, etc. in DISPLAYTITLE 2009-04-09 05:15:43 +00:00
Chad Horohoe
d5dd4044e5 Stage 2 of war on $wgTitle!! Make OutputPage, Skin and children rely on mTitle rather than $wgTitle. In theory, you could have an OutputPage/Skin that was referring to some title other than $wgTitle, unlikely though. In any case, make getTitle() return $wgTitle for now, just in case. 2009-04-09 02:22:36 +00:00
Chad Horohoe
2438e56741 Document OutputPage::out() 2009-04-07 18:21:07 +00:00
Tim Starling
43f0ff4469 In OutputPage::addScriptFile(): escape attributes for HTML. No XSS, just good practice. 2009-04-01 08:50:57 +00:00
Arash Boostani
c32a1ef480 Fixed bug #11213 - [edit] section links in printable version interfere with cut-and-paste of article text 2009-03-18 23:27:48 +00:00
Brion Vibber
ae98c49213 * (bug 17537) Disable bad zlib.output_compression output on HTTP 304 responses
Patch by ezyang - http://bug-attachment.wikimedia.org/attachment.cgi?id=5829
2009-03-18 21:26:57 +00:00
Aryeh Gregor
c6be9caca9 Remove more "?>" 2009-03-16 00:36:17 +00:00
Aryeh Gregor
cd99068dbe Avoid "?>", messes up some syntax highlighters 2009-03-16 00:34:46 +00:00
Aaron Schulz
6cd1a1b1d9 * Avoid double output on filecache failover
* XHTML fixes to error html
* Added isDisabled() to OutputPage
* Make sure filecache marks output done
2009-03-13 20:15:16 +00:00
Siebrand Mazeland
f66a0b97b0 * Use $wgLang->commaList( array ) instead of implode( ', ', array ) where possible
* remove a piece of commented out code in SpecialSearch.php
2009-03-08 19:40:09 +00:00
Roan Kattouw
ee408f0789 (bug 17538) Use local URLs in <link>s 2009-02-20 20:49:47 +00:00
Brion Vibber
92079d3b1c * (bug 16335) __NONEWSECTIONLINK__ magic word to suppress new section link.
Patch by Carlin: https://bugzilla.wikimedia.org/attachment.cgi?id=5680
With slight whitespace tweaks.
2009-02-19 22:14:59 +00:00
Alexandre Emsenhuber
f04183b0da Removed check for empty( $action ), seems to be old register_globals code, but since $action is set in index.php with
$action = $wgRequest->getVal( 'action', 'view' );
it can't match empty() in "normal" conditions
2009-02-04 19:43:30 +00:00
Philip Tzou
205ef1ba8b 1. Use param $ignoreOtherCond instead of $forTemplate and $ignoreSubmitCond in findVariantLink().
2. Drop some duplicate categories produced by findVariantLink().
2009-02-02 07:54:43 +00:00
Andrew Garrett
ed8623d113 Allow af_public_comments to be wikitext.
Relatedly, add parseInline function to OutputPage, to avoid duplicating the same awful regex in wfMsgExt.
2009-01-31 01:59:13 +00:00
Raimond Spekking
5f0a8c9561 Revert r46524 per Nikerabbits comment 2009-01-30 16:45:09 +00:00
Raimond Spekking
4b5874d606 Add a newline in front of the message to avoid wrong parsing when the message text starts with line-start-markup such as a table or list.
The missing newline was the real culprit of the breakage seen in http://www.mediawiki.org/wiki/Special:Code/MediaWiki/45651#c1531
2009-01-29 07:01:51 +00:00
Brion Vibber
d542c890ba Roll back r46059, r46062 "(bug 1433) Add meta-information to pages with language links." for now.
Localization issues with the description text should be ironed out first... also test use of rel="alternate" on the main links if that works, could save the extra metadata.
2009-01-27 23:08:02 +00:00
Philip Tzou
5a9c4ca3cb Find variant link of categories, to fix some strange bugs in Chinese Wikipedia. 2009-01-23 09:32:41 +00:00
Danny B
ed085abf00 * + xml:lang 2009-01-23 04:29:40 +00:00
Andrew Garrett
d6cccddf1d (bug 1433) Add meta-information to pages with language links. 2009-01-23 02:11:20 +00:00
Alexandre Emsenhuber
8eeb88abd0 Fix for r45648: only change page title if it's not an empty string (which is the default value) 2009-01-10 19:41:11 +00:00
Shinjiman
128d787c1d follow up of r45642, only set page title when it is not on the special namespace 2009-01-10 19:34:16 +00:00
Shinjiman
7637a89d82 * Fixing the caching issue by using -{T|xxx}- syntax (only applies on wiki with LanguageConverter class)
* Improving the efficiency by using -{A|xxx}- syntax (only applies on wiki with LanguageConverter class)
  patches by PhiLiP
2009-01-10 16:13:44 +00:00
Brion Vibber
d2496f69df Revert r45063 "Move doNothing return check above global declarations"
Change makes the code harder to read by hiding a control statement in the middle of a global declaraction chunk.
2008-12-31 17:56:04 +00:00
Brion Vibber
880d68b28c Pull back r45181 "(Bug 12998) Weaken DISPLAYTITLE restictions (patch by rememberthedot@gmail.com)" for now.
Escaping issues per comment http://www.mediawiki.org/wiki/Special:Code/MediaWiki/45181#c1046
2008-12-31 16:49:38 +00:00
Aaron Schulz
d0aeaa55ff (Bug 12998) Weaken DISPLAYTITLE restictions (patch by rememberthedot@gmail.com) 2008-12-30 12:22:15 +00:00
Aaron Schulz
4c462927ce Move doNothing return check above global declarations 2008-12-27 05:09:54 +00:00
Aryeh Gregor
3aedfc60d7 Revert revert I accidentally committed 2008-12-24 19:08:18 +00:00
Aryeh Gregor
3012280a8b Revert "(bug 16707) Add "rel='next'" link to login page to return to last page"
This reverts commit 22524e7e3a432df722438400581d2d56ea566dc2.
2008-12-24 19:07:03 +00:00
Aaron Schulz
88717159c3 (bug 16707) Add "rel='next'" link to login page to return to last page 2008-12-23 21:30:40 +00:00
Brion Vibber
a4e2060e45 Revert r44801 "Tweaks from profiling"
Mostly seems to be formatting tweaks, loss of useful debug log output, and mysterious unexplained changes.
If some of these tweaks actually are based on profiling data, please provide details, such as "rearranging this call reduces service time from 80ms to 50ms for client cache hits on my machine" or whatever.
2008-12-23 19:39:00 +00:00
Aaron Schulz
eef9a8cdd7 Tweaks from profiling 2008-12-19 09:21:20 +00:00
Brion Vibber
95211ac850 Revert r44271 "(bug 12998) Weaken DISPLAYTITLE restictions (patch by 'rememberthedot@gmail.com')"
Behavior seems a bit hard to predict, as far as what's going to go in the header and what in the browser window etc. Pulling it back for further testing and discussion.
2008-12-10 23:21:28 +00:00
Aaron Schulz
af10d34286 (bug 12998) Weaken DISPLAYTITLE restictions (patch by 'rememberthedot@gmail.com') 2008-12-06 18:00:17 +00:00
Brion Vibber
2d5024f4d7 * Add guard exception in OutputPage::parse() for failure case where $wgTitle is null; that causes a fatal error which doesn't show a backtrace if we don't catch it here.
* Temporarily set $wgTitle while doing article creation/edit updates during XML import. A null $wgTitle as in importDump.php caused a fatal error when special pages were transcluded if they did any parsing via OutputPage::parse()
2008-11-24 01:58:15 +00:00
Chad Horohoe
c875996c57 Bunch of globals laying around and nobody using them. 2008-11-18 21:37:11 +00:00
Alexandre Emsenhuber
252a1bb96a (bug 15835) Added Content-Style-Type meta tag 2008-11-08 15:06:50 +00:00
Siebrand Mazeland
0a9af4a884 Consistent casing for addHTML() 2008-11-06 22:20:29 +00:00
Tim Starling
2b4c3cd654 * Rewrote wfArrayMerge() in terms of array plus
* Two callers of wfArrayMerge() were bugs, both assuming strange and complex behaviour in wfArrayMerge() which has never been present or documented.
* Introduced wfMergeErrorArrays() to remove duplicates from merged error arrays, e.g. from getUserPermissionsErrors().
* Rewrote the remaining callers of wfArrayMerge() to use array plus. It makes the code clearer, assuming the reader knows more about basic PHP operators than GlobalFunctions.php. Considering the two bugs discussed above, this seems like a fair assumption. If you don't know PHP, you shouldn't be writing MediaWiki code.
2008-11-01 23:20:25 +00:00
Brion Vibber
6ff853d8c7 Add HTML <link rel="edit"> alongside the original UniversalEditButton application/x-wiki funky link, per suggestions at http://universaleditbutton.org/Suggestions#Linking_Scheme 2008-10-22 18:07:15 +00:00
Brion Vibber
fb4635600d Back out r42181 "(bug 6179) Actually the log for people who can't edit"
There's no link to the full log; the last entry may not always be very clear. It's also pretty long and technical, filled with crap like:

23:49, 19 October 2008 WikiSysop (Talk | contribs) changed protection level for "Main Page" [edit=autoconfirmed] (indefinite) [move=autoconfirmed] (indefinite) ‎ (hist)

It would probably be more user-friendly to show the comment describing the purpose of the protection... which of course might not have anything to do with the last log entry (which might be "changing expiration date" or something).

Backing out for now...
2008-10-19 23:53:52 +00:00
Aaron Schulz
ea5f05d900 (bug 6179) Actually the log for people who can't edit 2008-10-17 23:25:46 +00:00
Ryan Schmidt
82d9b72bbd * integrating UniversalEditButton extension into core (enabled by default, set $wgUniversalEditButton = false; in LocalSettings to disable) 2008-10-10 01:15:11 +00:00
Andrew Garrett
d71a1a4b48 (bug 15301) Fix up use of actions in display for permissions errors. 2008-10-06 09:16:20 +00:00