Commit graph

672 commits

Author SHA1 Message Date
Daniel Friesen
39ab3cfc9f Implement Message::isBlank and Message::isDisabled.
And while we're at it... update a random assortment of code using wfEmptyMsg to use the new wfMessage class and our exists/isBlank/isDisabled methods.
2011-01-14 10:51:05 +00:00
Antoine Musso
73b63cc778 Fix RFC 5322 'atext'
An additional character was introducted in the RFC 5322 atext fragment.
Spotted with r79924 which send the file as latin1 encoding.
2011-01-10 19:55:30 +00:00
Happy-melon
355717054f Remove ancient deprecated functions:
* Article::getDB(), deprecated in 1.13 (r36334)
* Article::showArticle() - 1.7 (r14809)
* User::SetupSession() - 1.8 (r15823)
* User::isBot() - 1.8 (r15689)
Annotate other deprecated functions with @since <version>
2011-01-06 18:04:04 +00:00
Happy-melon
e6c1611379 More documentation formatting 2011-01-06 15:55:56 +00:00
Sam Reed
58df1dc895 Rest of * (bug 25767) Add userrights properties to allusers and users query lists
Add missing parameter from r79545
2011-01-04 02:06:55 +00:00
Platonides
7846165d81 (Bug 26434) - Generated password from "Create account by email" does not work.
Another consequence of the $ts === 0 from r71751.
Fixed in a more verbose way. Behavior documented in tables.sql
2010-12-27 17:17:45 +00:00
Platonides
575accae58 Revert r75588 and r77381. Block just the tainted pairs of username/passwords until a proper solution for weak passwords is added, hopefully for 1.18. 2010-12-26 22:55:32 +00:00
Niklas Laxström
75393882f7 Reduce debug log spamming, which I assume is related to this line:
1340:	function isBlocked( $bFromSlave = true ) { // hacked from false due to horrible probs on site
2010-12-10 14:44:01 +00:00
Alexandre Emsenhuber
4d19be865b * Converted UserMailer stuff to return a Status object instead of true-or-WikiError
* Made WikiError::isError() compatible with Status objects
* Added Status::getMessage() for backward compatibility

Extensions using WikiError::isError() to detect a failure of UserMailer::send() and realted methods should still work like before
2010-12-04 13:27:05 +00:00
Andrew Garrett
db7616d207 Add disableaccount to User::$mCoreRights 2010-12-02 05:28:36 +00:00
Mark A. Hershberger
a465346c6e random w/s cleanup 2010-12-01 20:22:45 +00:00
Sam Reed
7320879184 Few braces and spaces
Fixing up documentation
2010-11-30 19:06:28 +00:00
Platonides
fdd0e32d02 Use always DatabaseBase::timestampoOrNull for user_newpass_time field, as done in loadFromRow()/saveSettings()
-- línea y las que están debajo serán ignoradas--

M    User.php
2010-11-28 22:44:14 +00:00
Sam Reed
1361d07049 Tweak some documentation 2010-11-28 15:40:15 +00:00
Andrew Garrett
9d8ff9317e Remove isValidPassword check from User::checkPassword. It is hugely annoying to suddenly have the system decide that your password is not strong enough and decide that, as a consequence, you are not allowed to log in anymore. Password strength checking should only be there for changing passwords, not using them! 2010-11-28 03:21:16 +00:00
Sam Reed
be47c0a884 Tweak param documentation 2010-11-21 23:18:52 +00:00
Sam Reed
de3300a49d Clearing up this working copy. Adding a couple of braces 2010-11-16 23:02:08 +00:00
Sam Reed
a54a1ee178 Fixup some more documentation 2010-11-13 00:47:51 +00:00
Platonides
6b1f0fa6d2 Revert r72959 2010-11-08 20:51:15 +00:00
Alexandre Emsenhuber
95580b06ed * (bug 25728) Added $wgPasswordSenderName to allow customise the name associed with $wgPasswordSender 2010-11-07 09:30:42 +00:00
Chad Horohoe
e94995bd90 Per CR, revert r75873. Does not match docs 2010-11-03 13:55:22 +00:00
Antoine Musso
e3af1df354 Fix misinterpration of HTML5 specification for email validation.
Follow up: r75670 (JS), r75682 (PHP)
2010-11-02 20:39:20 +00:00
Chad Horohoe
a31a935e0e Cleanup r49493, r72481: Adding skin to $wgHiddenPrefs disabled the useskin parameter 2010-11-02 20:18:15 +00:00
Sam Reed
c40d38a5be Remove a few more unused variables
Add a couple of braces to unobvious if
2010-10-31 23:19:40 +00:00
Antoine Musso
011d4043a3 Follow up r75627. Implements r75670 in PHP to validate emails.
* Server side validation of email according to an HTML5 specifications provided by Simetrical :
http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#e-mail-state
* This is NOT a fix of bug 959 (which wants RFC 2822 validation)
* Basic unit tests
2010-10-29 22:03:17 +00:00
Philip Tzou
e6c51a4143 1. Revert the complicated redirection I made in r59754;
2. Add more Accept-Language XVO cache name for IE;
3. Use hreflang to specify canonical and alternate links, it's search engine friendly
   when a wiki has multiple variant languages.
2010-10-28 16:58:39 +00:00
Platonides
4fbf6ecfa0 Add feature to block common (weak) passwords.
This closes the hole of passwords hardcoded in r72475,r74213. Also see r75589.
2010-10-27 22:26:39 +00:00
Antoine Musso
f720cbd4a4 Make some wfDebug() messages nicer to look at in debug log file. 2010-10-18 19:56:33 +00:00
Platonides
6e90b27d5a Deprecate User::getPageRenderingHash() as follow-up to r70783. 2010-10-17 17:28:25 +00:00
Sam Reed
6b3b915353 Big attack on unused variables... 2010-10-14 20:53:04 +00:00
Sam Reed
a2589ff8c6 Assignment in loop conditions suck
while ( $row = $dbw->fetchObject( $res ) ) { to foreach ( $res as $row ) in includes

Add some braces
2010-10-13 23:11:40 +00:00
Roan Kattouw
7dcc7872aa When reading an old-style user_options blob, use the default value for any preferences not set in the blob. This'll hopefully fix bug 25416 ($options['editfont'] not set even though editfont is a legit pref) 2010-10-11 14:10:23 +00:00
Sam Reed
2ca24c9de1 Fix comment typo 2010-10-03 18:23:31 +00:00
Sam Reed
22764a53f8 Braces, spaces, and a few unused arrays 2010-09-21 06:55:49 +00:00
Trevor Parscal
0df196f2c6 Fixed bug caused by unset( $this->mSkin ) in User::setOption which was removing the member, not just setting it to null, which would cause errors when later on checking if ( ! $this->mSkin ) such as in User::getSkin. By using $this->mSkin = null instead, the same effect of showing the new skin preference immediately on change in Special:Preferences without causing errors. 2010-09-20 19:04:16 +00:00
Raimond Spekking
5b66949b49 (bug 16574) Allow administrators to temporarily disable the account creation limit for IP addresses: [[MediaWiki:Ratelimit-excluded-ips]] 2010-09-14 08:58:07 +00:00
Andrew Garrett
99357479ea Rewrite User::getSkin, broken in r49493 because requesting the skin for a particular title had the side-effect of changing the title associated with the stored Skin object, causing weirdness like the wrong namespace tabs. 2010-09-06 12:11:57 +00:00
Bryan Tong Minh
a502ecd52e Made user global constants class constants so that autoloader magic can be used. 2010-09-05 13:16:23 +00:00
Chad Horohoe
9e6c7cc8ef Get rid of PHP4-style constructors 2010-08-30 16:52:51 +00:00
Andrew Garrett
aa75a3061b Remove User::getToggles() code, dormant since preferences rewrite over a year ago 2010-08-14 08:46:36 +00:00
Chad Horohoe
83e9916428 Cleanup r70571, more strict checks for getCookie() return values 2010-08-10 13:30:46 +00:00
Platonides
3f4877b1a0 Revert r70533 and the piece of r70501 that it tried to fix. Note and open bug for the issue.
This has been present since introduction of {{#formatdate: }} in r48249 (bug 4582)
2010-08-07 21:21:28 +00:00
Chad Horohoe
aa7b63ce83 Cleanup getCookie() and use it all over the place instead of using $_COOKIE directly 2010-08-06 15:00:43 +00:00
Platonides
121bb4f03e http://www.mediawiki.org/wiki/User:Catrope/Stub_threshold shows us people setting it to insanely large values trying to disable it.
r70433 addressed the UI. Here we proxy its access via a new method getStubThreshold() that disables it if a page of such size cannot be 
created (by an user), so we can serve them parser cached articles again.
2010-08-03 22:32:09 +00:00
Platonides
a9b5c1402c Remove all calls to $wgMessageCache->loadAllMessages()
Deprecated and empty since r52503
2010-08-03 19:15:43 +00:00
Alexandre Emsenhuber
5170726319 * (bug 21503) There's now a "reason" field when creating account for other users 2010-08-01 10:42:53 +00:00
Bryan Tong Minh
d7e6870b8f Made asynchronous upload by URL working, partly. Hid it behind $wgAllowAsyncCopyUploads. If there are no errors then everything works expected; the same if there are unrecoverable errors. User intervention to solve warnings is not yet possible, because $_SESSION is not available in runJobs. This also means that async with leavemessage = false is broken.
Other changes:
* Moved verifyPermissions check in ApiUpload down pending r70135 implementation in the API.
* In User::leaveMessage: append message to end of talk page; add a newline before the heading
2010-07-29 13:53:51 +00:00
Alexandre Emsenhuber
2fcadccbd3 Removed PHP4-ism 2010-07-25 11:26:52 +00:00
Sam Reed
04f68827d0 Removal of unused globals
Removal of one setting of a variable to '', then not using further
2010-07-24 19:11:52 +00:00
Aryeh Gregor
1b1d821d16 Remove 'minordefault' preference completely
See bug 24313.  The preference encourages people to mark changes minor
by mistake, but it's better to have minor changes not marked minor than
non-minor changes marked minor.  enwiki users at [[Help talk:Minor
edit]] seemed to think it was a good idea.  Plus, I'm always in favor of
removing user preferences where possible.

The only likely fallout of note is some bot operators who didn't notice
this suddenly find their bot not marking anything minor.  I doubt it
will cause major problems, though.
2010-07-14 18:50:32 +00:00