Commit graph

10 commits

Author SHA1 Message Date
Kunal Mehta
6e9b4f0e9c Convert all array() syntax to []
Per wikitech-l consensus:
 https://lists.wikimedia.org/pipermail/wikitech-l/2016-February/084821.html

Notes:
* Disabled CallTimePassByReference due to false positives (T127163)

Change-Id: I2c8ce713ce6600a0bb7bf67537c87044c7a45c4b
2016-02-17 01:33:00 -08:00
Marius Hoch
47528dcf6a Fix IP::toHex for IPv4 addresses with a double/triple 0 block
Bug: T97897
Signed-off-by: Chad Horohoe <chadh@wikimedia.org>
Change-Id: I5c0a37be42ae2c5091ead487a6d19f6e0dd89b36
2015-12-18 01:45:59 -08:00
umherirrender
d8821f2b0b Fixed spacing
- Removed space after casts
- Removed spaces in array index
- Added spaces around string concat
- Added space after words: switch, foreach
- else if -> elseif
- Removed parentheses around require_once, because it is not a function
- Added newline at end of file
- Removed double spaces
- Added spaces around operations
- Removed repeated newlines

Bug: T102609
Change-Id: Ib860222b24f8ad8e9062cd4dc42ec88dc63fb49e
2015-06-17 20:22:32 +00:00
Darian Anthony Patrick
a0616269a1 Check for link-local addresses in isPublic
Bug: T102032
Change-Id: Id1b6b9efc2c47a94a1a81cf4479cd756d22a2c80
2015-06-10 12:14:57 -07:00
Chad Horohoe
d7c0a15cb5 Fix most of IPTest to use data providers
Change-Id: I7a41af445549f6688c559adbc5f16bdb428dae60
2015-04-10 09:03:58 -07:00
Chad Horohoe
20ef448bc3 Use PHPUnit_Framework_TestCase in a few utils/ tests
IPTest, StringUtilsTest and ZipDirectoryReaderTest do not
need the extra overhead

Change-Id: Ic05afb1a3a094a57383d483f4e50bd1ed9a183e2
2014-12-29 20:56:47 -08:00
Aaron Schulz
96c5cd8d9b Removed clumsy unused IP::toUnsigned() method
* Also avoid calling ip2long() on invalid addresses in toHex()
* Also use native base_convert() in toHex() for IPv4

Change-Id: I4fe4e1ac3c91edb9812e4c5bd173e4b54e315934
2014-05-31 00:20:27 +00:00
Aaron Schulz
ed6abd6b04 Workaround ip2long limitation
* This was resulting in bogus queries that did ipblock table scans

bug: 60035
Change-Id: Id8f8846e002abcc0010c8706c664db86257786bf
2014-01-17 00:23:49 +00:00
Siebrand Mazeland
3962697cff Break long lines
Fixes CodeSniffer errors/warnings.

Change-Id: I6417072270ec7236ad2412abda6f6afce189f0fd
2013-11-07 18:10:50 +01:00
Siebrand Mazeland
8ba4964fac Move files with tests to reflect the code
Change-Id: I7949457fb1ad056dc3db09b43ecf73bc8a61d5a8
2013-11-07 18:03:04 +01:00
Renamed from tests/phpunit/includes/IPTest.php (Browse further)