Providing the function name is often optional from the php code,
but it is needed for better logging, so make it mandatory and let phan
report issues about this.
Bug: T374546
Follow-Up: I5227f2fa65850ac8c6f620900f22d1f4e7bfd470
Change-Id: I3becd23d3ba9f452a8afd833d509cd907e56ca47
Remove null type hint and related conditional since it would be silly
to bother passing null and nothing is doing so according to code search.
Change-Id: I499aebd50433be8fd242461e86f5f9c69b300afe
This is more convenient for callers since they can avoid the pattern
of setting $fname to __METHOD__ and needing $fname in the "use" clause.
This is also more consistent with AutoCommitUpdate/AtomicSectionUpdate.
Remove @since tags from @internal MWCallableUpdate class.
Change-Id: I67c58897dc366a55f43e0a61d56064b26d520c17
In prep for the next decoupling commit:
* Rephrase introduction to state what its actually for in practice.
* Remove mentions of implementation details in favour of inline
comments, especially stuff relating to databases.
Except for 1 thing, every integration with databases is already
fully decoupled.
Automatic cancellation on rollback works by having the caller pass
on an IDatabase object to addCallableUpdate() for that specific
update, which works even if it came from an unknown LBFactory
or unknown service containter.
Oppertunistic execution is triggered by service wiring, where
MWLBFactory takes responsibility for having LBFactory notify the
DeferredUpdates singleton; not the other way around.
Bug: T265749
Change-Id: I048d22ffe2fa3838d9a5f4aa4128c756185a6b2e
This is useful for updating a secondary database based on a
commit to the main one, especially for using auto-commit.
Change-Id: Iad9084d2fb0490ecdfd5fcc97db33bfbcbfa5d21
