Commit graph

12 commits

Author SHA1 Message Date
Bartosz Dziewoński
ee5af95167 HTMLForm: Use OOUI\Element::configFromHtmlAttributes instead of rolling our own
Depends on I0e5c956b9358b510c8473b1cfe6465ea1b5c07ef in OOjs UI.

This mostly reverts dd04b31052 and parts
of e85bd04bcd.

In addition to cleanup, it fixes bugs in HTMLFormFieldWithButton
(which did not add some attributes in OOUI mode) and HTMLMultiSelectField
(which did not do the mapping, losing some attributes in OOUI mode).

Change-Id: I0d1a5288e9edb73a0c3a8431feca9fcc67b72b6a
2016-03-09 00:08:05 +00:00
Kunal Mehta
6e9b4f0e9c Convert all array() syntax to []
Per wikitech-l consensus:
 https://lists.wikimedia.org/pipermail/wikitech-l/2016-February/084821.html

Notes:
* Disabled CallTimePassByReference due to false positives (T127163)

Change-Id: I2c8ce713ce6600a0bb7bf67537c87044c7a45c4b
2016-02-17 01:33:00 -08:00
Glaisher
a2ea9f8b92 Make mediawiki.special.pageLanguage work again
Broken with the switch to OOUI.
This also adds 'id' param to OOUI HTMLRadioField.
Follow-up to b51076a844.

Change-Id: I69c5fa9830a8b8b7cd6bf3468b5600325d34c070
2016-01-26 12:12:49 +00:00
Florianschmidtwelzow
46ab7a8290 HTMLRadioField: Use another variable for the radio value to avoid conflicts
$value is used in a foreach loop to build the radioselect fields array for OOUI,
but $value is also the variable, which holds the default value for the element
(or a value, which ws submitted by the user), to pre-select the correct radio input
field. That results in the problem, that $value will always contain the last data,
which passed the foreach loop, and always the last radio input field will be pre-
selected, no matter, what the developer defined as the default or what the user
submitted in a prior form instance.

Change the variable used in the foreach loop to avoid this conflict.

Change-Id: I36c760be8ccd86e75249c966f697b499576c83d4
2015-10-28 18:55:07 +00:00
Bartosz Dziewoński
0355870e78 OOUIHTMLForm: Implement HTMLRadioField
Example usage in I2c3d6486e09b3e4d5537b95194e178fd73ac9792
(Special:PageLanguage). Trivial now that we have RadioSelectInputWidget
in OOUI (added in fd2815e372f6a4beb4f4e5f2a7d9cbf785d40851).

Depends on If68f04a2fa20e7c03763898ab80cf39b5e6cb182 in OOUI.

Bug: T98855
Change-Id: I224e591e58534c07af62eebb9ae4b185225edc33
2015-06-27 13:38:04 +00:00
jdlrobson
60e9f3159e Enable mw-ui-radio styles on Special:Preferences
This makes the styling of the mobile version of Special:Preferences more consistent
http://localhost:8080/wiki/Special:Preferences/skin?useformat=mobile

Change-Id: I67aaf1bf5e0e2eaccf948ecacd1860e6e3b31b04
2015-03-04 11:59:10 -08:00
umherirrender
dcf6955e5c Fixed some @params documentation (includes/*)
Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.

Change-Id: Ifbb1da2a6278b0bde2a6f6ce2e7bd383ee3fb28a
2014-04-20 23:33:05 +02:00
Brad Jorsch
5f57d5d657 HTMLForm: Clean up 0 handling
PHP, particularly with in_array, really has problems with integer 0
versus non-numeric strings. Let's clean that up by converting values to
strings more agressively and using the $strict option to in_array.

Oddly enough, the one place where strict in_array was being used already
broke when If4175332 stringified the values in one array but not the
other.

Bug: 62268
Change-Id: Id34e654eb8d0e70d093b11445273e542e491e265
2014-03-05 15:40:48 -05:00
Brad Jorsch
f88fcb7461 HTMLForm: Allow i18n of 'options'
One shortcoming in HTMLForm is that fields that use the 'options'
parameter (e.g. <select>) have no easy way for the individual labels to
be localized.

This change adds a new parameter type, 'options-messages', where the
keys are message keys rather than bare strings (similar to the
difference between 'label' and 'label-message'). It also abstracts out
the fetching of the various option parameters, and changes the necessary
field classes to use it.

Change-Id: If4175332405d26c7ff2e8fbe100bcad61762ce6f
2014-02-19 23:26:23 +00:00
Alexandre Emsenhuber
cb9a9a7b47 Add support for "tabindex" in HTMLFormField subclasses
It is already set for some fields in Special:Block, but are
discarded by HTMLForm and its fields.

Some notes:
- fields with multiple inputs (radio, select and other, select
  or other) will have the same tabindex set on all elements
- Some items such as multi-select and check matrix are not yet
  implemented

Change-Id: I3e1ba7f16f3a3183f231afcf60dd392ce6d6eb6b
2014-01-25 04:31:01 +00:00
addshore
8fa2314b2e Formatting fixes in includes/htmlform/*
Change-Id: Iee9e4f3fcf8491022ffe97c74312871f97f8ce9c
2013-12-09 14:23:05 +01:00
addshore
976276338a Split includes/HTMLForm
Change-Id: I6eabfdb064c0e35b69efe9d6142e94df4128b632
2013-12-08 23:13:56 +01:00