This can happen, when customized $wgImageLimits, but not
the option in $wgDefaultOptions
Notice: Undefined offset: 2 in \includes\ImagePage.php on line 364
Change-Id: I1dbcde8782f239279602f509e5987606af8db241
Added/removed spaces after opening/before closing parentheses
Added a space after a comma
Removed unneeded parentheses in condition
Change-Id: I306091347ccaaf11dee0cdfda3019cb0c12be51b
This happens when a redirect without usages exists
While I am in this section: Use modern Html() function
Change-Id: I1af206ab3a83fb0d09773314bb30db01f557ba07
(bug 43466) If enabled, send a rel=canonical link on every page
indicating the correct server to use. I tested all three callers:
Article, ImagePage and the variant feature in getHeadLinksArray().
Change-Id: I59b7c1d5589825ea390967036190218d5ce2db88
- Removed useless $showLink variable and related check since the variable is always defined to true
- Moved $linktext up so that there's no need to use a temporary variable to modify it
- Moved $longDesc down where it's used
- Change "else { if ( ... ) { } }" to elseif for better clarity
Change-Id: I65dcbb76c7f0a0441a6420e76affe797a3dc9c45
ContextSource::getContext (ImageHistoryPseudoPager): called and $context
is null. Using RequestContext::getMain() for sanity
Change-Id: I0430791a705f42ca3e5d02692070f0fb0dadc897
The combination of $out->addHTML() and the super call cause action=render for
File pages to have the text rendered twice. Wikis get commons descriptions via
action=render, so they were showing the description text twice.
This reverts commit ca13fde652.
Conflicts:
RELEASE-NOTES-1.20
Change-Id: Ib1072fd1d109c0d6706215ccad1413dd72cb201d
This changes action=render on file pages to include the shared image
description (if it exists). The reasons for this are two fold:
*Logically, most users would consider the shared description part of
the content of the page, and not part of the site chrome, so it
should be on action=render
*Foreign file repos use action=render to get image descriptions.
if you use say en.wikipedia.org as your file repo, commons images
get cascasively included, but all their descriptions end up
being the noarticletext message, which is bad. This makes
the shared image descriptions work.
Some notes on the implementation:
* on action=render the div containing the shared description
doesn't have the id that the one on normal page view has.
This is to prevent duplicate ids in the cascading repo scenario.
I added a class so people can identify them if they want, and this
allows people to easily identify the "outermost" shared description
as it would be the only one with the id.
* This doesn't include the "shareddescriptionfollows" message
(which is disabled by default) that would normally separate the
local from the non-local description. I wasn't sure, but thought
that would be considered part of the site chrome.
Patchset 2/3: trailing space/spelling mistake
Patchset 4: rebase
Change-Id: I18bdf29de62526d699740607b5015da4b01fd43d
Instead, show some text explaining that they cannot upload here.
Also remove a linebreak which someone complained about recently.
Change-Id: I92ab8ad5eebcdd38c0d5d9f7bab7d11e5c844586
This shows a warning on the image description page if the image
is animated, but thumbnails won't be. This includes
gif images that are too big, but also svg images that are animated,
and APNG files.
The message used is file-no-thumb-animation, but will also
check for file-no-thumb-animation-<image extension> so that
admins can do per image type explanations. Gif files have a built-in
explanation that is slightly different (Since its do to resolution).
Ideally one would pass the resolution limit to the gif message,
but I couldn't think of a clean way of doing that. (Also might be
complex to explain to user. They aren't used to resolution as a single
number but as a width x height type thing).
Moves isAnimatedImage from ImageHandler to MediaHandler, so I could
safely use it from any handler class.
Change-Id: I42ee11d889e0c41de53d0951f55a4338ca55311d
* Don't do expensive checks for display (for the consistency of the interface)
* Removed the logged-in check and changed it for 'upload' right (as the user need this right to execute the action)
Change-Id: Ie5752e5292a953cbcf81ab665365c3efbd4eba6a
* For some reason, when 404 handling is off, all the links for
$wgImageLimits were still generated but not put into the HTML.
They still triggered convert() calls - 7 times by default.
Change-Id: I0d12c7ec3c02039c1307a1a1d04d1d1cbd44b547
