Commit graph

26 commits

Author SHA1 Message Date
Aaron Schulz
177f13da31 *Remove GROUP BY entirely, not needed since mandatory pr_type filter was added 2007-05-04 16:09:09 +00:00
Niklas Laxström
748c7b46ef * Fix missing and double escaping
* Don't hardcode colons
* Xml functions, fixed broken labels
2007-05-03 14:32:52 +00:00
Aaron Schulz
0e92cd4ed4 *remove useless ksort() call 2007-05-02 17:14:13 +00:00
Greg Sabino Mullane
b8f14ea7ba Add items back to group by clause: breaks all other databases except MySQL :)
If short list truly needed, consider $this->mDb->implicitGroupby()
2007-05-02 00:20:28 +00:00
Aaron Schulz
4944455688 *Remove double-escaping and inconsistent capitalization 2007-05-01 20:38:11 +00:00
Aaron Schulz
a2d8bf4dc0 *Improve size option, "group by" page_namespace,page_title,pr_type only per pr_page,pr_type key 2007-05-01 20:22:51 +00:00
Nick Jenkins
f9619da3f0 Yet more doc tweaks:
* Add @addtogroup tags to various classes, to try and group conceptually-related classes together.
* Add brief descriptions to various Special pages, thanks to Phil Boswell.
* Moving some docs to be right above the classes they represent, so that they are picked up.
2007-04-20 08:55:14 +00:00
Brion Vibber
64dea25df5 Revert r21250
WebRequest::getText() is for user-supplied freeform text input for which input transformations may be required (eg Esperanto x-coding).
These two variables are not freeform text inputs, but predefined internal text keys selected by a drop-down menu.
Use of getVal() is correct.
2007-04-18 19:28:15 +00:00
Aaron Schulz
ab0904647d *Minor cleanup 2007-04-13 17:48:53 +00:00
Nick Jenkins
113bb1c772 Documentation tweaks to help documentation systems (Doxygen + PHPDocumentor)
pick up the appropriate tags, and documentation blobs for classes. This is 
the same as per r20769, but with the grouping changes (e.g. removing "@{{") omitted.
Please be advised that more related documentation tweaks may follow later - e.g. 
Doxygen generates a log file of warnings that is 574 Kb in size, when run over 
the just the trunk/phase3 code ... eek! Thankfully, much of that is just 
whining about functions without documentation   ;-)
2007-04-04 05:22:37 +00:00
Brion Vibber
3a6ac5a3c3 Revert r20769: we don't use PHPDocumentor anymore, we use doxygen.
If making mass changes to tweak to its preferences, probably better to do it for the tool we actually generate docs with. :)
2007-03-28 14:16:43 +00:00
Nick Jenkins
5fef2333d4 PHPDocumentor [http://en.wikipedia.org/wiki/PhpDocumentor] documentation tweaking stuff.
Minor doc tweaks to prevent some PHPDocumentor warnings or errors when run on the includes/ directory. PHPDocumentor uses a syntax very similar to javadoc - mostly we already use this, but there were a few scattered places that were adjusted to make them consistent with the rest of the code. In practical terms, these changes were made:
* @url becomes @link
* @fixme becomes @todo
* HTML tags in descriptions must be closed / balanced.
* @bug was removed (where the bug was long fixed), or changed into a @todo (in the few situations where the bug was still pending)
* @obsolete becomes @deprecated
* Things like "/**@{{" and "/**@}}*/" which cause "unknown tag" warnings were removed
* @access must be a valid access level.
* @desc tag not needed, removed.
* Doesn't seem to like @licence, will accept @license however.
* Use full comment block notation in a few places (i.e. open block with "/**", start each line with " *", and end block with " */")

Then additional to this, to get some class docs associated with their respective classes:
* Moved some docs to right above those classes (deleting blank lines, or moving descriptions from the file headers)
* Marked some classes without docs as "@todo document"
* (done up to "class MIMEsearchPage" on the "classtrees_MediaWiki.html" page for the includes/ directory)
2007-03-28 08:53:02 +00:00
Aaron Schulz
77a9a35c78 *Instead of sorting on size, add a min size option to preserves the time-order 2007-03-21 21:07:15 +00:00
Aaron Schulz
b9e0875a71 *Default selected type to 'edit' 2007-03-21 20:06:45 +00:00
Greg Sabino Mullane
3664cf04d8 Add all terms to group by, although I'm not sure about the previous commit as it kind of negates the whole purpose of adding the pr_id column. 2007-03-21 18:54:50 +00:00
Aaron Schulz
1996108708 *Show page_len and sort on that index (descending). This should improve the signal:noise ratio on large wikis. 2007-03-21 18:29:31 +00:00
Aaron Schulz
f71f29767b *Use is_null() for namespace 2007-03-21 09:48:26 +00:00
Aaron Schulz
3922ee49d1 *Add namespace filter to protectpages (bug 9326), type and level added too 2007-03-21 09:43:21 +00:00
Greg Sabino Mullane
d94145ce51 Attempt at fixing 9103: needs testing on mysql site with many protected pages, as mysql is funny about group by stuff. 2007-03-19 14:57:57 +00:00
Brion Vibber
8aaf699bf9 Remove <hr>s added to some 'empty' list messages in r20019:
* they're ugly since there's no text above them
* they're invalid XHTML since they are not closed
2007-02-21 17:47:48 +00:00
Raimond Spekking
899967e703 * (bug 8919) Suppress paging links and related messages where there are no
rows to list for query pages
  Based on patch by Sui Min
2007-02-21 10:42:04 +00:00
Andrew Garrett
395c11b04f Fix up Special:Protectedpages to use a ReverseChronologicalPager, and the new pr_id field like it should. This will improve performance, optimise, and make the data real-time as opposed to cached. 2007-02-15 11:16:42 +00:00
Andrew Garrett
b2177cc7c9 Make this query slightly less crack-headed. Rewrite with a Pager subclass coming soon... 2007-01-24 04:45:10 +00:00
Andrew Garrett
698095516a Make my last three commits interoperate (display protection expiry on Special:Protectedpages). Message slightly changed (brackets removed) so I've updated the translation so kindly provided by Rotem :-) 2007-01-22 08:57:40 +00:00
Andrew Garrett
957839573b * (bug 4133) Allow page protections to be made with an expiry date, in the same format as block expiry dates. Existing protections are assumed to be infinite, as are protections made with the new field left blank. 2007-01-22 08:26:41 +00:00
Andrew Garrett
82182d83ff New special page, Special:Protectedpages, which shows all protected pages and their protection status (full protection status is not pulled out due to performance considerations, so it just shows "full protected" or "semi protected". 2007-01-22 05:01:37 +00:00