The legend is not part of the ChangesList itself, but a part of the
ChangesListSpecialPage; move around modules and calls appropriately.
Followup to I02f2ced4.
Change-Id: I2c8922135404aab1960158cee06e2d8d07a1ace7
DELETED_ACTION is supposed to hide the target of the log entry. But a
few places weren't doing this properly.
This fixes:
* API list=logevents no longer returns the pageid when the target is
hidden.
* Enhanced RecentChanges no longer includes the log target page in the
CSS class. This should also make the CSS class actually useful.
* Watchlist no longer shows log entries with DELETED_ACTION unless the
user has deletedhistory, and with SUPPRESSED_ACTION unless the user
has suppressrevision.
Bug: 58699
Change-Id: I57f13bfc970a33ffd5a399ffb450d9ed0b77902f
* Document class property type
* Update documentation and doc formatting
* Ensure variables are defined
Change-Id: I0c7db08d27ac807e989b626c36e72ae52be85d52
For consistency with SpecialRecentChanges.
This introduces no incompatibilities as PHP classes are case-insensitive.
Change-Id: I5855074deed52fd7492f033c8a8fced8af647602
Some of the code added here is duplicated, redundant or would be
better off placed somewhere else. I know about this, but this is not
the time to fix that (and nobody would review such patches anyway…).
Bug: 52005
Change-Id: I02f2ced42f33649b6c972d35a4739372ca265e10
This affects Watchlist, RecentChanges and RecentChangesLinked.
A <div class="mw-changeslist-empty" /> is already used on all of these
when the list isn't generated (somewhat inconsistently coded, though).
Bug: 8844
Change-Id: I1ab2a54e22f318713c2211d63b29c184751a3589
$cachedEntry gets set with baseRC, so baseRC timestamp is the
same as $cachedEntry timestamp.
Doing things this way makes it more feasible to split out some
of the change formatting code.
Change-Id: I1cae6174c827802d525bb95ed152c64008ce7360
Used in SpecialRecentChanges, ChangesList and SpecialWatchlist to keep
track of line numbers for RC list entries.
Change-Id: Ib0e76a325c36a5c019db8d55c150e3bf3bf1d19b
All are referenced directly outside inheritence; declare all public.
Removed unused $mMovedToTitle.
Change-Id: I3ba8f377e1a1082d3a2bb4b043e10bc351c0b5dd
* Define dynamic class properties
* Update documentation and doc formatting
* Ensure variables are defined
Change-Id: I309affea9a8e8cfa24bd8fe694a16bf79d6f2419
All are referenced directly outside inheritence; declare all public.
Removed unused $secureName and $versionlink.
Change-Id: If491d0f1cbf4d53692e0ecfd0e1df1f4c3761ca6
Field is unused since many versions, so remove the use in sql
statements, to allow dropping in a later version.
The field must not be reference from INSERT because it has a default
value, which is used, when no value is specified in the statement.
Keeping the field allows easier rollback on version update, when
something gets wrong with the new version.
Existing Comment in tables.sql was added with r101293, was already
disused in r11088
Bug: 40667
Change-Id: I4a9c2fa813d1f25dfb755e564f7677a212934d7b
newFromUser() is unused in core and all extensions in gerrit,
except BlueSpiceExtensions RSSStandards. (there is a
patch for that I1455052)
Change-Id: I4559146cc0e9973e6e4f6297138cbfd8e387e8b7
On SpecialRecentChanges, the unpatrolled "bang" icon is only
rendered when:
- the user has the patrol right.
- the rc type is EDIT and rcpatrol is permitted, or
the tc type is NEW and nppatrol is permitted.
- the rc event is in fact still unpatrolled.
In other words, when an edit is patrollable and unpatrolled.
However, consumers of the API are unable to render this because
the API only has a boolean "patrolled" attribute. Apps using
the absence of "patrolled" and presence of "patrol" right as
meaning "unpatrolled" get into trouble on wikis with RCpatrol
disabled and NPpatrol enabled. In those cases the app would
render a change as unpatrolled, but when the user clicks it
find out it can't be patrolled.
This adds an "unpatrolled" flag that does just that.
Change-Id: Ic947c6c75eb7936fcebdccbcd27ff62e07f1feda
