Commit graph

13 commits

Author SHA1 Message Date
Bartosz Dziewoński
2ec4ed4711 Changes list legend modules cleanup
The legend is not part of the ChangesList itself, but a part of the
ChangesListSpecialPage; move around modules and calls appropriately.

Followup to I02f2ced4.

Change-Id: I2c8922135404aab1960158cee06e2d8d07a1ace7
2014-01-16 19:26:43 +01:00
Brad Jorsch
8bbf41ec84 SECURITY: Fix RevDel log entry information leaks
DELETED_ACTION is supposed to hide the target of the log entry. But a
few places weren't doing this properly.

This fixes:
* API list=logevents no longer returns the pageid when the target is
  hidden.
* Enhanced RecentChanges no longer includes the log target page in the
  CSS class. This should also make the CSS class actually useful.
* Watchlist no longer shows log entries with DELETED_ACTION unless the
  user has deletedhistory, and with SUPPRESSED_ACTION unless the user
  has suppressrevision.

Bug: 58699
Change-Id: I57f13bfc970a33ffd5a399ffb450d9ed0b77902f
2014-01-13 22:20:09 -08:00
Siebrand Mazeland
84e69f75b3 Various fixes for EnhancedChangesList
* Document class property type
* Update documentation and doc formatting
* Ensure variables are defined

Change-Id: I0c7db08d27ac807e989b626c36e72ae52be85d52
2013-12-30 17:48:14 +01:00
Bartosz Dziewoński
a9e0c52c06 Make legend on Special:RecentChanges and Special:Watchlist collapsible
Some of the code added here is duplicated, redundant or would be
better off placed somewhere else. I know about this, but this is not
the time to fix that (and nobody would review such patches anyway…).

Bug: 52005
Change-Id: I02f2ced42f33649b6c972d35a4739372ca265e10
2013-12-18 17:40:03 +01:00
Bartosz Dziewoński
48cc8109c8 Wrap changes lists in <div class="mw-changeslist" />
This affects Watchlist, RecentChanges and RecentChangesLinked.

A <div class="mw-changeslist-empty" /> is already used on all of these
when the list isn't generated (somewhat inconsistently coded, though).

Bug: 8844
Change-Id: I1ab2a54e22f318713c2211d63b29c184751a3589
2013-11-26 23:13:51 +01:00
aude
322ecffcd1 Create cachedEntry after processing change block
Change-Id: I8b6b85104f15eb8325abace9b0a0653e16d748b9
2013-11-26 12:37:38 +01:00
aude
8f22e5eda0 Get date in EnhancedChangesList::recentChangesLine from baseRC
$cachedEntry gets set with baseRC, so baseRC timestamp is the
same as $cachedEntry timestamp.

Doing things this way makes it more feasible to split out some
of the change formatting code.

Change-Id: I1cae6174c827802d525bb95ed152c64008ce7360
2013-11-26 11:39:59 +01:00
jenkins-bot
166bba1443 Merge "EnhancedChangesList: Add missing </td></tr>" 2013-11-23 20:25:25 +00:00
Bartosz Dziewoński
7a98f64b84 EnhancedChangesList: Add missing </td></tr>
Add closing </td></tr> tags for "title" of changes list row.

Change-Id: I5500b23bf35f302f0410b6fca3e4d02c490752f9
2013-11-19 20:09:00 +01:00
Siebrand Mazeland
0470a55b77 Update formatting
Change-Id: I7586c4d50f7332c515b8377749c4250cc9e04d83
2013-11-19 06:32:18 +00:00
Siebrand Mazeland
511d594bf6 Address CodeSniffer errors and warnings
Change-Id: Ie119db7d6d9e9eb3c1cd9c07b8f84fd155847c62
2013-11-19 06:28:51 +01:00
aude
9f1163edc8 Improve variable naming in EnhancedChangesList
Make clearer when we are dealing with an RCCacheEntry
vs. ordinary RecentChange object.

Change-Id: Id9342b033d46b9b700bd021c451d6f817cd25845
2013-11-08 14:27:47 +00:00
aude
761b880e98 Split changes list classes into separate files
Having them separate improves readability of the code
and makes it easier to work with this code.

Change-Id: Ic6aaf1ace3640f66ad41c2d85b4f7d740b259e0c
2013-10-19 14:26:27 +00:00
Renamed from includes/ChangesList.php (Browse further)