Commit graph

20 commits

Author SHA1 Message Date
daniel
fed7f0b179 Remove $actor field from UsererIdentityValue
Code that needs to store an actor ID in the database to
represent a UserIdentity, or needs to construct a UserIdentity based on
an actor ID loaded from the database, should use the ActorNormalization
service.

Note: The getActorId() method is removed from the UserIdentity interface,
but all concrete classes continue to support it for now.
UsererIdentityValue::getActorId() is hard deprecated and should
be removed in 1.37. It always returns 0.
User::getActorId() is not deprecated at this point.

Bug: T274179
Depends-On: Id2b3ddf6a2a7cdf90f8936a69148d2cce6fde237
Change-Id: I9925906d11e47efaec3c1f48d5cb3f9896a982c1
2021-04-13 18:18:06 +00:00
jenkins-bot
92a415a7d1 Merge "Remove constructors from test classes" 2021-03-11 09:56:01 +00:00
daniel
806792281f ActorNormalization should require a DB connection.
ActorNormalization should only be used in contexts where a DB connection
is already being used, or at least easily available.

Bug: T276986
Change-Id: Ie8aadaffa4a30e63fcad0502d45b8ec364fc79ef
2021-03-10 21:43:49 +01:00
DannyS712
24afc63e49 Remove constructors from test classes
Tests should put their setup code in ::setUp(),
rather than __construct

Change-Id: I622f017f3c78a72acc65310f37d61dbec2a5da79
2021-03-08 03:31:25 +00:00
Cindy Cicalese
2d302a936e Hard-deprecate IDatabase parameter for UserIdentity:getActorId()
Bug: T273576
Change-Id: I0df4a2749afae74671dc4c49bac4e18309677703
2021-02-17 12:51:02 -05:00
Peter Ovchyn
e7e0db5b34 Hard deprecate RevisionStore::newMutableRevisionFromArray
Bug: T272560
Depends-On: I171537c3346a7dd4aeb4fc612d7dd9fba5d64679
Change-Id: If8d079a5d0e9bc9103cf4a6893a9c961d2728534
2021-02-03 22:29:44 +00:00
Gergő Tisza
16c192f2af
Normalize IP addresses before writing/reading actor.actor_name
This was almost always happening already but handling it in
ActorMigration is less fragile.

Also recover some lost tests.

Bug: T272225
Change-Id: I24c82cfbd40595e79f64c6b0441c2cf789cfbbff
2021-01-26 22:56:30 -08:00
DannyS712
9b643b639d Remove hard deprecated PageArchive::undelete
Also fix alphabetization in release notes

Bug: T248192
Change-Id: I41c13b20d31aa75d86783a77a0a263b647a050c5
2020-08-26 23:45:06 +00:00
DannyS712
0637d80572 Hard deprecate the rest of the Revision class
Bug: T246284
Change-Id: I126d7892c90aa2200c668b5717820e729613bed8
2020-07-02 09:02:02 +00:00
addshore
959bc315f2 MediaWikiTestCase to MediaWikiIntegrationTestCase
The name change happened some time ago, and I think its
about time to start using the name name!
(Done with a find and replace)

My personal motivation for doing this is that I have started
trying out vscode as an IDE for mediawiki development, and
right now it doesn't appear to handle php aliases very well
or at all.

Change-Id: I412235d91ae26e4c1c6a62e0dbb7e7cf3c5ed4a6
2020-06-30 17:02:22 +01:00
DannyS712
66f932e93b Tests: Reduce use of Revision objects
Rather than hiding deprecations, where possible use the RevisionRecord
This does not apply to tests explicitly meant to be testing Revision methods

Bug: T246284
Change-Id: Ic3d85a9d451c0c2ab5df35764186e7c383fdabec
2020-06-30 10:56:10 +00:00
DannyS712
dd938a8b5a Add PageArchive::getRevisionRecordByTimestamp
For internal use only
Allows deprecating PageArchive::getRevision

Bug: T249982
Change-Id: I0e10c1b6c7f56af9340f42d58ec4e8699e247be4
2020-06-15 23:02:50 +00:00
DannyS712
d95f663512 Hard deprecate Revision::getTimestamp
Bug: T254966
Change-Id: I90d42eb4e69d7a9ab5c6e0197fbe6979f589ddb6
2020-06-10 16:57:20 +00:00
DannyS712
f8cc519222 Hard deprecate Revision::getPage and ::getComment
Bug: T251853
Bug: T254960
Change-Id: I09fadbebd839a16b46a027f64eaac9a435622321
2020-06-10 04:10:41 +00:00
DannyS712
e36fc3a8dd Remove use of the Revision object returned in WikiPage::doEditContent
Each file's changes are independent and can be reviewed separately

Bug: T251853
Bug: T254952
Change-Id: I197c3db4cfb2ead920c8e6071120ae29543ee404
2020-06-09 23:38:03 +00:00
DannyS712
4194aa928f Hard deprecate PageArchive::getPreviousRevision
Bug: T251718
Change-Id: Id130da00ff22c193f11619bc75bf0f379216ec5a
2020-05-06 20:23:57 +00:00
DannyS712
4721717527 Replace uses and hard deprecate Article:: and WikiPage::getRevision
Bug: T250532
Bug: T239975
Change-Id: Ic8f2baa0ac805d5196a7107bdc7a1abb36eba139
2020-04-20 23:06:48 +00:00
DannyS712
3a46cdccf5 Replace PageArchive::getArchivedRevision with getArchivedRevisionRecord
No known callers outside of core

Bug: T249393
Change-Id: I00434d931f093f605a15d4dc62c97741f551bbf1
2020-04-08 07:48:09 +00:00
DannyS712
1d4df4f221 Hard deprecate Revision::getQueryInfo and ::getArchiveQueryInfo
Bug: T246284
Change-Id: I708f265aac3016e34d02936cf5dff98a3036ef0f
2020-03-26 23:53:19 +00:00
daniel
495323c063 Remove compat code for pre-MCR schema.
NOTE: This was manually tested to ensure it does not
break updates, see T242764.

Bug: T198557
Change-Id: I1d9f5465018bae10124514bc38169e23e0e613e6
2020-03-24 19:45:47 +01:00
Renamed from tests/phpunit/includes/page/PageArchiveTestBase.php (Browse further)