In all cases that rc_actor is not given the function returns an
unknown actor as ActorStore::newActorFromRowFields() throw
exception in that cases. It is too strict because, for instance,
RecentChange::newLogEntry() does not provide the attribute.
This changes it.
Bug: T286979
Change-Id: I5668053c30c18755536bfcb98524e79eb2827dda
This helps phan to detect unreachable code and also impossible types
after the functions.
It helps phan to avoid false positives for array keys
when the keys are checked before
Bug: T240141
Change-Id: I895f70e82b3053a46cd44135b15437e6f82a07b2
- RCDatabaseLogEntry::newFromId currently doesn't work, because the parent has
'logging' fields hardcoded. Make the failure explicit with a LogicException to
avoid sneaky failures and/or DB query errors. There's no need to
implement the missing part, given the lack of a use case.
- Same for ::getSelectQueryData
Change-Id: I748733da1a34f9af1cd431c933809c23dc37a3d6
This reverts commit b96d2808fd.
This class should only be used in context of the LogFormatter and the method is not needed there.
This was added in 1.35 and the revert should be part of 1.35 to avoid deprecation process.
Change-Id: I13b5fd2989f9e640718ecf5083f83017abefef25
Depends-On: I3af1e42594f8235be815ce38e3411c762ae01092
