Commit graph

60 commits

Author SHA1 Message Date
Alexandre Emsenhuber
1d0d879be0 * Document a bit
* Fix some doxygen warnings
2010-01-13 21:25:03 +00:00
Raimond Spekking
7b014c2c17 Fix a Fatal: Call to a member function isLoggedIn() on a non-object in /var/www/w/includes/FileDeleteForm.php on line 115 2009-11-27 17:46:35 +00:00
Matěj Grabovský
4a099928f7 (bug 21455) Fixed "Watch this page" checkbox appearing on some special pages even to non-logged in users 2009-11-14 11:07:46 +00:00
Raimond Spekking
ce47c67697 i18n tweak: Use 'colon-separator' instead of hardcoded colon 2009-11-02 19:06:16 +00:00
Raimond Spekking
90091addcb Partly revert r57148. The search&replace was a bit too wide. It catches a message key too. Instead of right keys only.
Needs syncing with WMF because it shows <deletedhistory> on the live site.
2009-11-02 17:12:37 +00:00
Aaron Schulz
ea1a0e5860 Bolden suppression check label as it is for non-image pages 2009-10-15 10:36:29 +00:00
Aaron Schulz
c2f7ea4d7b * Renamed deletedcontent to deletedtext
* Removed deletedrevision and used deletedhistory/deletedtext instead
2009-09-30 19:50:35 +00:00
Siebrand Mazeland
5adb6cb276 Follow-up to r51559 per CR: initialise $q to prevent PHP notice. 2009-06-07 10:34:02 +00:00
Siebrand Mazeland
88d789e939 * replace some use of deprecated makeKnownLinkObj() by link() in core
* use array type parameter instead of string to escapeLocalUrl(), getFullURL() and getFullUrl() for readability
2009-06-06 22:42:48 +00:00
Alexandre Emsenhuber
8e2e5d473e Fix for r51493, r51084 and realted: use Title::makeTitle() rather than Title::newFromText() 2009-06-05 13:12:15 +00:00
Siebrand Mazeland
e17b75e76a Follow-up to r51084:
* address case sensitivity issue raised by Splarka on CR
* also change to edit link on Special:Block
2009-06-05 07:33:57 +00:00
Siebrand Mazeland
f8f8dd2cb2 Fix a usability issue on protect and [file ]delete forms. "Edit ... reasons" link now contains action=edit to save a click. 2009-05-27 20:35:16 +00:00
Andrew Garrett
0fcc017391 Fix broken calls to ArticleDelete hook. 2009-01-29 01:04:00 +00:00
Raimond Spekking
3fd4899655 Replaced some hardcoded colons with the colon-separator message 2009-01-07 22:49:54 +00:00
Raimond Spekking
f50ac863a2 Fix PHP fatal error in /usr/local/apache/common-local/php-1.5/includes/FileDeleteForm.php line 116:
Regression from r45159
2009-01-01 13:15:29 +00:00
Aaron Schulz
3bfd03128a * (bug 16209) Deleted images are not watched
* Add watchlist check to filedelete form
* Fix XHTML on filedelete form
2008-12-29 18:49:50 +00:00
Siebrand Mazeland
0a9af4a884 Consistent casing for addHTML() 2008-11-06 22:20:29 +00:00
Raimond Spekking
8b83a7cdae * Fix sequence of tabindex
* Use existing CSS classes for label and input
* Break long lines
2008-10-06 16:14:50 +00:00
Chad Horohoe
a7f4aa9152 Add id to file delete confirmation form. 2008-09-18 02:54:27 +00:00
Aaron Schulz
12d279ff91 * Make sure we have the right article ID, not slave lagged. (bug 8072)
* Make FileDeleteForm use hook properly
2008-09-16 17:08:08 +00:00
Aaron Schulz
399956f420 * Remove unneeded code
* Whitespace
2008-09-16 12:47:44 +00:00
Aaron Schulz
79bf4c24ed Rename 'hiderevision' to 'suppressrevision' 2008-05-25 00:31:28 +00:00
Aaron Schulz
03d743a250 Extra sanity check 2008-05-24 23:56:07 +00:00
Alexandre Emsenhuber
087a9f70c5 WARNING: HUGE COMMIT
Doxygen documentation update:
* Changed alls @addtogroup to @ingroup. @addtogroup adds the comment to the group description, but doesn't add the file, class, function, ... to the group like @ingroup does. See for example http://svn.wikimedia.org/doc/group__SpecialPage.html where it's impossible to see related files, classes, ... that should belong to that group.
* Added @file to file description, it seems that it should be explicitely decalred for file descriptions, otherwise doxygen will think that the comment document the first class, variabled, function, ... that is in that file.
* Removed some empty comments
* Removed some ?>

Added following groups:
* ExternalStorage
* JobQueue
* MaintenanceLanguage

One more thing: there are still a lot of warnings when generating the doc.
2008-05-20 17:13:28 +00:00
Aaron Schulz
c682e06086 Make suppression require hiderevision 2008-04-26 23:33:27 +00:00
Siebrand Mazeland
79d5225c0e * remove end of line whitespace
* remove empty lines at end of file
* remove "?>" where still present
2008-04-14 07:45:50 +00:00
Bryan Tong Minh
0c8c6a4936 Show a normal permissionsErrorPage when the user does not have permissions to delete. Statify isValidOldSpec and haveDeletable file to be used by the API 2008-04-04 13:59:04 +00:00
Bryan Tong Minh
a3aeb20e0f Moved file deletion code to a more abstract FileDeleteForm::doDelete 2008-04-04 12:16:50 +00:00
Robert Stojnić
b4dff52409 Suboptimal solution for one of the issues behind bug 12049 (i.e. that
don't get deleted from search index) :
* hooks ArticleDelete[Complete] are now called from FileDeleteForm as well, 
  this seems to be the expected behavior by most extensions (OAI, TitleKey, 
  Rsync, ...).
* delete via API however still misses these hooks

Other possible solutions:
* move hooks into backend - bad since we want a clean backend
* create FileDelete hook (per bug 11276) - seems to me as unnecessary
  duplication of code logic since article might or might not be 
  deleted during file deletion
* make a new Article function and wrap calls - will pollute clean Article
  doDelete and doDeleteArticle calls
2008-04-03 15:09:56 +00:00
Aaron Schulz
441068209b Add showLogExtract() and remove use of FauxRequest hacks 2008-04-02 20:20:47 +00:00
Aaron Schulz
1f60b024de More rev_deleted merging
*Add suppress option to file delete form. Sprinkle in argument where needed.
*Restrict content at sp:undelete
*FileRepo can deal with images in the 'deleted' FS group (corresponds to a setting of oi_deleted)
2008-03-15 00:27:57 +00:00
Raimond Spekking
a7e84474ba * (bug 13274) Change links for messages to ucfirst (relevant for case-sensitive wikis) 2008-03-06 16:52:10 +00:00
Raimond Spekking
8b663c901e * Add links to page and file deletion forms to edit predefined delete reasons
This makes the forms a bit more consistent to special:blockip
2008-03-06 14:59:28 +00:00
Bryan Tong Minh
29248e7a4f Fix description for UploadComplete hook. New hooks: FileDeleteComplete, FileUndeleteComplete 2008-03-01 13:35:01 +00:00
Brion Vibber
8e476b31cc * (bug 12935, 12981) Fully-qualify archive URLs in delete, revert messages
Replaced a bunch of instances of 'if-this-is-not-fully-qualified-prepend-$wgServer' with a function, wfExpandUrl()
2008-02-13 05:59:14 +00:00
Brion Vibber
225250e451 * (bug 12935) Fully-qualify archive URLs correctly in deletion message 2008-02-13 02:31:12 +00:00
Raimond Spekking
067f145b15 * (bug 12919) Use 'deletedrevision' message as content when deleting an old file version
Patch by Alexandre Emsenhuber
2008-02-06 06:01:58 +00:00
Huji
6e604c3e45 (bug 12892) Poor tab indexing on "delete file" form 2008-02-04 17:57:38 +00:00
Brion Vibber
0b01bd4f57 fix html regression: missing id attribute on wpReason input box on deletion forms 2008-01-30 05:36:09 +00:00
Brion Vibber
d214372ecf Cleanup -- fix broken XHTML in deletion forms 2008-01-29 20:23:40 +00:00
Raimond Spekking
4d4f91c3e8 Fix double escaping. Thanks to Nikerabbit :) 2008-01-29 09:17:24 +00:00
Raimond Spekking
b713caf2da * Prettify input form for RTL wikis
* Consistent usage of Xml::functions, code cleanup
* Add a comment to ensure grep will find all used message names
2008-01-29 06:10:12 +00:00
Brion Vibber
1b72addea7 Cleanup for r30216:
* Don't triple-escape HTML in drop-down lists :)
* Don't include empty attributes for missing optional parameters
* Use content language, not UI language, for loading predefined reasons
2008-01-28 20:27:15 +00:00
Huji
da4897cf6d * Renaming Xml::reasonDropDown to Xml::listDropDown to make sure it doesn't imply a special usage.
* Adding support for custom name and id, custom class, and custom tabindex to Xml::listDropDown
* Changing the order of parameters Xml::listDropDown accepts.
* Updating ipblock, file deletion and page deletion forms so they all use this new Xml element rather than holding three copies of similar code.
* Removing variables which are no more used in the three above forms.
* Renaming a few variables to follow the coding style of MediaWiki.
2008-01-28 12:57:02 +00:00
Tim Starling
b0e06a3a46 Fixed broken HTML 2008-01-25 10:15:46 +00:00
Huji
9fe8271672 (bug 12214) Add a predefined list of delete reasons to the file deletion form 2008-01-24 15:35:44 +00:00
Raimond Spekking
a0cb7db00e * Set proper page title for successful file deletion 2007-12-11 16:45:28 +00:00
Brion Vibber
9be2c3676a Revert r26281 for the moment. Big patch, changes several existing practices. Will want some public testing and more review before taking it to trunk. 2007-10-01 19:50:25 +00:00
Aaron Schulz
4febfc77c2 *Clean up deletion of revisions and remove some gaps
*Allow blocking of users to hide names
*Implement revision deletion for images/deleted files/deleted revs
*Log deletion set off for now
*Add 'hidden' file dir
*Dissallow merging via undelete (which was inefficient and hard to reverse)
*Use restore points and diffs to special:undelete
*Add a special page to merge pages
*Get changeslist to use tables to avoid ugly formatting
*Add logs into RC for rebuildrecentchanges.php
*Add private logs
*List private logs at specialpages
*Tweak/add some deletion and merge messages
2007-10-01 19:38:28 +00:00
Rob Church
0d590d699f (bug 11478) Fix undefined method call in file deletion interface 2007-09-28 00:49:44 +00:00