$subpage being null is clearly documented in SpecialPage::run,
SpecialPage::execute, and most special page subclasses.
But all the redirect subclasses only copied part of the typehint,
making it look like it's always a string.
For SpecialMyLanguage, follows-up b1853bba0. Don't cast null to
empty string, and don't bother giving Title::newFromText an empty
string only to bail out with null again.
Also:
* Add visibility 'public' where missing.
* Add or correct relevant documentation comments.
* In SpecialMyRedirectPages, handle error first and avoid having
final return inside a conditional; Remove redunant 'else'.
Change-Id: Ie3543f44011832b198bb3d3e32528b6a2868dee1
This was used in 2 special classes, the logger classes and spread
to a few other random classes.
Afaik this has no meaning. Is for something we don't use, and
goes against the meaning of '@section' in Doxygen, which we do
use.
In Doxygen output, all LICENSE references became links to
ProfilerXhprof (the one Doxygen encoutered first).
Bug: T72328
Change-Id: Icc7c443245c70bc0f549bee7d105eef5691c864d
Reduces code duplication (and some ugly deprecated code patterns in the
Special:Filepath implementation). In the long term, reduces the need for
one-off redirection pages (Special:PermanentLink, Special:Filepath, etc)
in favor of an extensible system based around Special:Redirect.
Change-Id: I42d5879342bc18412f0383c538e83c68b1c3cc2a
Prompted by comments on https://gerrit.wikimedia.org/r/59050
which identified problems with code lifted directly from SpecialFilepath.
Change-Id: Iab8a5d3d007b3aca72b7c6c1145d830a74b4399e
Having all group mapping for Special:SpecialPages in the global
$wgSpecialPageGroups is not a good OO style.
Created a method SpecialPage::getGroupName, which than can be overridden
by each subclasses to the featured group name.
Added also SpecialPage::getFinalGroupName to get the groupname on
Special:SpecialPages to handle the customization and
to keep $wgSpecialPageGroups for b/c
Change-Id: I1de3a186f0a59ec5ecb8996c5f805cf164e9637f
Reverts r43471 which forced Special:FilePath's input to not accept titles with the File: or Image: namespace on them, or otherwise requiring any normalization beyond space/underscore.
Also removes the extra line saying 'input the name without the file: prefix' which used the native namespace name, which prompted a question about its formatting in mixed-directionality contexts.
This is a global search and replace of NS_IMAGE and NS_IMAGE_TALK with NS_FILE and NS_FILE_TALK respectively in all core files, excluding those already updated in step 1 (r44004).
1) This keeps the filename the same as the classname, which is always nice
2) This avoids duplicate filenames (such as includes/Export.php and includes/specials/Export.php)
So I've at least got a chance of figuring out what file is what still...
2008-06-19 21:12:45 +00:00
Renamed from includes/specials/Filepath.php (Browse further)
