This option has been dysfunctional since at least MW 1.32: with
the option set, no tables would be cloned, and all tests trying to
access the database would fail.
Apparently the option was originally introduced to improve speed
when testing against a Oracle database backend in
5933586266.
Since nobody complained about the option being broken,
and we no longer support Oracle, it should just be removed.
Bug: T283146
Change-Id: I7d7f10b2c863ab92279c7817893086ad50e6ac4d
And write release notes for all changes so far.
Note: This should be announced to wikitech-l after merging.
Bug: T90875
Change-Id: I597ed2b5666f4214173609f7e77e23dbc4fd81ae
The class PHPMaintClass is meant to be loaded when running phpunit.php
which is only done when running tests with it. When running tests by
using the bootstrap file only, e.g. in an IDE, this class will not be
available. Relying on it in other classes will therefore break them.
Moving the required parts to another outside class and add it to the
test autoloader. My feeling says, that adding the PHPMaintClass to the
autoloader says "NOOOO", that's why I added a new one.
There also seems to be some CI builds failing because of that:
https://integration.wikimedia.org/ci/hob/quibble-vendor-mysql-php72-docker/30642/console
Bug: T151101
Change-Id: I33e27009657a951173694fc847973560a1ce967b