Commit graph

13 commits

Author SHA1 Message Date
Umherirrender
aa83358172 Pass function name to HttpRequestFactory::create
Useful for logging

Change-Id: Ie1e3f2fefdf65cabd3fcca206e793091b99d3faa
2020-06-07 12:20:06 +00:00
Umherirrender
c7ad21c25f Improve param docs
Change-Id: I746a69f6ed01c3ff000da125457df62b02d13b34
2019-11-28 19:08:59 +01:00
Umherirrender
337ecb0514 Add missing @param and @return to documentation
Change-Id: Ibc5849cc8ea7e7c4eb30ded9c1cfa5f52187c377
2019-11-10 22:12:58 +00:00
Daimona Eaytoy
d3252fc870 Fix new phan errors, part 5
Some of the errors are suppressed because they're phan false positives.
The idea behind this is that they'll be fixed in a future version of
phan, and we'll just have to remove the suppressions.

Note: I'm disabling UnusedPluginSuppression so that we can start suppressing
issues even if they're still disabled. The sniff should be re-enabled
as soon as we upgrade phan.

Bug: T231636
Change-Id: I0f7fa06a9e03fbb86c7a5eb6e50a850bb258a7f7
2019-10-18 20:45:53 +00:00
Daimona Eaytoy
cae0110e5a Fix new phan errors, part 1
First part, mostly doc-only.

Bug: T231636
Change-Id: Id59f585740fa5bfb53c257287121f51a30de38fe
2019-10-11 15:04:04 +00:00
Daimona Eaytoy
19cd15f7cd Fix some phan warnings for too many params (part 1)
Bug: T231636
Change-Id: Ib0ca6bf2c426c21c4d42944c53a219e5940a5f11
2019-10-10 04:44:53 +00:00
Derick Alangi
c51f012739 Use AtEase::quietCall() instead of Wikimedia\quietCall()
Wikimedia\quietCall() is deprecated and AtEase is here for use.
I would have loved to do restoreWarnings() and suppressWarnings()
in this same patch set but will continue the work for a later patch.

Bug: T182273
Change-Id: I43e3a5f378c99b5c40883b35ba133cbd126fc433
2019-06-10 14:18:19 +00:00
Reedy
c13fee87d4 Collapse some nested if statements
Change-Id: I9a97325d738d09370d29d35d5254bc0dadc57ff4
2019-04-04 19:02:22 +00:00
Timo Tijhof
3540897a6f resources: Add caching for faster runs and offline use
Also honour any XDG variables if set (such as Wikimedia CI does)
so that gate jobs can automatically persist the cache.

Bug: T203694
Change-Id: I156af1c5097b8a87be228345fc0a0b80bb3ae338
2019-03-24 20:57:46 +00:00
Timo Tijhof
dd6beafe61 resources: Improve foreign-resources docs and error messages
Previously, the help message was only shown when invoking the script
without parameters. Now, if invoking it with incorrect or mispelled
parameters, it shows what you can do instead (and no more exception trace,
which it did before).

Also document clearly but briefly how to use it, and with examples.

Change-Id: Ib5ba3dc02c54039495a33d6e0cc4d026ca708ba1
2019-03-24 20:57:46 +00:00
Thiemo Kreuz
bb786be640 Add /** @var SplFileInfo $fileInfo */ docs where needed
Change-Id: Ia844af3347db52f9f004892578ba4aefac7dd875
2019-03-14 15:04:05 +01:00
Timo Tijhof
ed5f7a6d27 ForeignResourceManager: Catch responses other than 200 OK
Makes it easier to catch issues like at I839301d05877eb63279c.

Change-Id: I22b9af7bf36a256d8363ed96fe42c087e0c8a895
2019-02-21 23:47:40 +00:00
Timo Tijhof
54bd639467 resources: Extract ForeignResourceManager from manageForeignResources.php
This should make it easier to test, and would also allow other repositories
to create an instance of it in a maintenance script of their own.

Change-Id: I6a28e184f80eb38b5c25a0be5a9041f0c587c852
2018-10-15 03:16:18 +01:00