Commit graph

34 commits

Author SHA1 Message Date
Ammar Abdulhamid
74c0553250 Migrate new_talk to abstract schema
For MySQL
 - Modify user_last_timestamp from VARBINARY to BINARY

For Postgres
 - Drop foreign key on user_id
 - Rename indexes to match MySQL convention

Bug:  T230428
Change-Id: Idc3ded012890d4ace805a646d75cd805b49b250c
2020-10-26 14:10:24 +01:00
Amir Sarabadani
a9dcbe3585 Migrate sites table to abstract schema
For MySQL/Sqlite, using mwtinyint instead of bool, in reality it doesn't
matter since bool is an alias of tinyint(1) in MySQL.

In Postgres:
 - Changing type of site_domain from TEXT to VARCHAR to make it in sync
   with MySQL/Sqlite
 - Renaming all indexes from site_* to sites_* to be in sync with
   MySQL/Sqlite

Bug: T230428
Bug: T164898
Change-Id: Id73bb372807730446901d772fcdbd2f333b397ba
2020-10-22 19:35:39 +02:00
Ammar Abdulhamid
c8e8449caf Migrate watchlist table to Abstract schema
Postgres:
 - Set empty string as default for wl_title to match MySQL
 - Drop foreign key from wl_user
 - Change wl_namespace datatype from SMALLINT to INT to match MySQL/SQLite
 - Drop PG-specific indexes and sync them with MySQL

Bug: T230428
Bug: T164898
Change-Id: Ie996b81ca59069443976b90d7bcdce29997d768a
2020-10-22 15:12:00 +02:00
Ammar Abdulhamid
6599e5706c Migrate querycache_info to abstract schema
Additional changes for Postgres:
 - Set empty string as default for qci_type
 - Set PG-equivalent of the given MySql/Sqlite timestamp as
   default timestamp for qci_timestamp
 - Make qci_type non nullable
 - Make qci_timestamp non nullable
 - Drop UNIQUE constraint on qci_type

Bug: T230428
Bug: T164898
Depends-On: If344395615087c360597a5b3d66ea03e930b7d9b
Change-Id: I741d2d079696d4b4eba09945341054d2a145bddc
2020-10-20 08:18:03 +01:00
Amir Sarabadani
4200969929 Migrate user_groups to abstract schema
For Postgres:
 - Dropping foreign key on ug_user
 - Setting default on ug_user and ug_group
 - Renaming indexes so they would be the same as MySQL/Sqlite

Bug: T42626
Bug: T164898
Bug: T230428
Change-Id: If507d8b8f363016760fe34aac2a0e0a2d99b66aa
2020-10-19 09:01:23 +02:00
Amir Sarabadani
ab8932638a Migrate page_restrictions to abstract schema
Sqlite doesn't need any change as binary/varbinary both turn into BLOB.

For Postgres:
 - Dropping foreign key on pr_page, as all FKs should be dropped (See
   T164898)
 - Add all of indexes, it seems PG was missing all four indexes of the
   MySQL version and didn't have any
 - Changing PK from (pr_page,pr_type) to (pr_id).
  - Had to add changePrimaryKey function to handle such cases, similar
    to checkIndex
 - Set pr_page to not nullable

Bug: T42626
Bug: T164898
Bug: T230428
Change-Id: Ied11f9c2ee633bf5ae325a6c2ea163dcc8d8d3c5
2020-10-19 09:00:26 +02:00
Amir Sarabadani
3d31e8d2d0 Migrate querycachetwo table to abstract schema
Yes, name of that table is really querycachetwo.

For migrating MySQL/Sqlite, changed data type of qcc_title and
qcc_titletwo to varbinary.

For migrating Postgres, just renaming indexes to stay in sync with
MySQL/Sqlite was enough.

Bug: T230428
Change-Id: I43952836ce184419622a6f851cb5e9319172d656
2020-09-26 16:39:53 +02:00
Amir Sarabadani
77f11539c2 Migrate querycache to abstract schema
Turning qc_title to varbinary in MySQL to make it consistent with the
rest of fields.

For Postgres:
 - Setting 0 as default for qc_value and qc_namespace
 - Changing data type of qc_namespace from SMALLINT to INT to make it
   the same with MySQL/Sqlite
 - Renaming index to make it the same with other schemas
 - Setting empty string as default of qc_title

Bug: T230428
Bug: T164898
Change-Id: I81527121609014d29182ae735a2c1f532d7d4d2a
2020-09-26 15:52:43 +02:00
Amir Sarabadani
3db2a91569
Migrate ipblocks_restrictions to abstract schema
Also dropping the fkey on ir_ipb_id in Postgres as approved by RFC T164898

Bug: T230428
Bug: T164898
Change-Id: Iaddec3b9992eee39fe82a45d5bda59bd51cde510
2020-09-22 16:01:45 -07:00
Amir Sarabadani
c0ee12dc86 Migrate change_tag_def table to abstract schema
Also fixing one schema data type drift between MySQL and Postgres
and fixing the problem with booleans, currently DBAL turns "boolean" to
TINYINT(1) in MySQL because it doesn't support it but it leave it like
that in Postgres which in turn breaks it because mediawiki currently
doesn't cast values properly, so for now just turning them to SMALLINT
which is the status quo (See T257755#6335566)

Bug: T230428
Bug: T164898
Change-Id: Ia495a451d51722496942b720a32393f7a6728dee
2020-09-17 10:21:47 +02:00
Amir Sarabadani
be4f90c7be Migrate watchlist_expiry to abstract schema
This takes advantage of custom data type registered in the previous
commit.

Also fixing Postgres drift by dropping the sequence, PK of this table is
not autoincrement so it shouldn't have sequence in Postgres.

Bug: T230428
Bug: T164898
Change-Id: I4c10990ead1e52c979254d2ac6a25ccf62a31508
2020-09-17 10:21:46 +02:00
Amir Sarabadani
b0c18769da Migrate category to abstract schema
In order to migrate MySQL and Sqlite to abstract schema changed the
cat_title data type from varchar binary to varbinary. This wouldn't
affect production.

For migrating Postgres, renamed two indexes from category_* to cat_* to
make it in sync with MySQL/Sqlite

Bug: T164898
Bug: T230428
Change-Id: Iad11aa4f7d809465cb20ac9748bf52b0e1bcd5a4
2020-09-05 20:49:12 +02:00
Amir Sarabadani
cd7a28d30f Migrate iwlinks to abstract schema
In order to migrate MySQL and Sqlite to abstract schema changed the
iwl_title data type from varchar binary to varbinary. This wouldn't
affect production.

For migrating Postgres:
 - Turning the unique index to PK to make it in sync with MySQL

Bug: T164898
Bug: T230428
Change-Id: Iaa625b66c874023b8cf2403917fa2fa120279208
2020-09-05 20:02:43 +02:00
Amir Sarabadani
1770341562 Migrate langlinks to abstract schema
In order to migrate MySQL and Sqlite to abstract schema changed the
ll_title data type from varchar binary to varbinary. This wouldn't
affect production.

For migrating Postgres:
 - Dropping foreign key on ll_from
 - Setting default of empty string for ll_lang and ll_title
 - Make ll_lang and ll_title both non-nullable to be in sync with MySQL
 - Turning the unique index to primary key, similar to MySQL
 - Renaming an index to sync with MySQL

Bug: T164898
Bug: T230428
Change-Id: I57f22896ff67266f99bf08f6dd1b9cc4c51b1db9
2020-09-05 19:29:23 +02:00
Amir Sarabadani
61eaa48f3c Migrate imagelinks table to abstract schema
In order to migrate MySQL and Sqlite to abstract schema changed the
il_to data type from varchar binary to varbinary. This wouldn't
affect production.

For migrating Postgres:
 - Dropping foreign key on il_from
 - Setting default of empty string for il_to
 - Completely rewriting indexes to make it synced with MySQL

Bug: T164898
Bug: T230428
Change-Id: I59f0d0a56d938a168bf1c7de2a1be47f15d1add1
2020-08-22 22:59:00 +02:00
Amir Sarabadani
aecc67b83d Migrate templatelinks table to abstract schema
In order to migrate MySQL and Sqlite to abstract schema changed the
tl_title data type from varchar binary to varbinary. This wouldn't
affect production.

For migrating Postgres:
 - Dropping foreign key on tl_from
 - Changing data type of tl_namespace from SMALLINT to INT and setting
   its default
 - Setting default of empty string for tl_title
 - Completely rewriting indexes to make it synced with MySQL

Bug: T164898
Bug: T230428
Change-Id: Idbb65d870f58f7146b9c8bd860e6530bef1e0f12
2020-08-22 15:23:03 +02:00
Lucas Werkmeister
8b7a192fd3 Add extra blank line between tables in generated schemas
Put a single blank line between a CREATE TABLE and each accompanying
CREATE INDEX, but two blank lines between those statements and the next
CREATE TABLE.

Change-Id: I8ae8a3c808a772a338e968213031d390bf1b31ca
2020-08-20 12:04:57 +02:00
Lucas Werkmeister
639bd2178e Make newlines in generated schemas more consistent
Previously, a first str_replace() would add a single newline before any
CREATE (TABLE or INDEX), and then a second one would add another newline
after the $wgDBTableOptions, resulting in a blank line between any two
CREATEs and also a newline at the end of the file – at least for MySQL
schemas. But PostgreSQL and SQLite schemas don’t use $wgDBTableOptions,
so the second str_replace() was a no-op for them, and they got no blank
line between CREATEs nor a newline at the end of the file. Fix this by
making the first str_replace() insert two newlines and appending a final
newline all the time.

Bug: T260779
Change-Id: Idcc4fae76d382b559f21234f8a6f49e537a60f11
2020-08-19 16:54:41 +02:00
Amir Sarabadani
31dd3a9ebe Migrate pagelinks table to abstract schema
In order to migrate MySQL and Sqlite to abstract schema changed the
pl_title data type from varchar binary to varbinary. This wouldn't
affect production.

For migrating Postgres:
 - Dropping foreign key on pl_from
 - Changing data type of pl_namespace from SMALLINT to INT and setting
   its default
 - Setting default of empty string for pl_title
 - Completely rewriting indexes to make it synced with MySQL

Bug: T164898
Bug: T230428
Change-Id: I4af8202742a1826e6b3f8ff36cf4f7b612b82690
2020-08-19 13:58:00 +02:00
Amir Sarabadani
a531f4ad0b Migrate redirect table to abstract schema
Changing "varchar() binary" to varbinary in MySQL and Sqlite for two
columns: rd_title and rd_fragment.

Fixing db drifts of schema in Postgres:
 - Setting the data type of rd_namespace from SMALLINT and setting its
   default
 - Set empty string as default of rd_title
 - Changing datatype of rd_interwiki to varchar (PG supports that)

Bug: T164898
Bug: T230428
Change-Id: I9563792b1fc0ce5f3de78c08703a768a0c2e99d0
2020-08-13 00:37:45 +02:00
Amir Sarabadani
5e69ad1aad Migrate l10n_cache and module_deps to abstract schema
Also, fixing two data type drifts in Postgres:
 - lc_key was varchar (with no binary flag) in MySQL but TEXT in
   Postgres while PG supports varchar. Changing PG to varchar.
 - lc_value was BYTEA but the rest of varbinary fields are mapped to
   TEXT, changing it to TEXT data type.

And fixing primary key of these tables in Postgres too as it was a unique index instead.

Bug: T198811
Bug: T164898
Bug: T230428
Change-Id: I50305556bd870461d05f98c5272cf1d6a65deb15
2020-08-06 22:07:22 +02:00
Amir Sarabadani
e4bc792e6e Migrate content table to abstract schema
content.content_id was BIGINT in MySQL (and Sqlite) but INT in Postgres
so making Postgres BIGINT as well.

Bug: T230428
Bug: T164898
Change-Id: Ib8492e224478dc069ba17e489f7b2bb22d5da804
2020-08-03 00:46:01 +02:00
Amir Sarabadani
e464cc22ec Migrate change_tag to abstract schema
This is the first table that doesn't have any drift between MySQL and
Postgres.

Bug: T230428
Change-Id: I8be8906fc0f998c8aec79e148487219b3d43e57c
2020-08-03 00:46:01 +02:00
Amir Sarabadani
1799b9d09e Migrate log_search table to abstract schema
Also ls_value was varchar (with no binary flag) in MySQL but TEXT in
Postgres while PG supports varchar. Changing PG to varchar.

Bug: T230428
Bug: T164898
Change-Id: I2f7fae7b1e781021cb7d3ed39c40c2fc9d20a680
2020-08-03 00:46:01 +02:00
Amir Sarabadani
b345b8f6da Migrate user_properties to abstract schema
Also, dropping foreign key constraint on user_properties.up_user as it's decided to
drop all of foreign key constraints in T164898

And fixing primary key of the table in Postgres as it was a unique index
instead.

Bug: T198811
Bug: T164898
Bug: T230428
Change-Id: I60a2b65df62ec93a363309f8a17c29b83fd6f058
2020-07-31 17:49:50 +02:00
Amir Sarabadani
671b365394 Migrate site_stats table to abstract schema
Six fields were BIGINT in MySQL (and Sqlite) but INT in Postgres
so making Postgres BIGINT as well:
 - ss_total_edits
 - ss_good_articles
 - ss_total_pages
 - ss_users
 - ss_active_users
 - ss_images

Bug: T230428
Bug: T164898
Change-Id: I527b2797af3c8ba1a7402a4428b565f8e35cc132
2020-07-31 01:46:41 +02:00
Amir Sarabadani
aa3c07964c Migrate slots table to abstract schema
Three fields were BIGINT in MySQL (and Sqlite) but INT in Postgres
so making Postgres BIGINT as well:
 - slot_revision_id
 - slot_content_id
 - slot_origin

Bug: T230428
Bug: T164898
Change-Id: I5333cc0cbdc36356bd865ae118b883bc367c31eb
2020-07-21 18:05:41 +02:00
Amir Sarabadani
ac534bd119 Migrate comment table to abstract schema
comment.comment_id was BIGINT in MySQL (and Sqlite) but INT in Postgres
so making Postgres BIGINT as well.

Bug: T230428
Bug: T164898
Change-Id: I29a1878eea2adfd6e7d8ad85a94dc83718f9671e
2020-07-13 23:53:33 +02:00
Amir Sarabadani
b36210cae2 Migrate bot_passwords table to abstract schema
bot_passwords.bp_token didn't have a default in Postgres while it has
one in MySQL (and Sqlite), so adding the default to Postgres as well

Bug: T230428
Bug: T164898
Change-Id: I0ae4dbf8f2a5382081c6211c9cad51843000e3f1
2020-07-13 22:34:37 +02:00
Amir Sarabadani
5f03e0b5af Migrate actor and user_former_groups tables to abstract schema
Also during the abstraction, fixing the schema drift between MySQL
and Postgres in these two tables by removing foreign key, sequences,
and changing data types (as outlined in T164898)

Bug: T230428
Bug: T164898
Change-Id: If737a746629511b5a53d7ae70328fd558bd58d0e
2020-07-12 19:19:54 +02:00
Amir Sarabadani
3ad43ae06e Migrate site_identifiers to abstract schema
And converge the schema drift between mysql and postgres by setting all
to binary

Bug: T230428
Change-Id: I6f82b97c6e44c76ccdc0714aa8b32e959fbe896f
2020-06-14 18:37:30 +02:00
Amir Sarabadani
c1578fa017 Migrate updatelog to abstract schema
And fixing the schema drift between mysql and postgres in this table by
changing field type of ul_key and ul_value from TEXT and TEXT to
VARCHAR(255) and BYTEA respectively.

The automatic generation is done with running generateSchemaSql.php
maintenance script. More info:
https://www.mediawiki.org/wiki/Manual:Schema_changes#Automatically_generated

Bug: T230428
Bug: T164898
Change-Id: Id785539d32546166d6f7a5c3cb1924f4841a2963
2020-06-14 16:25:10 +02:00
Amir Sarabadani
8d011de416 More work on formatting generated sql
Bug: T230428
Change-Id: I2cb4cab045addd8f532f414923ce323e1bed52f2
2020-05-10 03:22:24 +02:00
Amir Sarabadani
11f241589b Wire empty abstract schema into installer
For more information on schema changes see:
https://www.mediawiki.org/wiki/Manual:Schema_changes

Bug: T191231
Bug: T230428
Change-Id: I779b9c61e388e998738a2ed41b0b8e2afdecd232
2020-05-09 20:42:11 +02:00