Commit graph

12 commits

Author SHA1 Message Date
jenkins-bot
6953ca099e Merge "Fixed spacing" 2015-09-26 21:02:39 +00:00
umherirrender
c572d18661 Fixed spacing
- Removed space after cast
- Removed spaces in array index
- Removed double spaces
- Added spaces around string concat
- Fixed mixed tabs and spaces at begin of line

Change-Id: I38e849723f055d2d4c05cba72f5c245a28e8d5da
2015-09-26 20:44:54 +00:00
umherirrender
2dbee49b94 Add curly braces to if statement
Change-Id: I827eb48ee030c338336d91dbfd016c22c5e3cb6b
2015-09-26 20:44:14 +00:00
Ricordisamoa
c652ac9984 Add space between classes in HTMLButtonField
Classes such as 'wb-input-buttonmw-ui-button' were being generated
when $wgUseMediaWikiUIEverywhere = true, see:
https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-tests-mysql-hhvm/4217/console

Change-Id: If40b712ffb8e31d27380bf481333eecb7b95f9de
2015-08-27 17:57:31 +00:00
Florian
88d616ba7b Fix doc-blocks for some HTMLForm elements
The @return doxygen parameter can take a class with a namespace, but
the \ needs to be escaped with an additional \. "\value" is usually interpreted
as a special command.

Actually with "@return OOUI\Widget", e.g., you'll get this output in your docs:
return OOUI

and an error message in the doxygen generation with something like "unknown command \Widget".

With "@return OOUI\\Widget" you'll get the expected output:
return OOUI\Widget

without any error message.

Change-Id: I14c4d7521f81ddd8c7b56facc1f0ae34f86b2299
2015-07-20 17:01:04 +00:00
Florian
e20347614c HTMLForm: Handle Flags in non-OOUI form buttons, too
Flags added to a button or submit field in a non-OOUI form will be
handled now, too.

With activated wgUseMediaWikiUIEverywhere:
All flags will get the 'mw-ui-' prefix.
(mw-ui-button is added to the button automatically)

With deactivated wgUseMediaWikiUIEverywhere:
All flags will get the 'mw-htmlform-' prefix.

This allows HTMLForm users to add flags to only the button, without
setting them as a cssclas, which would be added to the wrapper elements,
too.

Bug: T102838
Change-Id: I121a966fb4db6649a6e1012187148d354b5534f0
2015-07-11 16:01:12 +02:00
Florian
1025f0a79c Fix Button label in OOUI HTML Form and enable flags
An OOUI Button now adds the value as a label of the button, too. Enable
the HTMLForm descriptor to pass flags to the OOUI Button widget, which
defaults to nothing in HTMLButtonField and to 'primary' and 'constructive'
in HTMLSubmitField.

Change-Id: Ibf561453604a830862d4f64819c8418a9458cb12
2015-06-25 14:56:05 +02:00
Mark Holmquist
e85bd04bcd Implement OOUI display format for HTMLForm
Bug: T85291
Change-Id: I6ffe93c16d6b209a0ab08d714ad8ddaefb6acd52
2015-05-23 16:10:08 +02:00
umherirrender
dcf6955e5c Fixed some @params documentation (includes/*)
Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.

Change-Id: Ifbb1da2a6278b0bde2a6f6ce2e7bd383ee3fb28a
2014-04-20 23:33:05 +02:00
Alexandre Emsenhuber
cb9a9a7b47 Add support for "tabindex" in HTMLFormField subclasses
It is already set for some fields in Special:Block, but are
discarded by HTMLForm and its fields.

Some notes:
- fields with multiple inputs (radio, select and other, select
  or other) will have the same tabindex set on all elements
- Some items such as multi-select and check matrix are not yet
  implemented

Change-Id: I3e1ba7f16f3a3183f231afcf60dd392ce6d6eb6b
2014-01-25 04:31:01 +00:00
addshore
8fa2314b2e Formatting fixes in includes/htmlform/*
Change-Id: Iee9e4f3fcf8491022ffe97c74312871f97f8ce9c
2013-12-09 14:23:05 +01:00
addshore
976276338a Split includes/HTMLForm
Change-Id: I6eabfdb064c0e35b69efe9d6142e94df4128b632
2013-12-08 23:13:56 +01:00