Commit graph

24 commits

Author SHA1 Message Date
libraryupgrader
5357695270 build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 36.0.0 → 37.0.0
  The following sniffs now pass and were enabled:
  * Generic.ControlStructures.InlineControlStructure
  * MediaWiki.PHPUnit.AssertCount.NotUsed

npm:
* svgo: 2.3.0 → 2.3.1
  * https://npmjs.com/advisories/1754 (CVE-2021-33587)

Change-Id: I2a9bbee2fecbf7259876d335f565ece4b3622426
2021-07-22 03:36:05 +00:00
ZabeMath
37e952e1de Using RevisionListBase::getPage instead of calling $title directly
Bug: T282825
Change-Id: I9966b206b053c8227e619521b5ad69561198443e
2021-05-13 20:59:27 +00:00
daniel
2a1087fa40 RevisionDeleter: Use PageIdentity instead of Title
RevDelList for now still uses a Title internally.

Change-Id: Id839ac697bd742e908f465cf5330da486dc73111
2021-05-06 13:42:13 +02:00
Amir Sarabadani
b6f148bec6 Add classes to when a linked change is suppressed
This also tries to centralize adding logic of adding history-deleted
class as well. To make future changes easier.

This doesn't affect history deletion on files, recentchanges, and logs yet

Bug: T23272
Change-Id: I08f14f712479e1b170c606e2b64857f8386acd76
2021-04-29 15:28:06 +00:00
Petr Pchelko
782a46f661 Use Authority for revision audience where possible
Depends-On: I963a79d94b9e39086940a43945def7c8eff1536d
Change-Id: If99d428b391c0eaf61396565af7f38740bef6c4a
2021-02-24 10:56:50 -07:00
Umherirrender
7cecd5a2cf Improve docs of RevisionItemBase and RevisionListBase
Change-Id: Ia0e3a301ce217645695b59613a7f44cf19ecad99
2020-11-12 22:08:51 +00:00
DannyS712
4a206f1f90 Add tests for RevisionList/RevisionItem classes
Fix RevisionItemBase::getId to actually return an int, as intended

Previously all four classes (RevisionItem, RevisionItemBase,
RevisionList, and RevisionListBase) had no coverage. Now:

+--------------------------------------------+-------+--------+
| Filename                                   | Old % | New %  |
+--------------------------------------------+-------+--------+
| includes/revisionlist/RevisionItem.php     | 0     |  46.77 |
| includes/revisionlist/RevisionItemBase.php | 0     |  70.27 |
| includes/revisionlist/RevisionList.php     | 0     | 100.00 |
| includes/revisionlist/RevisionListBase.php | 0     |  76.32 |
+--------------------------------------------+-------+--------+

Bug: T252076
Change-Id: I3da1ae350986ef6dc54a13ae9275b4c1d03f6e5b
2020-05-12 09:36:44 -07:00
Umherirrender
a9c55726e0 Add missing public visibility on some methods
RSSFeed::formatTime and AtomFeed::formatTime are private

Change-Id: I6bf081c31c92e7130ae0ae527ba4a8f4635c7de2
2020-05-08 21:25:36 +00:00
DannyS712
9753db1909 RevisionItem: Fix providing timestamp in getRevisionLink
Caused by: 49707c59da

Bug: T252072
Change-Id: I801c6c07283f220ad5bac828d8204e600ba1db1f
2020-05-06 21:10:01 +00:00
DannyS712
ec7584d4fa Remove use of Revision objects in RevisionItem classes
Bug: T249393
Bug: T249021
Change-Id: I1e240adb2799978b7f4302f90e43f7d337a0fdd9
2020-05-05 23:59:09 +00:00
DannyS712
49707c59da Replace various uses of Revision objects
Each file's changes are independent of the other files and can be
reviewed separately.

Bug: T250579
Bug: T250714
Bug: T250580
Change-Id: I223dd6dfba27e560aff89be6705d91c40c550dd8
2020-05-01 14:54:28 +00:00
DannyS712
af7f397ccc Pass RevisionRecord to Linker methods
Hard deprecation of passing Revision objects will follow soon,
but until that is ready core calls can be updated

There is some code cleanup that could be done around the calls, but
to simplify review no other changes are made.

Bug: T249561
Change-Id: Ifcfb3811650decffeaa87dc033c41fd1710b47a6
2020-04-18 01:24:54 +00:00
DannyS712
1d4df4f221 Hard deprecate Revision::getQueryInfo and ::getArchiveQueryInfo
Bug: T246284
Change-Id: I708f265aac3016e34d02936cf5dff98a3036ef0f
2020-03-26 23:53:19 +00:00
DannyS712
78bc3ae255 Hard deprecate Revision::userCan
Replace remaining uses outside of tests, hide deprecated in tests

Bug: T247259
Change-Id: I91dfb46ed6864ee89d968aea8ec93b5ea2f8389e
2020-03-11 02:10:52 +00:00
James D. Forrester
4f2d1efdda Coding style: Auto-fix MediaWiki.Classes.UnsortedUseStatements.UnsortedUse
Change-Id: I94a0ae83c65e8ee419bbd1ae1e86ab21ed4d8210
2020-01-10 09:32:25 -08:00
Daimona Eaytoy
ce0856b12f Fix more scalar types in docblocks
Change-Id: I574d4e261ab986e028c3ce26c4f0ec648b88a2ac
2019-12-08 17:59:08 +00:00
Umherirrender
0688dd7c6d Set method visibility for various constructors
Change-Id: Id3c88257e866923b06e878ccdeddded7f08f2c98
2019-12-03 20:17:30 +01:00
Thiemo Kreuz
3c9acdff54 revisionlist: Strict type hints in RevisionItem constructors
Change-Id: Iab0bce89a9a4111eef217bbc1a8f1263f1ed796a
2019-10-25 15:37:26 +00:00
Thiemo Kreuz
4ada35bbea revisionlist: Fix bad type hints in RevisionListBase
These are not Revision objects.

Change-Id: Ibdf6d7ad10007adbbcf0b762e54870565fb75a7a
2019-10-05 08:10:56 +00:00
Umherirrender
fb3914739e Type hint against IResultWrapper
IDatabase::select returns the interface IResultWrapper,
not the implementation ResultWrapper

Change-Id: I8904eff2db48ff00a4a9486be842266c638bc249
2019-10-04 19:58:19 +02:00
Umherirrender
f74400487f phan: Disable enable_class_alias_support
It is enabled for b/c in extensions, but not needed in core

Change-Id: I51dca12be9c77049f77563d9bf0edd07928c2300
2019-09-15 08:26:52 +00:00
Daimona Eaytoy
7f7efbe026 Globally unsuppress phan issues with low count
All of these suppression prevent the detection of many common mistakes,
and could easily prevent things like T231488. Especially if there are
few issues of a given type, it's way better to suppress them inline,
instead of disabling them for the whole core.
This patch only touches the one with a lower count (although those
counts may be out of date).

Bug: T231636
Change-Id: Ica50297ec7c71a81ba2204f9763499da925067bd
2019-08-30 09:40:47 +00:00
Derick Alangi
339211a1ea Avoid usage of deprecated Revision::* constants, use RevisionRecord
Change-Id: I872fc89e5c02dd6a3ae9cd7e76640b95dc33f514
2019-07-21 15:03:03 +01:00
Umherirrender
3265bbb184 Move class RevisionListBase and friends to own file
Change-Id: I2c3675286bef948585ee0364288081aad9fd4376
2019-03-14 19:50:40 +01:00