Commit graph

3 commits

Author SHA1 Message Date
Timo Tijhof
4f6051e96d filebackend: Fix undefined wgProfiler in FileBackendGroupTest
This currently passed CI without it, because:

1. Profiler::instance() uses 'global' instead of Config::get(),
   which means there is no warning for it being undefined. (When you
   run a stament like 'global $foo' it implicitly auto-creates the
   variable and assign it the null value).

2. Profiler::instance() uses array_merge() which silently tolerates
   non-array values like null in the list of arguments.
   This is changing in I638d9a219df7.

Bug: T247777
Change-Id: Ic77d6023ef88ad928fe5bf9807e6e8dfb7bc4e9c
2020-03-16 18:07:56 +00:00
Aryeh Gregor
84cf385db0 Deprecate FileJournal::factory
Instead, the constructors for FileJournal and NullFileJournal should be
treated as stable. I would have added @stable, but our linting doesn't
recognize it yet and doesn't let.

Bug: T235066
Change-Id: I7741055b4f00197d1346ebbfebc14f20238a06f3
2019-11-04 15:17:56 +01:00
Aryeh Gregor
0d3d6be18d Convert FileBackendGroup to service
Bug: T234228
Change-Id: I25575f565eba122cdf971a5945572811d17fa3e1
2019-10-25 10:46:20 +03:00