Commit graph

6 commits

Author SHA1 Message Date
Thiemo Kreuz
6b2c9deef5 Replace all new stdClass() with identical (object)[]
This should be the exact same. Its more a style change than anything.
So why do it then?
* I believe this is much less confusing than code mentioning a weird
"standard class". Barely anybody knows what this is, and what the
difference between "object" and "stdClass" is.
* The code is shorter.
* It's even faster. In my micro benchmark it's twice as fast.

Change-Id: I7ee0e8ae6d9264a89b6cd1dd861f0466ae620ccc
2020-03-04 21:18:30 +00:00
Kunal Mehta
b9461e3f1c FormatJson: Improve parse() error code handling and tests
Three of the errors are encode errors that won't be emitted when we're
trying to decode JSON, so we can ignore those lines of code.

JSON_ERROR_UTF16 is a new error code in PHP 7.0, so add that in.

Improve test coverage while we're at it. The UTF16 test case was
copied from php-src/ext/json/tests/bug62010.phpt.

Change-Id: I79aa0db3d967d512611f8521bb052af36c3cda8e
2020-01-01 02:34:44 -08:00
Daimona Eaytoy
6365eaab8d Autofix 94 PHPUnit 8 compat issues
Done automatically using the master version of MW codesniffer and
running composer fix.

Bug: T192167
Change-Id: If6b40f515fde32ab5eff074a90e821c30c791827
2019-12-13 15:29:10 +01:00
Reedy
5b6477fb76 Tweak comment in FormatJsonUnitTest::testEmptyJsonKeyArray
Change-Id: I7625952f6afa2c8840dd9f52c0bd79ff29bfd91a
Follows-up: Ieed5662435c7a4070a7ac28ce74b8d51c8135c66
2019-10-12 23:32:12 +01:00
Reedy
3cd66f6ae9 Remove PHP < 7.1 case from FormatJsonUnitTest::testEmptyJsonKeyArray
Change-Id: Ieed5662435c7a4070a7ac28ce74b8d51c8135c66
2019-10-12 22:41:07 +01:00
Amir Sarabadani
fe9863fd55 Move unit tests FormatJsonTest.php to a dedicated file in unit tests
Out of 140 tests of this file, 131 one of them are pure unit test
Let's keep the 9 in the original file and move the rest

Bug: T87781
Change-Id: I86dfe17f794c615048b3c20487b0e84d38d13b93
2019-07-07 21:35:40 -04:00