Why:
- Setting the increment to 0 should check the limit without bumping it.
- This was apparently broken by If3e66491306f22650.
What:
- Use LimitBatch::peek if the increment amount is 0
Bug: T381033
Change-Id: Ife76a1976a2063f051f00302e5adaebd701e6367
(cherry picked from commit e09606b3dc44711571cc6cf2d0d11bd7784d0cdd)
If $mailparts does not contain two elements (which would be the case when the separator `@` is not present in the string), then we cannot
access $mailparts[1].
In this case, the entire path as is, is treated as the host.
Bug: T380880
Change-Id: I10187c93e67ce9294ff0b3866939d2c7d7292a9a
(cherry picked from commit c2db58c55bef207dd37ac5fe0b07aa28ee4bd2d5)
* Update extensions/OATHAuth from branch 'REL1_43'
to 924a39adec68ae3af6b8c536723648ca5527fd39
- Fix translations for recovery code notifications
The notification body was listed with the incorrect key name.
The notification header was missing completely.
This is a follow up to Ic4294dc4ca8eb238998af3ec6b69a771f1b17c17
Bug: T383265
Change-Id: I14599a4a1bd4bd452727aa9f81566af4d3ad7cfa
(cherry picked from commit e77fd953ff89b86dbefa22734386b6af59fcd077)
* Update skins/Timeless from branch 'REL1_43'
to 2a795e3d690fb97fa1ff3fa8522b63d9f55b6a5b
- Localisation updates from https://translatewiki.net.
Change-Id: I822e12e36ac6f9be5b87d8e4217416e8c10939ed
* Update skins/Vector from branch 'REL1_43'
to 210e513841da380e13bb539e55a70095d4163dad
- Localisation updates from https://translatewiki.net.
Change-Id: I3a8b78eb7207b6ac1b0129ac40bdba98f35d6358
* Update skins/MonoBook from branch 'REL1_43'
to 4f2266626b36bb7556e54b87814b0016bd1adf2b
- Localisation updates from https://translatewiki.net.
Change-Id: I6914a39c229e3375a4174c51f02641e464dec1dc
* Update skins/MinervaNeue from branch 'REL1_43'
to a764a4b30bbd486142d829dfa242daf8806c71ad
- Localisation updates from https://translatewiki.net.
Change-Id: I142d58fb65784930ee5ab88baf10816e88fc93ea
* Update extensions/VisualEditor from branch 'REL1_43'
to 15b1e270dacb67b81938d726b0334ab9cace9800
- Localisation updates from https://translatewiki.net.
Change-Id: I6ad7345e1d696379e461aea5dfae290e62cbf9b3
* Update extensions/WikiEditor from branch 'REL1_43'
to efed4932d7ad484af6798d1704f84eff2933b1a2
- Localisation updates from https://translatewiki.net.
Change-Id: If8d2745d3377f16b0c20da0cb5cf441b55a80a3c
* Update extensions/Thanks from branch 'REL1_43'
to a619821e2d530c9c10666b3842e44dd3d61c61fb
- Localisation updates from https://translatewiki.net.
Change-Id: I56462343a87aa151ac348cbdd429021174b235eb
* Update extensions/SyntaxHighlight_GeSHi from branch 'REL1_43'
to bfa8838ff6d84ffb79be1e97f5faefc740c43c32
- Localisation updates from https://translatewiki.net.
Change-Id: I40455de57cff4f1bb13ef5570ee9ff91e9276839
* Update extensions/TemplateData from branch 'REL1_43'
to a5e5dab30404b841afef018fed5edfb54db002f6
- Localisation updates from https://translatewiki.net.
Change-Id: I861034dc841948c377afa069db0d491bdf7932f3
* Update extensions/SpamBlacklist from branch 'REL1_43'
to 46795dda66216ab8e7805564ac6f8e09900068a4
- Localisation updates from https://translatewiki.net.
Change-Id: I59b09517c7373b7f7b97119d06145834c8398181
* Update extensions/ReplaceText from branch 'REL1_43'
to 33406c20233af3e2ce4d0205364839dbad954546
- Localisation updates from https://translatewiki.net.
Change-Id: Ib2b91934dd1d32be3d86cbbaf17ebab5ddabea5b
* Update extensions/OATHAuth from branch 'REL1_43'
to 21da913c2beb14da4440266ef6e57640a6287f03
- Localisation updates from https://translatewiki.net.
Change-Id: I477e79d954873b96afeff05339b3ed59e47b397a
* Update extensions/Nuke from branch 'REL1_43'
to db624a8db77c93e4f7fb5a3e9d984246806d2c51
- Localisation updates from https://translatewiki.net.
Change-Id: I7d27cfe52c0b51ed7d876b750412109e490feb82
* Update extensions/MultimediaViewer from branch 'REL1_43'
to cb7554f5dafa8f379020f30bd9232a5f8599a1de
- Localisation updates from https://translatewiki.net.
Change-Id: Ib06c73a9e9958b4bf7c77e5127112b9c908679b9
* Update extensions/Math from branch 'REL1_43'
to 878c2adacf41f08a22e893f353f707e3e320fa2e
- Localisation updates from https://translatewiki.net.
Change-Id: Ic11e47dbdcbc555f5abf193259831e1b5c0826d7
* Update extensions/Linter from branch 'REL1_43'
to 1520a069b47c6effa51904b32542ff2389e8c3f8
- Localisation updates from https://translatewiki.net.
Change-Id: I024fcc55007864c202b775f07965a4963df1fc41
* Update extensions/InputBox from branch 'REL1_43'
to 9903156d6d8fce26cb9e0f1fd016cd25b40e5356
- Localisation updates from https://translatewiki.net.
Change-Id: I10b3794530bda189aafb2f1d4de4b929649e7571
* Update extensions/Gadgets from branch 'REL1_43'
to b19d615db45f63cf1a1cbd83cb33b69144edb7e2
- Localisation updates from https://translatewiki.net.
Change-Id: Ibe55567e070ee4a3b35a71543912fbb7c4397f56
* Update extensions/Echo from branch 'REL1_43'
to 1f01255482616f9fc481f6e821a3afb5e342b37a
- Localisation updates from https://translatewiki.net.
Change-Id: I337776bfbca0f9fdd0799df4e4f918baa08a8731
* Update extensions/DiscussionTools from branch 'REL1_43'
to 4d28bbdd810b6e3cc0f29cd40dfbc066c65372ec
- Localisation updates from https://translatewiki.net.
Change-Id: Ie7abfce6b63c97dfdebf05758a05d3db28806afa
* Update extensions/ConfirmEdit from branch 'REL1_43'
to 5f39b1179e2eb318d46ee0e3d8beb5e9c11a3f03
- Localisation updates from https://translatewiki.net.
Change-Id: I660a0b5c67977a5dfa917683607698cf3f43bbe1
* Update extensions/Cite from branch 'REL1_43'
to bb63f3e881c0a399cadb1c42998f1c73ee3e31dc
- Localisation updates from https://translatewiki.net.
Change-Id: I87af050a06dff747f938ab9b9e7d389cf701159b
* Update extensions/CategoryTree from branch 'REL1_43'
to 7a4d4216c845227cbe388bdec0f28ef6fa81e4fb
- Localisation updates from https://translatewiki.net.
Change-Id: I4f2479c11e33dcc72a6c45c66ed03a8ffc1e9fb9
* Update extensions/AbuseFilter from branch 'REL1_43'
to 7523fb8997d07d7a80989e0299e8d304ec4971b6
- Localisation updates from https://translatewiki.net.
Change-Id: I0eeb3ccd51d34bdcd0529afb6133e45647084ba5
It is not clear who the "brand-new users" are in this case so help-message is required here.
Bug: T381205
Change-Id: Idfc1b7e4b5b1686f0edf69b32e0d4152b30e54ae
(cherry picked from commit 141be6c7f7a3be92d702db1e26ba7d0493aa8a0f)
This reverts commit 4563e41f20.
Reason for revert: The expected DatabaseSqlite is not directly used here, it is still DBConnRef and the patch does not work as is.
Bug: T386891
Change-Id: I83b1e299b698c004dcacb9aa90901dfe28097403
(cherry picked from commit 7fdc51ed4d27ba6211215c6198b7e448de799cde)
* Update extensions/Cite from branch 'REL1_43'
to b0e1c7ef4c6046dda811dd942ada47ec80b157ee
- Localisation updates from https://translatewiki.net.
Change-Id: I714b0abbdd095e8cfab29e53ea98f24a0971cdd9
* Update extensions/CategoryTree from branch 'REL1_43'
to a6e27fdbe6a4f63ea17521e6dc320a4e129f5758
- Localisation updates from https://translatewiki.net.
Change-Id: Ie354b6c26a58a8ad4bf066c8eaac925e22fd0d35
Why:
Both AtomFeed::formatTime() and RSSFeed::formatTime() short-circuit with
null if the input is falsy. This caused deprecation warnings down the
line, as the return value was later fed into str_replace(), which raises
a deprecation warning on PHP 8 if it gets null.
It also caused unexpected output on all PHP versions: the Mustache
templates for both Atom and RSS conditionally emit the date elements
(<updated> in Atom, <pubDate> in RSS), but this conditional output is
skipped only if the variable is null, not when it’s an empty string –
which is exactly what the XML encoding returned on all PHP versions.
What:
Introduce a new method, xmlEncodeNullable(), which properly handles null
values, and returns them as-is, without trying to encode them. This:
- Avoids the deprecation warnings on PHP 8, since str_replace() is no
longer called.
- Makes the conditional output work: the <updated>/<pubDate> elements
are no longer output if no date is available.
- This makes the RSS output spec-compliant, as no garbage is output
anymore. The RSS <pubDate> is optional [1].
- It doesn’t make the Atom output entirely spec-compliant, as Atom
requires <updated> to be present [2], but the removal of garbage
(it was a single letter Z) should still increase compatibility.
[1] https://www.rssboard.org/rss-specification#hrelementsOfLtitemgt
[2] https://validator.w3.org/feed/docs/atom.html#requiredEntryElements
Bug: T385332
Change-Id: Iafd89c0d61baecd7c68f62b2a0764cc78cf25069
(cherry picked from commit 60c57b0fd5303e9627b7684ebac4cd369c1fe7a6)
* Update skins/MinervaNeue from branch 'REL1_43'
to ba850e2ca6b8e5256553b6c336d50efeac4da140
- Localisation updates from https://translatewiki.net.
Change-Id: Iebb600ad71e9fb58847cabe0229268f3ad6c3787
* Update skins/Vector from branch 'REL1_43'
to 34e36ecb91b98064288a911c400fa03f59e07144
- Localisation updates from https://translatewiki.net.
Change-Id: I5916802af950a3c07fb492670fce298bb920eb89
* Update skins/MonoBook from branch 'REL1_43'
to d1800222e664e8ac5636225ef68c82f9e2fd9b95
- Localisation updates from https://translatewiki.net.
Change-Id: I98ea489b8a836dd4c74ebcd6c929fa1a83edfbfe
* Update extensions/VisualEditor from branch 'REL1_43'
to cf6665c16b3f8db755a335d5fc0c0be035e8243f
- Localisation updates from https://translatewiki.net.
Change-Id: Ia446e43ed3da3c737390f08ff2ab3fcf4e3b9f13
* Update extensions/WikiEditor from branch 'REL1_43'
to 3537984d0a86a18db3c079ddcac4b94f28e41e09
- Localisation updates from https://translatewiki.net.
Change-Id: I66e8a4b0c4003bad7a1adc8743752759c0259a8b
* Update extensions/SyntaxHighlight_GeSHi from branch 'REL1_43'
to 56bdce6a2e3ddc61db604f57c47006af43874cc8
- Localisation updates from https://translatewiki.net.
Change-Id: Ic6f0e67d03a63f154249cfc9ce962e1f3e9f98dd
* Update extensions/TemplateData from branch 'REL1_43'
to 5d9ccbdfd292ed7501aa76e63876308f50ff65c5
- Localisation updates from https://translatewiki.net.
Change-Id: I390d5db1509d1ecad07219e092631c7e8dc6fca7
* Update extensions/Scribunto from branch 'REL1_43'
to 3c4e4b51ef4a356b6ad1456cf352f58af90d8c59
- Localisation updates from https://translatewiki.net.
Change-Id: I346eb35a09357f54a7517d42628999bc2ace9c94
* Update extensions/MultimediaViewer from branch 'REL1_43'
to ec6e2f772dacab881cb9be31a43f9db525104246
- Localisation updates from https://translatewiki.net.
Change-Id: I126e1b15f62c0c02c65c3b7e4517cda2df595bdf
* Update extensions/OATHAuth from branch 'REL1_43'
to 8a7c4a6d096cdacc47d10cd18e3f33717790a2bd
- Localisation updates from https://translatewiki.net.
Change-Id: I32f96503228213f67402bd06613499cad7a1a01a
* Update extensions/Nuke from branch 'REL1_43'
to 382591dc50ce85c813fd5b52ccee9a9cb9c67942
- Localisation updates from https://translatewiki.net.
Change-Id: I362e6de55b6be3e0beed707b262447c5cceba172
* Update extensions/Math from branch 'REL1_43'
to 8bb9ee4926a568a05263e8c7c82277537f6f32ce
- Localisation updates from https://translatewiki.net.
Change-Id: Id10ef1b1a634b439e978db1ac7033c13aafb83b8
* Update extensions/InputBox from branch 'REL1_43'
to 807e888687529a246f4f46980e47e144b73c6f8a
- Localisation updates from https://translatewiki.net.
Change-Id: Ib4178995794ddc80dedadd98d3972eefcf80062b
