* Update extensions/AbuseFilter from branch 'wmf/1.30.0-wmf.17'
- Avoid CommentStore errors by selecting correct set of columns
Change-Id: I7d83a45fbf86dc0144d50e8b6258b97f1b0c7188
* Update extensions/MobileFrontend from branch 'wmf/1.30.0-wmf.17'
- Do not use deprecated fallback handling for History/Contributions
The Contributions page extends the History page so this change
also fixes the warnings there.
Bug: T175161
Change-Id: Ia79d6e72c185fb3ffd47d62a0dc5342b31382294
* Update extensions/WikimediaEvents from branch 'wmf/1.30.0-wmf.17'
- Encode human search relevance survey into html output
Moves the search relevance configuration from javascript into php
configuration so it can be run on a larger number of pages without
exploding the size of javascript delivered to everyone with all
that config.
The downside of this approach is that because the config is cached
into the page html any updates have to work their way through varnish
caching. For the initial test this should be fine as we can purge the
relevant pages over some small time period. In the future when we are
doing larger scale collection we just have to keep in mind that
configuration changes take around 7 days to propogate.
Bug: T174387
Change-Id: I7ae522155e67610d25b5857d7b3918559bce8bc7
(cherry picked from commit e722fe1a9b0d41c3597f9f9326e7fc6f0e1cd9c6)
* Update extensions/Scribunto from branch 'wmf/1.30.0-wmf.17'
- Fix tests
Iaa880531 added extra frames in the call stack, so the frame being
tested by the "setfenv invalid level" and "getfenv invalid level" tests
was no longer invalid.
Bug: T175065
Change-Id: Id1028e7c8bbb92fb9d7d01ebeabd94e8ba284b1c
(cherry picked from commit 7418a571ac59cc25b682c681a9c2dd330c4a983a)
Also revert the automatic "Update git submodules" commits since then.
This reverts commit 264fc98588.
Change-Id: Ica6ad77c46cc8a7f6b5576da2580ea9e07ac8637
* Update extensions/wikihiero from branch 'wmf/1.30.0-wmf.2'
- Fix styles queue violation for "ext.wikihiero.Special"
The same module is explicitly being loaded twice, once just the
styles, and again with the JS/messages/dependencies as well.
This is wasteful and also unsupported.
Move the two style rules to the main stylesheet and load the
proper styles module it belongs to instead.
Bug: T92459
Change-Id: I012b4d9bff5bd0379f8b9eb663d5b5dbf71f1885
* Update extensions/ProofreadPage from branch 'wmf/1.30.0-wmf.2'
- Properly handle batches of pages to update
Using LIMIT on UPDATE/DELETE queries is unsafe when using statement-based
replication as you can't ensure the same sets of rows are updated.
Instead, select a batch of problematic page_ids, update by them, then
continue until we don't find any more to fix
Bug: T166261
Change-Id: I8a5d2989285c72450d6a48ccc12d88fdeeb3fb6f
These are actually far more useful listings than the mediawiki
group on Gitblit, which is everything MediaWiki and provides
no actual listing beyond "recently active"
Change-Id: I741cb53ca417bddfa176868fb78ce67b1475fc70
docs/README: Updated links, got rid of 2008 date at top of file
docs/maintenance.txt: Updated link
extensions/README: Some cleanup, added link to new git.wikimedia.org
includes/DefaultSettings.php: SVN -> Git for udpprofile
includes/profiler/ProfilerSimpleUDP.php: ditto
languages/MessagesRo.php: removed link to mime.types on SVN from the
mimesearch-summary message. This file seems to have been deleted from the
modern-day Git repository
maintenance/postgres/mediawiki_mysql2postgres.pl: removed SVN magic words
That takes care of most of the remaining references to SVN etc.
Bug: 38714
Change-Id: I261921df4b4c0545658d6d38c5f3c1f9dfa63ad1
Squiz.WhiteSpace.LanguageConstructSpacing:
Language constructs must be followed by a single space;
expected "require_once expression" but found
"require_once(expression)"
It is a keyword (e.g. like `new`, `return` and `print`). As
such the parentheses don't make sense.
Per our code conventions, we use a space after keywords like
these. We appeared to have an unwritten exception for `require`
that doesn't make sense. About 60% of require/include usage
was missing the space and/or had superfluous parentheses.
It is as silly as print("foo") or return("foo"), it works
because keywords have no significance for whitespace between
it and the expression that follows, and since experessions can
be wrapped in parentheses for clarity (e.g. when doing string
concatenation or mathematical operations) the parenthesis
before and after basiclaly just ignored.
Change-Id: I2df2f80b8123714bea7e0771bf94b51ad5bb4b87
Remove a trailing whitespace added by me in dirname( __FILE__ )
clean up and add some comments to the PHP version checks (they
can't use __DIR__ as they have to run in older PHP versions.
Change-Id: I6a7e8cb7dbf384d91dda4d0ecbef7ce588bc3073
Removed left over uses of dirname( __FILE__ ) to __DIR__, even in comments.
Running the PHP version test in maintenance/Maintenance.php earlier, so that
we no longer have to stay PHP < 5.3 compatible in there.
Change-Id: I5a00bd5c6af44b7f826c4e5576a7b3de7b5026d8
