We already use CONN_TRX_AUTOCOMMIT for mysql/postgres and
a separate DB file (e.g. "server" config) for sqlite (via
the installer). For any legacy case where the main DB is
still used with sqlite, the removed method was unlikely to
be very effective.
Ignore DBO_TRX/DBO_DEFAULT in JobQueueDB "server" config
for good measure, similar to SqlBagOStuff.
This removes more direct uses of IDatabase::setFlags(),
a method which does not play well with DBConnRef.
Bug: T311090
Change-Id: Ia8457dea2ed30539e23345f89cb6b382be442975
The only use of images/questions.svg apparently was in
HTMLCheckMatrix and this removes the use making deletion
of the asset also possible.
As this uses a Codex provided color, it makes the help icon
to now look correctly in the dark mode also.
This is done in a way that HTMLCheckMatrix's clients can
provide their own style to override the icon like before.
The main motivation behind this is to remove inaccurate
:lang() selectors this had for the help icon's localization which
was supposed to support different languages that use an RTL script
but the Codex one also already provides the same and more
complete logic automatically using the Less mixin it provides.
Change-Id: If5d11fd9c6fc9d528f6792d2d35fa097c89fba5a
Why:
* The maintenance scripts in core are mostly untested and testing
them will ensure that they are more reliable and resistant to
regressions.
What:
* Create EditTest
Bug: T371167
Change-Id: Ib57bdc82b13fe8cd353716edd99862553bc1b870
Update the Chinese conversion table routinely to fix bugs reported at
https://zh.wikipedia.org/wiki/Wikipedia:字词转换/修复请求.
It is only data changes and only works for Chinese WikiProjects.
Change-Id: I50920b1be658741bfb3643e3992b3ebd6727e0ec
The following patches should be merged immediately
after this one:
I66fbebe2f43484973fa060285e1b41efae499864
I13c7d94b050a38e9d5599493af34266029e97225
Bug: T372213
Change-Id: Ice859477e511b38f7bf6c051082d04f6c83a10e7
Why:
* Maintenance scripts in core are mostly untested and testing the
less complex scripts will enable quicker raising of the
coverage.
What:
* Add FindClassesTest
Bug: T371167
Change-Id: I8bc9ef7c7bc59b675734f00bf5c2c0892bba8c3a
Why:
* The maintenance scripts in core have poor test coverage and
testing the less complex scripts will help to address this.
What:
* Create DeleteArchivedRevisionsTest
Bug: T371167
Change-Id: I6e61f7a9d62892a92d6f2af21248889e155bf30e
Why:
* Maintenance scripts in core have poor test coverage and improving
this will help make them more reliable.
What:
* Create CleanupWatchlistTest which tests cleanupWatchlist.php
Bug: T371167
Change-Id: I8cdc241a3f6ae94c3f301e7802ff80bcbc62f38a
Why:
* Some less-complex methods in the Maintenance class are not
tested and testing these should be easy to achieve.
What:
* Expand MaintenanceTest
Bug: T371167
Change-Id: I0a5968054a80bb79be261b9c4fa99f7a1732b0ff
Why:
* The blockUsers.php maintenance script can set the performer's
username as the username provided via the --performer option.
* The username is validated by the script, but the validation broke
in c106f679b0. This was because both:
** The check for whether the username was invalid changed to only
looking for 'null' values returned by User::newSystemUser /
User::newFromName.
** The User::newFromName method returns false on an invalid username.
* Replacing the deprecated User::newFromName with the call to
UserFactory::newFromName fixes this issue, as the replacement
method returns null on an invalid username.
** This also allows replacement of a deprecated method, which is
preferrable to changing the 'null' check to be a falsey check.
What:
* Replace the call to User::newFromName with UserFactory
::newFromName to fix this issue.
* Add a test to verify that this fix worked.
Bug: T371167
Change-Id: Ie181c16a1dda559a81b8ae4d53cd8f69b1af9b75
Why:
* The test coverage on maintenance scripts is poor, and so testing
scripts which are less complex is a good way to increase the
coverage.
What:
* Create ManageJobsTest which partly tests the maintenance script
by testing an invalid action option and also the delete action
option.
Bug: T371167
Change-Id: I08becca39d9bd070cb70b2a21a9e7da953374668
Why:
* The tests for getText.php do not currently cover the situation
where ::fatalError is called, because before
I554a963c63eb4f22ebb3273053a7b83a33dcb4d1 this would cause the
test suite to exit early.
** After that patch, it will throw an error instead of calling
exit() when running PHPUnit tests.
* With that patch, it is possible to test the script for
situations where we expect ::fatalError to be called.
What:
* Expand GetTextMaintTest to test what happens when the title
argument is invalid (i.e. a invalid page name or a page name
that does not exist).
Bug: T371167
Change-Id: I45f9e7d04c945e1c3a5045c13093bc9170c41ac4
