Commit graph

10 commits

Author SHA1 Message Date
Brion Vibber
014093acc4 More globals and uninitialized variables fixes. Added WebRequest ($wgRequest)
object to encapsulate the handling of get/post variables:

The following grab something out of $_REQUEST. The first parameter is the
variable name and is required. The second is an optional default value:

  $wgRequest->getVal() - any type, returns NULL if no default given
  $wgRequest->getInt() - forced integer, 0 default
  $wgRequest->getText() - runs through $wgLang->recodeInput()
  $wgRequest->getBool() - return true/false
  $wgRequest->getCheck() - returns true if the var is set, even if to ""

$wgRequest strips slashes at initialization if necessary.

Also in this fine object:
  $wgRequest->wasPosted() - returns false if this wasn't a real form post,
    so we can protect against faked submissions in get urls.

There's still plenty of work to do, not everything uses the new functions
yet. To test the strict mode, do define('DEBUG_GLOBALS', 1);
2004-03-08 09:09:35 +00:00
Brion Vibber
0332f4c598 Fix for compatibility with short_open_tag = Off 2004-02-18 02:15:00 +00:00
Tim Starling
3c96949682 * Recent Changes improvements: object oriented back end, move page annotation and (untested) message queue feed.
* Misc. bugs fixed in DatabaseFunctions.php and Skin.php.
* install-utils, install and update utilise Database objects instead of handling their own connections
* schema change for RC improvement -- added rc_type, rc_moved_to_title and rc_moved_to_ns
2004-01-17 05:49:39 +00:00
Mr. E23
bdf73da2d2 The purpose of this modification is to ensure that every normal request
execution starts and ends in wiki.phtml, giving the code a somewhat
more predictable flow.

OutputPage.php:
* Added disable() method to Output class.
* Replaced exit() call in checkLastModified() with "return true" (thereby
  altering its contract quite severly).
* reportTime() now only returns elapsed time, code with side effects
  moved to logProfilingData() in GlobalFunctions.php.

GlobalFunctions.php:
* Added function logProfilingData() which does most of what
  OutputPage->reportTime() used to do.

Article.php:
* Replaced exit() in checkLastModified() with "return true" (thereby altering
  its contract quite severly).
* replaced implicit exit in calls to checkLastModified() and tryFileCache()
  with returns.

LogPage.php:
* replaced implicit exit() with return in call to checkLastModified()

SpecialRecentchanges.php:
* replaced implicit exit() with return in call to checkLastModified()

wiki.phtml:
* Single call to logProfilingData() at the end of the request.
2003-12-11 20:16:34 +00:00
Brion Vibber
64b688bd1d Evan's patch for bug 827757: Wikitext not escaped in log entry descriptions 2003-11-28 07:44:49 +00:00
Tim Starling
7057b4e609 wfQuery now takes three parameters -- one extra for DB replication purposes 2003-09-20 01:34:06 +00:00
Brion Vibber
bec44ccfba Update cache validation timestamp on logs when we update them 2003-08-30 06:11:18 +00:00
Brion Vibber
f92d41d6c3 Date/time fixes: try to ensure that timestamps are always kept in GMT, with conversion where necessary. 2003-06-30 01:33:16 +00:00
Brion Vibber
0dbedf1c7b Cache slow special pages allpages, lonelypages, longpages, shortpages, watnedpages 2003-05-16 11:19:06 +00:00
Lee Daniel Crocker
d82c14fb4f Initial revision 2003-04-14 23:10:40 +00:00