Commit graph

63766 commits

Author SHA1 Message Date
jenkins-bot
dfb3fe9bee Merge "Convert BlockPermissionChecker to Authority" 2021-03-12 23:27:36 +00:00
daniel
9d6c6a4601 Convert BlockPermissionChecker to Authority
Bug: T272039
Change-Id: If20ba1d8ea1d8c75b93bbaf2b0c75c264dba19da
2021-03-12 20:48:09 +01:00
jenkins-bot
118631d369 Merge "Drop MysqlUpdater::doRestrictionsUpdate() and its related sql file." 2021-03-12 19:39:54 +00:00
jenkins-bot
716c52ae89 Merge "Drop MysqlUpdater::doBacklinkingIndicesUpdate() and its related sql file" 2021-03-12 19:39:47 +00:00
jenkins-bot
d9d3011bd7 Merge "Drop MysqlUpdater::doTemplatelinksUpdate() and its related sql file" 2021-03-12 19:34:17 +00:00
Reedy
d0e5057f37 Drop $wgEnableRestAPI, deprecated in and ignored since 1.35
Change-Id: I2cfffb02d5ece67b3ddbbf4cb50e10e60d7ac7a1
2021-03-12 10:06:34 -08:00
jenkins-bot
14059be192 Merge "Add list of thumbnail urls to LocalFilePurgeThumbnails hook" 2021-03-12 16:35:14 +00:00
DannyS712
b8e9c78c7c Remove unused ApiMain::$mCdnMaxAge
Private variable

Change-Id: I138b465d157fbe715069edf6177c75543fee3686
2021-03-12 14:54:34 +00:00
Amir Sarabadani
d1741f8991 Drop MysqlUpdater::doRestrictionsUpdate() and its related sql file.
It was introduced in 1.10 which we don't support direct upgrade from
anymore. Also it has been removed from update.php list and it's not
mentioned anymore.

The other sql file has been removed in I982f9a7018069.

Bug: T272199
Change-Id: Ice40c6962dc558b8370fdbce04e51c0e1ece76ce
2021-03-12 11:43:47 +01:00
Amir Sarabadani
d29685aec0 Drop MysqlUpdater::doBacklinkingIndicesUpdate() and its related sql file
It was introduced in 1.9 which we don't support direct upgrade from
anymore. Also it has been removed from update.php list and it's not
mentioned anymore.

Bug: T272199
Change-Id: Ib8a480cb570f16ae65e52912591e1d3f0c44aaf0
2021-03-12 11:43:41 +01:00
Amir Sarabadani
e1988c3eda Drop MysqlUpdater::doTemplatelinksUpdate() and its related sql file
It was introduced in 1.6 which we don't support direct upgrade from
anymore. Also it has been removed from update.php list and it's not
mentioned anymore.

Bug: T272199
Change-Id: I71aaa4f282271cc9254257e2f2c7f892121870ad
2021-03-12 11:43:40 +01:00
jenkins-bot
534a3b34ee Merge "ApiMain: apply standard coding conventions and cleanup" 2021-03-12 08:07:42 +00:00
Translation updater bot
ff79b440ed Localisation updates from https://translatewiki.net.
Change-Id: If149e53c5df5428c890f8db3ea2dacf47aa1fc7a
2021-03-12 08:44:12 +01:00
jenkins-bot
9c688e1ce3 Merge "WebStart: Avoid conditionally declared functions in this file" 2021-03-12 03:00:18 +00:00
jenkins-bot
32daaf6aef Merge "Hard-deprecate MediaWiki::triggerJobs()" 2021-03-12 02:56:27 +00:00
Florian
e9d9bc48d4 WebStart: Avoid conditionally declared functions in this file
Defining functions conditionally seems to break preloading
functionality, as the function is tried to be redeclared.

Bug: T240775
Change-Id: I7d1df9f13927f0a7af33f9ee955b0ed8dc47a359
2021-03-12 02:39:27 +00:00
jenkins-bot
ff2e1bc266 Merge "Avoid using User::clearNotification()" 2021-03-12 02:38:57 +00:00
jenkins-bot
b8ee27be5d Merge "wfDeprecated: Use InvalidArgumentException for invalid arguments" 2021-03-12 02:37:10 +00:00
Aaron Schulz
ce27d87b27 Hard-deprecate MediaWiki::triggerJobs()
Soft-deprecated in MW 1.34, not used anywhere in Codesearch.

Change-Id: Ibc523744b7451d692a4bc7d8688d157d0effe831
2021-03-12 02:30:59 +00:00
jenkins-bot
55cf7f6e54 Merge "Drop MysqlUpdater::doWatchlistNull() and its related sql file" 2021-03-12 02:29:42 +00:00
Ammarpad
a0d6a4ccd1 wfDeprecated: Use InvalidArgumentException for invalid arguments
Change-Id: I0bf84810cee8c8aa4ca15b7f94fa9467a52b0278
2021-03-12 02:11:04 +00:00
jenkins-bot
ebb6f35375 Merge "rdbms: Group DBPerformance logs by violated measure" 2021-03-12 00:49:39 +00:00
DannyS712
3ec71a7532 ApiMain: apply standard coding conventions and cleanup
Add some documentation too
Should be a no-op

Change-Id: If993ed813b735271933d44f4165a8ad489db59ca
2021-03-11 23:46:53 +00:00
jenkins-bot
daf3a50012 Merge "Convert RecentChange to use UserIdentity and ActorStore" 2021-03-11 19:58:45 +00:00
jenkins-bot
b1896cc758 Merge "Convert MWTimestamp to UserIdentity" 2021-03-11 19:54:50 +00:00
jenkins-bot
d7af1cdbe3 Merge "Convert Language to UserIdentity" 2021-03-11 19:53:34 +00:00
daniel
a11945cc9a Convert MWTimestamp to UserIdentity
Change-Id: I94ecd858a846139a461acd09f29c9bb5e741e492
2021-03-11 19:24:16 +00:00
daniel
7e2f7efa27 Convert Language to UserIdentity
This also introduces minimal instance caching into UserFactory

Change-Id: I594c5668c537477516dda4beecd11b8aa840ae62
2021-03-11 20:23:23 +01:00
daniel
5a058b7c18 Convert RecentChange to use UserIdentity and ActorStore
Note: this removes 'rc_actor' from the public attributes array.
There is no access to this field in any known extension.
It seemed to be there purely by analogy to the database schema.

Bug: T276853
Change-Id: Ib9fe44567660ec1e42cc788f69b9a4101a8a3460
2021-03-11 19:44:29 +01:00
Translation updater bot
14444a19d6 Localisation updates from https://translatewiki.net.
Change-Id: I1612cd35c78332401b479ae3d5ecebfa745fa976
2021-03-11 08:35:28 +01:00
jenkins-bot
0eb18e4b12 Merge "Deprecate constructing revision with non-proper page" 2021-03-11 02:39:17 +00:00
jenkins-bot
600f75010c Merge "ActorNormalization should require a DB connection." 2021-03-10 22:05:17 +00:00
jenkins-bot
2465a9dbc2 Merge "ActorMigration: remove unused UserFactory" 2021-03-10 22:05:11 +00:00
jenkins-bot
0333466972 Merge "Hard deprecate AuthManager::singleton" 2021-03-10 21:29:21 +00:00
Petr Pchelko
eb5eca11b6 Deprecate constructing revision with non-proper page
Bug: T275531
Change-Id: If641a5a901210ba1a1ea6a41fa6a18c08f4183db
2021-03-10 22:05:06 +01:00
daniel
806792281f ActorNormalization should require a DB connection.
ActorNormalization should only be used in contexts where a DB connection
is already being used, or at least easily available.

Bug: T276986
Change-Id: Ie8aadaffa4a30e63fcad0502d45b8ec364fc79ef
2021-03-10 21:43:49 +01:00
jenkins-bot
a569f982c2 Merge "HeaderCallback: Remove pre-caching of WebRequest::getRequestId" 2021-03-10 19:52:56 +00:00
jenkins-bot
a221b2e9d1 Merge "PageUpdater: use UserIdentity where possible" 2021-03-10 19:50:36 +00:00
jenkins-bot
00285a4fb7 Merge "Allow blocked users to access Special:ResetTokens" 2021-03-10 18:48:28 +00:00
Timo Tijhof
5c860e462e HeaderCallback: Remove pre-caching of WebRequest::getRequestId
This effectively reverts ef26a5b07b (I245747d0b6fcdf0f6), which
added the pre-caching to implicity autoload additional classes used by
getRequestId(), per https://phabricator.wikimedia.org/T261260#6630577.

This has since been fixed by 5ab13a054 (Ia542ac7aab7b), which
simplified WebRequest::getRequestId to no longer involve other classes.

The impact of ef26a5b07b was that `$wgAllowExternalReqID` no
longer worked in production, because HeaderCallback is, and has to,
be called in Setup.php prior to loading LocalSettings.php, thus it
couldn't be set in time. This meant the `reqId` logged from MW went
back to the value of UNIQUE_ID or wfRandomString, not X-Request-Id.

Side effects:

* WikimediaDebug can't find XHGui profiles because
  wmf-config/profiler.php sees `X-Request-Id`, whereas the JS code
  that exported the value of `getRequestId` does not, thus they have
  different IDs.

* Logstash search for a reqId no longer find messages correlating
  with php-wmerrors (puppet php7-fatal-erorr.php), same issue as
  XHGui.

* Logstash results from Varnish, ATS, or Apache don't correlate with
  MW log messages, etc.

Bug: T273256
Change-Id: I3d5f440591c83d7f8c133e3e3a544175313bbd6b
2021-03-10 18:29:55 +00:00
jenkins-bot
6645d7a429 Merge "Fix various typos" 2021-03-10 18:15:13 +00:00
jenkins-bot
6978577273 Merge "Avoid using UserIdentity::getUserId" 2021-03-10 18:10:04 +00:00
jenkins-bot
32aa9cb705 Merge "Fixed typo "paramaters"" 2021-03-10 17:39:19 +00:00
Reedy
f4f3064036 Fix various typos
Mostly 'transcation'

Change-Id: Id021fe6bfb5ed7acd8cf9c0213a343c342b6184f
2021-03-10 17:29:10 +00:00
jenkins-bot
bbfc91be43 Merge "Comments: use only // instead of more" 2021-03-10 17:24:44 +00:00
sahil
08a75b5ad9 Fixed typo "paramaters"
Changed from paramaters to parameters in mediawiki / core

Bug: T201491
Change-Id: I85caee07603c2599562b5719b45bb63184b74b49
2021-03-10 22:37:58 +05:30
jenkins-bot
4080893d15 Merge "Fix doc for hook error in GetUserPermissionsErrorsExpensiveHook" 2021-03-10 17:00:41 +00:00
jenkins-bot
f07585a831 Merge "Fix documentation for hook error in UserCanSendEmailHook" 2021-03-10 16:54:43 +00:00
Bartosz Dziewoński
c954cc85ea Allow blocked users to access Special:ResetTokens
Bug: T277009
Change-Id: I6864bc0a7cba48107aa4b6d367f8ff55a28ad677
2021-03-10 17:16:07 +01:00
DannyS712
35bd84e9ee Comments: use only // instead of more
No need for three or more slashes

Except in some places where a bunch more are
used for drawing attention to something

Change-Id: Ic90358eb89a14a04d2b66c48e52e8fb20de0eb04
2021-03-10 15:05:57 +00:00