Commit graph

123 commits

Author SHA1 Message Date
Alexandre Emsenhuber
3d57cb9db8 * Use Html::linkedScript() and Html::inlineScript() 2010-06-02 19:28:44 +00:00
Alexandre Emsenhuber
9ab3d55384 Fixed some doxygen warnings and documented a bit 2010-05-23 19:25:07 +00:00
Sam Reed
b6e0df246f Attempt at normalistion of comparison styles - empty string on left and right hand side normalised to it being on the rhs
Before this change, there were (? being regex 0 or 1)

"" ===? 1
'' ===? 24
"" !==? 8
'' !==? 32

== "" 14
== '' 344
!= "" 9
!== "" 4
!= '' 151
!== '' 85


Rhs was the much more common, and the preferred style by many developers.. (Was a similar discussion in #mediawiki recently.. After that lolbugreport i think)

Where there is a string (non empty) on the lhs, and variable/method call on the rhs still need normalising
2010-01-06 19:59:42 +00:00
Matěj Grabovský
4a099928f7 (bug 21455) Fixed "Watch this page" checkbox appearing on some special pages even to non-logged in users 2009-11-14 11:07:46 +00:00
Bryan Tong Minh
6fec9d682b Follow-up to r58633 and r58628 (lqt): Rename Title::getProtectionTypes to Title::getRestrictionTypes and fix the hook name. 2009-11-09 12:05:30 +00:00
Andrew Garrett
f6f5e90888 Enabling changes for r56828: some refactoring and code cleanup of the protection interface, including a new hook, generalisation to more restriction types than edit/move, and some other related changes. 2009-11-06 10:27:44 +00:00
Bryan Tong Minh
37a8e9a147 * (bug 6579) Fixed protecting images from uploading only
* Added upload by default to $wgRestrictionTypes

Also requires MessagesEn.php accidently committed in r58536
2009-11-04 12:55:00 +00:00
Aaron Schulz
0d833fe671 * Added $wgFlaggedRevsProtectLevels to allow for site defined review "protection" levels. Disables stabilization and a small fieldset to the protection form with the options.
* Added three ProtectionForm hooks for the above
* Removed PHP4-ism from getPageVisibilitySettings()
2009-10-02 18:46:19 +00:00
Alex Z
c255da09f0 (bug 20136) Synchronize the protection form expiry boxes onchange in addition to onkeyup.
Technically the onkeyup handler is redundant, but at least on Firefox, onchange doesn't run
until after the input loses focus, so its somewhat less intuitive, but necessary if the user
clicks an option from a browser's autosuggestion
2009-09-06 04:10:26 +00:00
Ryan Schmidt
bed5f5d54e * Add autopromote condition APCOND_BLOCKED to autopromote blocked users to various user groups.
* Add $wgRemoveGroups as a means of restricting a group's rights. The syntax is identical to $wgGroupPermissions, but users in these groups will have these rights stripped from them.
* Modify Special:ListGroupRights so that it displays revoked permissions as well (the display of assigned vs. revoked is changeable via css).
* Bump $wgStyleVersion
2009-06-18 02:50:16 +00:00
Alexandre Emsenhuber
36b535d199 Kill some E_NOTICE when protecting a non-existing page 2009-06-12 18:31:07 +00:00
Alexandre Emsenhuber
8e2e5d473e Fix for r51493, r51084 and realted: use Title::makeTitle() rather than Title::newFromText() 2009-06-05 13:12:15 +00:00
Siebrand Mazeland
e17b75e76a Follow-up to r51084:
* address case sensitivity issue raised by Splarka on CR
* also change to edit link on Special:Block
2009-06-05 07:33:57 +00:00
Siebrand Mazeland
f8f8dd2cb2 Fix a usability issue on protect and [file ]delete forms. "Edit ... reasons" link now contains action=edit to save a click. 2009-05-27 20:35:16 +00:00
Niklas Laxström
4bb02cdc33 * Follow-up for r50691, add \n to be safe in case there is line-start sensitive markup 2009-05-17 15:44:51 +00:00
Siebrand Mazeland
1f4160caa1 (bug 18522) Wrap MediaWiki:Protect-cascadeon in a div for identification (patch by Happy-melon) 2009-05-17 14:57:30 +00:00
Siebrand Mazeland
547858b7fe Use link() instead of deprecated makeLinkObj() where possible. 2009-05-08 23:24:31 +00:00
Chad Horohoe
2664b438f1 Remove some unused $wgOut's. 2009-04-07 15:56:26 +00:00
Aaron Schulz
c800133fbd Break line 2009-01-26 19:11:34 +00:00
Raimond Spekking
3fd4899655 Replaced some hardcoded colons with the colon-separator message 2009-01-07 22:49:54 +00:00
Aaron Schulz
eaf7243c5f (bug 16507) Not setting "other time" on creation unprotection error removed 2009-01-03 16:33:15 +00:00
Siebrand Mazeland
c678efcab2 Split date ($2) and time ($3) in 'protect-existing-expiry' per request of a translator. Leaving the old timestamp ($1) in for backward compatibility. 2008-10-06 20:01:43 +00:00
Chad Horohoe
414360a350 +a few docs 2008-10-06 15:31:03 +00:00
Alex Z
7049385253 Use a new message for protection form expiry options instead of recycling the blockip one. 2008-09-29 01:35:04 +00:00
Alex Z
2e373adf83 * (bug 15701) Protection form was too wide for some browsers as 2 columns, switching to 1 column format.
* Move the "unlock move permissions" checkbox to a more logical place with the options for move protection, instead of with the cascading checkbox.
2008-09-25 02:08:59 +00:00
Aaron Schulz
c4d743ec39 Shorten expiry box 2008-09-24 11:53:03 +00:00
Raimond Spekking
09049f4e32 Add a link to edit the proction reason list 2008-09-22 16:16:37 +00:00
Alex Z
6f2e810f8b Tweak to ProtectionForm: Title::getRestrictionExpiry returns 'infinity' for 'infinite' 2008-09-16 18:46:58 +00:00
Tim Starling
fd30ddc11a In protect.js:
* Use fragments of English when naming things, instead of a jumble of words vaguely related to the topic
* Use verbs in function names that are related to what the functions do
* Move all functions into an object, to avoid prefixes that look like part of a nonsensical sentence
* Fixed a bug whereby the "move" controls would not be unlocked if the expiry times differed. Refactored the relevant code.
* When the user types something into the "other time" box, automatically select "other time" from the drop-down list.

In ProtectionForm:
* Use the new protect.js interface
* Use accessor instead of Title member variable mRestrictionsExpiry
* Added an "existing expiry" option to the expiry drop-down list, instead of putting the ISO 8601 time in the "other" box
* Formatting
* Fixed convoluted expiry time data flow, documented
* s/List/Selection, for variables containing a value that the user has selected from a list
2008-09-16 04:09:06 +00:00
Alex Z
3a4183931c Allow cascading protection to be turned off without changing other settings 2008-09-14 01:11:54 +00:00
Aaron Schulz
cfda5fb062 make "other time" chain properly with JS 2008-09-13 09:24:51 +00:00
Aaron Schulz
66c1402e25 Cleanup for r40770:
* Clean up protection form
* Fix syntax typo (use '==', not '=')
* Fix $2 message in movepage cascade warning
2008-09-13 08:53:07 +00:00
Alex Z
807c3afaa7 (bug 12650) Make it possible to enter separate expiry times for each restriction type. 2008-09-13 05:33:24 +00:00
Alexandre Emsenhuber
0512db6bc3 We already have an Article object, so no need to recreate another one.
Also removed some PHP4-ism.
2008-09-11 20:01:39 +00:00
Rotem Liss
d3808460a6 Protection form: Show action as header of an action if the message for this action does not exist. 2008-09-07 08:28:45 +00:00
Rotem Liss
b4841ed400 Show properly-sized select elements in protection form when the user does not have a specific permission. 2008-09-07 08:24:00 +00:00
Aaron Schulz
d347a1a785 Some form consistency tweaks 2008-09-07 01:10:35 +00:00
Aaron Schulz
537d20c03b * Add time/reason dropdown for protect form (bug 10799)
* Shorten message
2008-09-06 23:20:58 +00:00
Aaron Schulz
a5fae953fd Fix regression from r40518; keep current values of page when no query params given 2008-09-06 17:12:45 +00:00
Aaron Schulz
b7b98cda92 Set values from query params (bug 12750) 2008-09-06 07:20:13 +00:00
Aryeh Gregor
650be91fb8 Refactor a bit preparatory to fixing bug 8068: rewrite the robot policy stuff in OutputPage to allow index and follow policy to be set separately. Also now validates input to setRobotPolicy(). And renamed setRobotpolicy to setRobotPolicy, too. If anyone was accessing $mRobotpolicy directly they're out of luck, though. 2008-07-23 19:05:43 +00:00
Ryan Schmidt
bbbd2e176a * fix error in buildSelector function 2008-07-02 01:44:20 +00:00
Aaron Schulz
7887c332de * Revert r36478; I don't see the point in this cryptic code
* Restore r36273 as explain on mailing list
2008-06-21 03:17:35 +00:00
Alexandre Emsenhuber
17a9beebd6 Note that restrictions are rights, not groups. So now, cascading protection will be allowed if all groups that have the right being check have the 'protect' right too. 2008-06-19 20:40:41 +00:00
Bryan Tong Minh
65e1c0cdeb Removed $wgEnableCascadingProtection. It was a quite pointless configuration setting which was not even properly implemented. Cascading protection has been always possible regardless of this configuration setting. 2008-06-11 21:36:07 +00:00
Ryan Schmidt
0f1cbdc80f * fixing bug 14241: pages can no longer be protected to levels you are not in 2008-05-24 16:49:05 +00:00
Alexandre Emsenhuber
087a9f70c5 WARNING: HUGE COMMIT
Doxygen documentation update:
* Changed alls @addtogroup to @ingroup. @addtogroup adds the comment to the group description, but doesn't add the file, class, function, ... to the group like @ingroup does. See for example http://svn.wikimedia.org/doc/group__SpecialPage.html where it's impossible to see related files, classes, ... that should belong to that group.
* Added @file to file description, it seems that it should be explicitely decalred for file descriptions, otherwise doxygen will think that the comment document the first class, variabled, function, ... that is in that file.
* Removed some empty comments
* Removed some ?>

Added following groups:
* ExternalStorage
* JobQueue
* MaintenanceLanguage

One more thing: there are still a lot of warnings when generating the doc.
2008-05-20 17:13:28 +00:00
Niklas Laxström
2b6cfa578c * Expiry handling is really sub-optimal here 2008-04-18 06:57:47 +00:00
Brion Vibber
cf814a87c6 Cleanup for r33429 - fix double-escaping 2008-04-16 17:40:47 +00:00
Raimond Spekking
6c9f80faad * Use existing CSS classes for input form aligning
* Use more XML functions
2008-04-16 15:58:25 +00:00