Commit graph

629 commits

Author SHA1 Message Date
Platonides
121bb4f03e http://www.mediawiki.org/wiki/User:Catrope/Stub_threshold shows us people setting it to insanely large values trying to disable it.
r70433 addressed the UI. Here we proxy its access via a new method getStubThreshold() that disables it if a page of such size cannot be 
created (by an user), so we can serve them parser cached articles again.
2010-08-03 22:32:09 +00:00
Platonides
a9b5c1402c Remove all calls to $wgMessageCache->loadAllMessages()
Deprecated and empty since r52503
2010-08-03 19:15:43 +00:00
Alexandre Emsenhuber
5170726319 * (bug 21503) There's now a "reason" field when creating account for other users 2010-08-01 10:42:53 +00:00
Bryan Tong Minh
d7e6870b8f Made asynchronous upload by URL working, partly. Hid it behind $wgAllowAsyncCopyUploads. If there are no errors then everything works expected; the same if there are unrecoverable errors. User intervention to solve warnings is not yet possible, because $_SESSION is not available in runJobs. This also means that async with leavemessage = false is broken.
Other changes:
* Moved verifyPermissions check in ApiUpload down pending r70135 implementation in the API.
* In User::leaveMessage: append message to end of talk page; add a newline before the heading
2010-07-29 13:53:51 +00:00
Alexandre Emsenhuber
2fcadccbd3 Removed PHP4-ism 2010-07-25 11:26:52 +00:00
Sam Reed
04f68827d0 Removal of unused globals
Removal of one setting of a variable to '', then not using further
2010-07-24 19:11:52 +00:00
Aryeh Gregor
1b1d821d16 Remove 'minordefault' preference completely
See bug 24313.  The preference encourages people to mark changes minor
by mistake, but it's better to have minor changes not marked minor than
non-minor changes marked minor.  enwiki users at [[Help talk:Minor
edit]] seemed to think it was a good idea.  Plus, I'm always in favor of
removing user preferences where possible.

The only likely fallout of note is some bot operators who didn't notice
this suddenly find their bot not marking anything minor.  I doubt it
will cause major problems, though.
2010-07-14 18:50:32 +00:00
Max Semenik
f00c37c21c Removed User::setLoaded(), deprecated since times forgotten 2010-07-09 21:27:36 +00:00
Alexandre Emsenhuber
fc37e7ed21 Fixed some doxygen warnings 2010-07-05 09:14:29 +00:00
Tim Starling
1fcfd134d1 * Integrated the selenium tests into MediaWiki properly, and removed the insecure LocalSeleniumSettings.php concept.
* Removed the insecure web entry point hiding in the maintenance directory, in RunSeleniumTests.php. Replaced it with a special page interface, with CSRF protection and access control. If you wanted a secure web entry point, then I suppose this is how it would be done, but I think it should be killed ASAP.
* As in r68544, removed as many require() calls as possible, since nobody seems to know how to do them properly. Made the usual changes to make classes autoloader-compatible: class constants instead of define(), no file-scope registration code.
2010-06-25 05:55:23 +00:00
Aryeh Gregor
279172d5f9 Password not always required on account creation
Bug 23769.  It's not required when the account is being created by
e-mail, regardless of $wgMinimalPasswordLength.  This commit technically
does nothing, given r67283, but it will keep the bug fixed even in the
future when r67283 can be reverted.
2010-06-03 17:31:14 +00:00
Sean Colombo
55e9ddb509 Removed an unused local variable in a User function. 2010-05-28 19:01:00 +00:00
Chad Horohoe
7599dbc87b Use __METHOD__ in a few places 2010-05-21 12:57:26 +00:00
Mark A. Hershberger
8bc618945d re r66702 Use wfMsgForContent instead of wfMsg 2010-05-21 00:52:07 +00:00
Raimond Spekking
b0da00749c Follow-up r66698: Fix syntax error (missing ;) 2010-05-20 19:02:45 +00:00
Mark A. Hershberger
4f01b9f10b * Add formatting for user messages.
** First, try a hook for the user messages
** Next, check for a template
** Otherwise, do something sane.
2010-05-20 18:47:13 +00:00
Mark A. Hershberger
0a4586c223 * Since it makes sense (to me :) to make the arguments for the two UserMessage hooks more uniform, do it.
* Document these hooks in doc/hooks.txt
2010-05-20 02:12:04 +00:00
Mark A. Hershberger
17a88424a4 re: r66438 Fix doc string, add usermessage-editor to $wgReservedUsernames 2010-05-18 00:14:57 +00:00
Mark A. Hershberger
ec31dd602e Start adding support for leaving user's messages. Begin using it in UploadFromUrl.php
In the end, we should probably use a template if its around and do something sane with the subject line if not.
2010-05-14 20:36:23 +00:00
Conrad Irwin
7b29f47a8e Put a 235 byte limit on usernames to allow /thelongskinname.css to work (bug 23080) 2010-04-15 22:41:49 +00:00
Siebrand Mazeland
6e856741bc Remove the 'editwidth' preference and related code.
I was not able to find any scenario that changed editor behavior anymore in monobook, modern, vector, classic or chick skin.
2010-04-15 18:11:24 +00:00
Victor Vasiliev
ef9bf1cd5d Add $wgLogAutocreatedAccounts to enable/disable account autocreation logging. 2010-04-10 06:21:13 +00:00
Tim Starling
7bb661a0d2 * (bug 23076) Fixed login CSRF vulnerability. Logins now require a token to be submitted along with the user name and password. Patch by Roan Kattouw. 2010-04-07 00:05:33 +00:00
Alexandre Emsenhuber
21e953c65c * (bug 22606) The body of e-mail address confirmation message is now different when the address changed 2010-02-27 20:22:56 +00:00
Mark A. Hershberger
83fab88490 follow up r61715 - minor style nit 2010-02-26 02:34:00 +00:00
Tobias
8c56cd8d8d newFromName: Fixing error in the documentation and adding IP address as an example. No code change 2010-02-19 10:51:03 +00:00
Chad Horohoe
4cf0a86548 Use __METHOD__ 2010-02-17 01:28:48 +00:00
Tim Starling
5dd32479ff Revert r58025 (User::newFromName() returns WikiError under certain circumstances). Incomplete, breaks lots of things, see CR. 2010-02-03 07:39:32 +00:00
Chad Horohoe
ce74cf8d09 Check $this not $wgUser in canSendEmail() 2010-01-30 16:20:54 +00:00
Victor Vasiliev
d668c11fc2 Fix "you are blocked" message for users who were blocked by zero-ID user. 2010-01-30 14:27:28 +00:00
Chad Horohoe
09c32f5e02 Followup r61694, expand comment based on [[Extension:Lockout]] and also deny login from session 2010-01-30 01:28:58 +00:00
Tim Starling
0e94ef3836 Reverted r58313, pointless, does not fix the bug. 2010-01-07 23:36:08 +00:00
Mark A. Hershberger
9ef63ede49 Random eol whitespace found while treking through files.
Removing unused call to $wgContLang->getFormattedNsText() from addNewUserLogEntry()
2010-01-06 03:42:30 +00:00
Alexandre Emsenhuber
468e87651a Per Tim Starling, fixes for r58061:
* renamed $wgEnableSorbs to $wgEnableDnsBlacklist and $wgSorbsUrl to $wgDnsBlacklistUrls (backward compatibility kept)
* renamed User::inSorbsBlacklist() to User::isDnsBlacklisted()
2009-12-30 12:32:40 +00:00
Raimond Spekking
18ed54d077 Tweak 'HMTL 5' -> 'HTML5' per suggestion on translatewiki: http://translatewiki.net/wiki/Thread:Support/HTML5
See http://en.wikipedia.org/wiki/HTML5 too.
2009-12-30 07:08:52 +00:00
Aaron Schulz
369f0535b5 Fixed r57659 for high concurrency situations 2009-12-21 17:51:10 +00:00
Domas Mituzas
46875f0484 Reverting r59993, per Tim's comment at http://www.mediawiki.org/wiki/Special:Code/MediaWiki/59993#c4885
Still, we need to rethink user 'invalidations' (probably by replacing user object, rather than just touching the user). There are way too many invalidation cases out there, that happen in parallel blocking out each other.
2009-12-21 16:13:15 +00:00
Aryeh Gregor
3399512711 Begin work on allowing extauth login from cookies
Still need to actually do the user creation, but some more framework is
in place for when I want to continue work.
2009-12-14 00:53:13 +00:00
Alexandre Emsenhuber
270950f611 * (bug 21441) meta=userinfo&uiprop=options no longer returns default options for logged-in users under certain circumstances
User::$mOptions is no now only set when calling User::loadOptions() and thus remain null on cache hit and thus the api displays default user settings
2009-12-13 20:55:09 +00:00
Domas Mituzas
10b048af34 I fail to see why we need to invalidate cache on watchlist edits here, do we store full watchlist in user object? 2009-12-12 14:52:01 +00:00
Chad Horohoe
a4e5e935b6 Mass convert NULL -> null. Left strings and comments alone, obviously. 2009-12-11 21:07:27 +00:00
OverlordQ
a989843cd0 Code cleanup, covert leading spaces into tabs per coding style 2009-11-14 21:27:13 +00:00
Roan Kattouw
68b2e720c0 Revert accidentally committed stuff in r58399 2009-11-01 19:48:18 +00:00
Chad Horohoe
70a038b808 Fix another regression from r57558, bug 21369 - Lowercase logins causes MediaWiki to crash 2009-11-01 13:58:37 +00:00
Roan Kattouw
1d471caa46 API: (bug 19004) Add support for tags. Patch by Matthew Britton 2009-11-01 10:42:41 +00:00
Jure Kajzer
03d3a3f4ea Switch to default skin if user session found without persistent creds. Bug 19048 2009-10-29 14:19:05 +00:00
Ryan Schmidt
9b4135e9f8 * re-commit r58172 with the fix for the issue mentioned where users would not be able to log in 2009-10-28 17:53:36 +00:00
Raimond Spekking
c4b785221f Revert r58171/r58172 for now. It seems it breaks login to translatewiki.net 2009-10-27 07:13:13 +00:00
Ryan Schmidt
b99614119a * User::isValidPassword now only returns boolean results, User::getPasswordValidity can be used to get an error message string 2009-10-26 23:19:09 +00:00
Ryan Schmidt
b28171af6f * Any strings returned by the isValidPassword hook are now shown as error messages instead of MediaWiki thinking that the hook said the password was valid.
* The error message shown in Special:ChangePassword now parses wiki markup
2009-10-26 22:58:39 +00:00